Skip to contentSkip to conversation

lib: Apply x/y offsets to GPGPU fill

PATCH In review Christoph Manszewski 3 participants 7 messages Jun 9, 2023 – Jun 14, 2023 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 lib: Apply x/y offsets to GPGPU fill

Actually honour the caller provided destination region and pass the x/y offsets to the thread group.

---
 lib/gpgpu_fill.c |  4 +---
 lib/gpu_cmds.c   | 29 +++++++++++++++--------------
 lib/gpu_cmds.h   |  1 +
 3 files changed, 17 insertions(+), 17 deletions(-)
lib/gpgpu_fill.c +1 -3
index d854fbf7..eed82187 100644
@@ -315,8 +315,6 @@ __xehp_gpgpu_fillfunc(int i915,
 {
 	struct intel_bb *ibb;
 	struct xehp_interface_descriptor_data idd;
-	(void) x;
-	(void) y;
 
 	ibb = intel_bb_create(i915, PAGE_SIZE);
 	intel_bb_add_intel_buf(ibb, buf, true);
@@ -335,7 +333,7 @@ __xehp_gpgpu_fillfunc(int i915,
 	xehp_emit_state_compute_mode(ibb);
 	xehp_emit_state_binding_table_pool_alloc(ibb);
 	xehp_emit_cfe_state(ibb, THREADS);
-	xehp_emit_compute_walk(ibb, width, height, &idd, color);
+	xehp_emit_compute_walk(ibb, x, y, width, height, &idd, color);
 
 	intel_bb_out(ibb, MI_BATCH_BUFFER_END);
 	intel_bb_ptr_align(ibb, 32);
lib/gpu_cmds.c +15 -14
index 1f321ae4..aecba928 100644
@@ -636,10 +636,10 @@ gen7_emit_gpgpu_walk(struct intel_bb *ibb,
 	 * Then thread group X = width / 16 (aligned to 16)
 	 * thread group Y = height;
 	 */
-	x_dim = (width + 15) / 16;
-	y_dim = height;
+	x_dim = (x + width + 15) / 16;
+	y_dim = y + height;
 
-	tmp = width & 15;
+	tmp = (x + width) & 15;
 	if (tmp == 0)
 		right_mask = (1 << 16) - 1;
 	else
@@ -657,11 +657,11 @@ gen7_emit_gpgpu_walk(struct intel_bb *ibb,
 		  0); /* width:1 */
 
 	/* thread group X */
-	intel_bb_out(ibb, 0);
+	intel_bb_out(ibb, x / 16);
 	intel_bb_out(ibb, x_dim);
 
 	/* thread group Y */
-	intel_bb_out(ibb, 0);
+	intel_bb_out(ibb, y);
 	intel_bb_out(ibb, y_dim);
 
 	/* thread group Z */
@@ -693,10 +693,10 @@ gen8_emit_gpgpu_walk(struct intel_bb *ibb,
 	 * Then thread group X = width / 16 (aligned to 16)
 	 * thread group Y = height;
 	 */
-	x_dim = (width + 15) / 16;
-	y_dim = height;
+	x_dim = (x + width + 15) / 16;
+	y_dim = y + height;
 
-	tmp = width & 15;
+	tmp = (x + width) & 15;
 	if (tmp == 0)
 		right_mask = (1 << 16) - 1;
 	else
@@ -715,12 +715,12 @@ gen8_emit_gpgpu_walk(struct intel_bb *ibb,
 		     0); /* width:1 */
 
 	/* thread group X */
-	intel_bb_out(ibb, 0);
+	intel_bb_out(ibb, x / 16);
 	intel_bb_out(ibb, 0);
 	intel_bb_out(ibb, x_dim);
 
 	/* thread group Y */
-	intel_bb_out(ibb, 0);
+	intel_bb_out(ibb, y);
 	intel_bb_out(ibb, 0);
 	intel_bb_out(ibb, y_dim);
 
@@ -948,6 +948,7 @@ xehp_emit_state_base_address(struct intel_bb *ibb)
 
 void
 xehp_emit_compute_walk(struct intel_bb *ibb,
+		       unsigned int x, unsigned int y,
 		       unsigned int width, unsigned int height,
 		       struct xehp_interface_descriptor_data *pidd,
 		       uint8_t color)
@@ -965,8 +966,8 @@ xehp_emit_compute_walk(struct intel_bb *ibb,
 	 * Then thread group X = width / 16 (aligned to 16)
 	 * thread group Y = height;
 	 */
-	x_dim = (width + 15) / 16;
-	y_dim = height;
+	x_dim = (x + width + 15) / 16;
+	y_dim = y + height;
 
 	intel_bb_out(ibb, XEHP_COMPUTE_WALKER | 0x25);
 
@@ -994,8 +995,8 @@ xehp_emit_compute_walk(struct intel_bb *ibb,
 	intel_bb_out(ibb, 1);					//dw9
 
 	/* group id x/y/z */
-	intel_bb_out(ibb, 0);					//dw10
-	intel_bb_out(ibb, 0);					//dw11
+	intel_bb_out(ibb, x / 16);				//dw10
+	intel_bb_out(ibb, y);					//dw11
 	intel_bb_out(ibb, 0);					//dw12
 
 	/* partition id / partition size */
lib/gpu_cmds.h +1 -0
index 92cbbde9..b7ed64f8 100644
@@ -138,6 +138,7 @@ xehp_emit_state_base_address(struct intel_bb *ibb);
 
 void
 xehp_emit_compute_walk(struct intel_bb *ibb,
+		       unsigned int x, unsigned int y,
 		       unsigned int width, unsigned int height,
 		       struct xehp_interface_descriptor_data *pidd,
 		       uint8_t color);
Signature · 1 line
2.40.1
#1 lore raw

PATCH 2/2 lib: Apply rightmost execution mask to xehp gpu walker

The final thread group in each row may need partial execution (not the full simd16) in order to fit within the region of interest.

---
 lib/gpu_cmds.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
lib/gpu_cmds.c +8 -2
index aecba928..48fe1e13 100644
@@ -953,7 +953,7 @@ xehp_emit_compute_walk(struct intel_bb *ibb,
 		       struct xehp_interface_descriptor_data *pidd,
 		       uint8_t color)
 {
-	uint32_t x_dim, y_dim;
+	uint32_t x_dim, y_dim, mask;
 
 	/*
 	 * Simply do SIMD16 based dispatch, so every thread uses
@@ -969,6 +969,12 @@ xehp_emit_compute_walk(struct intel_bb *ibb,
 	x_dim = (x + width + 15) / 16;
 	y_dim = y + height;
 
+	mask = (x + width) & 15;
+	if (mask == 0)
+		mask = (1 << 16) - 1;
+	else
+		mask = (1 << mask) - 1;
+
 	intel_bb_out(ibb, XEHP_COMPUTE_WALKER | 0x25);
 
 	intel_bb_out(ibb, 0); /* debug object */		//dw1
@@ -980,7 +986,7 @@ xehp_emit_compute_walk(struct intel_bb *ibb,
 	intel_bb_out(ibb, 1 << 30 | 1 << 25 | 1 << 17);		//dw4
 
 	/* Execution mask */
-	intel_bb_out(ibb, 0xffffffff);				//dw5
+	intel_bb_out(ibb, mask);				//dw5
 
 	/* x/y/z max */
 	intel_bb_out(ibb, (x_dim << 20) | (y_dim << 10) | 1);	//dw6
Signature · 1 line
2.40.1
Reviewed-by on v1 2/2
#2 lore raw

Re: [igt-dev] [PATCH i-g-t 2/2] lib: Apply rightmost execution mask to xehp gpu walker

Quoted 5 lines · Christoph Manszewski

The final thread group in each row may need partial execution (not the full simd16) in order to fit within the region of interest.

Quoted 39 lines
---
 lib/gpu_cmds.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
lib/gpu_cmds.c +8 -2
index aecba928..48fe1e13 100644
@@ -953,7 +953,7 @@ xehp_emit_compute_walk(struct intel_bb *ibb,
 		       struct xehp_interface_descriptor_data *pidd,
 		       uint8_t color)
 {
-	uint32_t x_dim, y_dim;
+	uint32_t x_dim, y_dim, mask;
 
 	/*
 	 * Simply do SIMD16 based dispatch, so every thread uses
@@ -969,6 +969,12 @@ xehp_emit_compute_walk(struct intel_bb *ibb,
 	x_dim = (x + width + 15) / 16;
 	y_dim = y + height;
 
+	mask = (x + width) & 15;
+	if (mask == 0)
+		mask = (1 << 16) - 1;
+	else
+		mask = (1 << mask) - 1;
+
 	intel_bb_out(ibb, XEHP_COMPUTE_WALKER | 0x25);
 
 	intel_bb_out(ibb, 0); /* debug object */		//dw1
@@ -980,7 +986,7 @@ xehp_emit_compute_walk(struct intel_bb *ibb,
 	intel_bb_out(ibb, 1 << 30 | 1 << 25 | 1 << 17);		//dw4
 
 	/* Execution mask */
-	intel_bb_out(ibb, 0xffffffff);				//dw5
+	intel_bb_out(ibb, mask);				//dw5
 
 	/* x/y/z max */
 	intel_bb_out(ibb, (x_dim << 20) | (y_dim << 10) | 1);	//dw6
#3 lore raw

[igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/2] lib: Apply x/y offsets to GPGPU fill

In reply to Christoph Manszewski
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,1/2] lib: Apply x/y offsets to GPGPU fill
URL : https://patchwork.freedesktop.org/series/119126/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/904516 for the overview.

build-containers:build-debian has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/43454554):
time="2023-06-09T10:23:15Z" level=fatal msg="Error determining repository tags: Invalid status code returned when fetching tags list 500 (Internal Server Error)"
Building!
STEP 1: FROM debian:buster
Getting image source signatures
Copying blob sha256:c722db24a050621ee87ea07acd5d066d3d6a94737c32012f27d73a1ad5cc645c
Copying config sha256:8b5601a5a7f855241ac7f372ec0042e793b0b3eb3f3a601014845f22bd371c90
Writing manifest to image destination
Storing signatures
STEP 2: RUN apt-get update
error running container: error creating container for [/bin/sh -c apt-get update]: time="2023-06-09T10:23:22Z" level=warning msg="signal: killed"
time="2023-06-09T10:23:22Z" level=error msg="container_linux.go:346: starting container process caused \"process_linux.go:297: applying cgroup configuration for process caused \\\"mountpoint for cgroup not found\\\"\"\n" container_linux.go:346: starting container process caused "process_linux.go:297: applying cgroup configuration for process caused \"mountpoint for cgroup not found\""
: exit status 1
Error: error building at STEP "RUN apt-get update": error while running runtime: exit status 1
section_end:1686306205:step_script
section_start:1686306205:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1686306209:cleanup_file_variables
ERROR: Job failed: exit code 1

build-containers:build-debian-arm64 has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/43454556):
time="2023-06-09T10:23:00Z" level=fatal msg="Error determining repository tags: Invalid status code returned when fetching tags list 500 (Internal Server Error)"
Building!
STEP 1: FROM debian:buster
Getting image source signatures
Copying blob sha256:c722db24a050621ee87ea07acd5d066d3d6a94737c32012f27d73a1ad5cc645c
Copying config sha256:8b5601a5a7f855241ac7f372ec0042e793b0b3eb3f3a601014845f22bd371c90
Writing manifest to image destination
Storing signatures
STEP 2: RUN apt-get update
error running container: error creating container for [/bin/sh -c apt-get update]: time="2023-06-09T10:23:04Z" level=warning msg="signal: killed"
time="2023-06-09T10:23:04Z" level=error msg="container_linux.go:346: starting container process caused \"process_linux.go:297: applying cgroup configuration for process caused \\\"mountpoint for cgroup not found\\\"\"\n" container_linux.go:346: starting container process caused "process_linux.go:297: applying cgroup configuration for process caused \"mountpoint for cgroup not found\""
: exit status 1
Error: error building at STEP "RUN apt-get update": error while running runtime: exit status 1
section_end:1686306184:step_script
section_start:1686306184:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1686306185:cleanup_file_variables
ERROR: Job failed: exit code 1

build-containers:build-debian-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/43454557):

      "DockerVersion": "",
      "Labels": {},
      "Architecture": "amd64",
      "Os": "linux",
      "Layers": [
          "sha256:04854e5e3796b945522a085073b5a49cadad51bd1c5414c91654fa3d63d8db4d"
      ]

}
Skipping, already built
Getting image source signatures
Copying blob sha256:04854e5e3796b945522a085073b5a49cadad51bd1c5414c91654fa3d63d8db4d
Copying config sha256:cc55efdc667be826910d414a562c76ce1130a9c15255a0dd115431bc42f83448
Writing manifest to image destination
time="2023-06-09T10:23:19Z" level=fatal msg="Error writing manifest: Error uploading manifest commit-3fc7d9ad3bad16e7596b9633f1d5ce1cb6fc9c9a to registry.freedesktop.org/gfx-ci/igt-ci-tags/build-debian-mips: received unexpected HTTP status: 500 Internal Server Error" section_end:1686306200:step_script
section_start:1686306200:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1686306204:cleanup_file_variables
ERROR: Job failed: exit code 1

build-containers:build-fedora has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/43454558):

      "DockerVersion": "",
      "Labels": {
          "maintainer": "Clement Verna \[email protected]\u003e"
      },
      "Architecture": "amd64",
      "Os": "linux",
      "Layers": [
          "sha256:b39735705e69a2516323755ff4698ea5cd86b08b31d8c8287bc83d76d34c3bfc"
      ]

}
Skipping, already built
Getting image source signatures
Copying blob sha256:b39735705e69a2516323755ff4698ea5cd86b08b31d8c8287bc83d76d34c3bfc
time="2023-06-09T10:23:03Z" level=fatal msg="Error reading config blob sha256:4b3054d89ef79f9be95501786fbbbe22857d02c867fff99693808cd80909939f: Invalid status code returned when fetching blob 500 (Internal Server Error)" section_end:1686306183:step_script
section_start:1686306183:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1686306184:cleanup_file_variables
ERROR: Job failed: exit code 1

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/904516

#4 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib: Apply x/y offsets to GPGPU fill

In reply to Christoph Manszewski
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,1/2] lib: Apply x/y offsets to GPGPU fill
URL : https://patchwork.freedesktop.org/series/119126/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13256 -> IGTPW_9139
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/index.html

Participating hosts (36 -> 36)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in IGTPW_9139 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@requests:
- bat-rpls-1: [PASS][1] -> [ABORT][2] ([i915#4983] / [i915#7911] / [i915#7920])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/bat-rpls-1/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@workarounds:
- bat-rpls-2: [PASS][3] -> [INCOMPLETE][4] ([i915#4983] / [i915#7677] / [i915#7913])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/bat-rpls-2/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/bat-rpls-2/igt@i915_selftest@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@gem_contexts:
- {bat-mtlp-8}: [ABORT][5] -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/bat-mtlp-8/igt@i915_selftest@live@gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/bat-mtlp-8/igt@i915_selftest@live@gem_contexts.html

* igt@i915_selftest@live@slpc:
- {bat-mtlp-6}: [DMESG-WARN][7] ([i915#6367]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/bat-mtlp-6/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/bat-mtlp-6/igt@i915_selftest@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-1:
- fi-cfl-8109u: [ABORT][9] -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/fi-cfl-8109u/igt@kms_pipe_crc_basic@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/fi-cfl-8109u/igt@kms_pipe_crc_basic@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7322 -> IGTPW_9139

CI-20190529: 20190529
CI_DRM_13256: be85dc2d44c075230eec4366e27bc1fe75ee59ff @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9139: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/index.html
IGT_7322: 2dd77d6d827a308caae49ce3eba759c2bab394ed @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/index.html

#5 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] lib: Apply x/y offsets to GPGPU fill

In reply to Christoph Manszewski
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,1/2] lib: Apply x/y offsets to GPGPU fill
URL : https://patchwork.freedesktop.org/series/119126/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13256_full -> IGTPW_9139_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/index.html

Participating hosts (7 -> 7)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in IGTPW_9139_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_barrier_race@remote-request@rcs0:
- shard-glk: [PASS][1] -> [ABORT][2] ([i915#7461] / [i915#8211])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-glk2/igt@gem_barrier_race@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-glk7/igt@gem_barrier_race@[email protected]

* igt@gem_ctx_persistence@processes:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-snb1/igt@[email protected]

* igt@gem_eio@in-flight-contexts-1us:
- shard-apl: [PASS][4] -> [TIMEOUT][5] ([i915#3063])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-apl1/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-apl3/igt@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][6] -> [FAIL][7] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-glk4/igt@gem_exec_fair@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-glk8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: NOTRUN -> [FAIL][8] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-glk5/igt@gem_exec_fair@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-apl: [PASS][9] -> [ABORT][10] ([i915#5566])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-apl6/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-apl3/igt@[email protected]

* igt@i915_module_load@load:
- shard-glk: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#6227])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-glk5/igt@[email protected]

* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#3886])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-glk1/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html

* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#4579]) +19 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-snb4/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][14] ([fdo#109271]) +83 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-snb4/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-upscale-with-rotation-20x20@pipe-c-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#4579]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-glk1/igt@kms_plane_scaling@[email protected]

* igt@kms_vblank@pipe-c-wait-busy-hang:
- shard-apl: [PASS][16] -> [SKIP][17] ([fdo#109271])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-apl1/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-apl6/igt@[email protected]
- shard-glk: [PASS][18] -> [SKIP][19] ([fdo#109271])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-glk7/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-glk8/igt@[email protected]

* igt@kms_vblank@pipe-d-wait-busy-hang:
- shard-glk: NOTRUN -> [SKIP][20] ([fdo#109271]) +35 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-glk2/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][21] ([i915#2842]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-apl1/igt@gem_exec_fair@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-apl2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vecs0:
- {shard-rkl}: [FAIL][23] ([i915#2842]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-rkl-2/igt@gem_exec_fair@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-rkl-2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-tglu}: [FAIL][25] ([i915#2842]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-tglu-6/igt@gem_exec_fair@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-tglu-5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [FAIL][27] ([i915#2842]) -> [PASS][28] +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-glk2/igt@gem_exec_fair@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-glk1/igt@gem_exec_fair@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-glk: [ABORT][29] ([i915#5566]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-glk5/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-glk5/igt@[email protected]

* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][31] ([fdo#109271]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-apl2/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-apl6/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- {shard-rkl}: [SKIP][33] ([i915#1937] / [i915#4579]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-rkl-3/igt@i915_pm_lpsp@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-rkl-7/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_rc6_residency@rc6-fence:
- {shard-tglu}: [WARN][35] ([i915#2681]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-tglu-5/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-tglu-2/igt@[email protected]

* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-dg1}: [SKIP][37] ([i915#1397]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-dg1-16/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-dg1-19/igt@[email protected]

* igt@i915_suspend@basic-s2idle-without-i915:
- {shard-tglu}: [ABORT][39] ([i915#8213]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-tglu-2/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-tglu-5/igt@[email protected]

* igt@kms_async_flips@alternate-sync-async-flip@pipe-a-vga-1:
- shard-snb: [FAIL][41] ([i915#2521]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-snb7/igt@kms_async_flips@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-snb2/igt@kms_async_flips@[email protected]

* igt@kms_async_flips@alternate-sync-async-flip@pipe-b-hdmi-a-1:
- shard-glk: [FAIL][43] ([i915#2521]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-glk7/igt@kms_async_flips@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-glk8/igt@kms_async_flips@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- {shard-dg1}: [FAIL][45] ([i915#3743]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-dg1-19/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-dg1-14/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][47] ([i915#2346]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-glk4/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-glk8/igt@[email protected]
- shard-apl: [FAIL][49] ([i915#2346]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-apl3/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-apl6/igt@[email protected]

* igt@kms_cursor_legacy@forked-bo@pipe-b:
- {shard-rkl}: [INCOMPLETE][51] ([i915#8011]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-rkl-7/igt@kms_cursor_legacy@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-rkl-3/igt@kms_cursor_legacy@[email protected]

* igt@kms_cursor_legacy@single-bo@pipe-b:
- {shard-dg1}: [INCOMPLETE][53] ([i915#8011] / [i915#8347]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-dg1-19/igt@kms_cursor_legacy@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-dg1-14/igt@kms_cursor_legacy@[email protected]

* igt@perf_pmu@busy-double-start@vecs0:
- {shard-dg1}: [FAIL][55] ([i915#4349]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-dg1-13/igt@perf_pmu@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-dg1-13/igt@perf_pmu@[email protected]

* igt@perf_pmu@busy-idle-check-all@vecs0:
- {shard-dg1}: [FAIL][57] ([i915#4521]) -> [PASS][58] +2 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-dg1-17/igt@perf_pmu@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-dg1-17/igt@perf_pmu@[email protected]

* igt@perf_pmu@most-busy-idle-check-all@rcs0:
- {shard-dg1}: [FAIL][59] ([i915#5234]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-dg1-15/igt@perf_pmu@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-dg1-13/igt@perf_pmu@[email protected]

#### Warnings ####

* igt@i915_pm_rps@reset:
- shard-snb: [INCOMPLETE][61] ([i915#7790]) -> [DMESG-FAIL][62] ([i915#8319])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13256/shard-snb6/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/shard-snb6/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2876]: https://gitlab.freedesktop.org/drm/intel/issues/2876
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4521]: https://gitlab.freedesktop.org/drm/intel/issues/4521
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#5099]: https://gitlab.freedesktop.org/drm/intel/issues/5099
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5234]: https://gitlab.freedesktop.org/drm/intel/issues/5234
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8319]: https://gitlab.freedesktop.org/drm/intel/issues/8319
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7322 -> IGTPW_9139
* Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_13256: be85dc2d44c075230eec4366e27bc1fe75ee59ff @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9139: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/index.html
IGT_7322: 2dd77d6d827a308caae49ce3eba759c2bab394ed @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9139/index.html

Reviewed-by on v1 1/2
#6 lore raw
In reply to Christoph Manszewski
Quoted 6 lines · Christoph Manszewski

Actually honour the caller provided destination region and pass the x/y offsets to the thread group.

Aligns behaviour with interface author inntention. From me it is:

However, when this is finally working, could we utilize it in gem_gpgpu_fill/xe_gpgpu_fill? :)

Quoted 131 lines
---
 lib/gpgpu_fill.c |  4 +---
 lib/gpu_cmds.c   | 29 +++++++++++++++--------------
 lib/gpu_cmds.h   |  1 +
 3 files changed, 17 insertions(+), 17 deletions(-)
lib/gpgpu_fill.c +1 -3
index d854fbf7..eed82187 100644
@@ -315,8 +315,6 @@ __xehp_gpgpu_fillfunc(int i915,
 {
 	struct intel_bb *ibb;
 	struct xehp_interface_descriptor_data idd;
-	(void) x;
-	(void) y;
 
 	ibb = intel_bb_create(i915, PAGE_SIZE);
 	intel_bb_add_intel_buf(ibb, buf, true);
@@ -335,7 +333,7 @@ __xehp_gpgpu_fillfunc(int i915,
 	xehp_emit_state_compute_mode(ibb);
 	xehp_emit_state_binding_table_pool_alloc(ibb);
 	xehp_emit_cfe_state(ibb, THREADS);
-	xehp_emit_compute_walk(ibb, width, height, &idd, color);
+	xehp_emit_compute_walk(ibb, x, y, width, height, &idd, color);
 
 	intel_bb_out(ibb, MI_BATCH_BUFFER_END);
 	intel_bb_ptr_align(ibb, 32);
lib/gpu_cmds.c +15 -14
index 1f321ae4..aecba928 100644
@@ -636,10 +636,10 @@ gen7_emit_gpgpu_walk(struct intel_bb *ibb,
 	 * Then thread group X = width / 16 (aligned to 16)
 	 * thread group Y = height;
 	 */
-	x_dim = (width + 15) / 16;
-	y_dim = height;
+	x_dim = (x + width + 15) / 16;
+	y_dim = y + height;
 
-	tmp = width & 15;
+	tmp = (x + width) & 15;
 	if (tmp == 0)
 		right_mask = (1 << 16) - 1;
 	else
@@ -657,11 +657,11 @@ gen7_emit_gpgpu_walk(struct intel_bb *ibb,
 		  0); /* width:1 */
 
 	/* thread group X */
-	intel_bb_out(ibb, 0);
+	intel_bb_out(ibb, x / 16);
 	intel_bb_out(ibb, x_dim);
 
 	/* thread group Y */
-	intel_bb_out(ibb, 0);
+	intel_bb_out(ibb, y);
 	intel_bb_out(ibb, y_dim);
 
 	/* thread group Z */
@@ -693,10 +693,10 @@ gen8_emit_gpgpu_walk(struct intel_bb *ibb,
 	 * Then thread group X = width / 16 (aligned to 16)
 	 * thread group Y = height;
 	 */
-	x_dim = (width + 15) / 16;
-	y_dim = height;
+	x_dim = (x + width + 15) / 16;
+	y_dim = y + height;
 
-	tmp = width & 15;
+	tmp = (x + width) & 15;
 	if (tmp == 0)
 		right_mask = (1 << 16) - 1;
 	else
@@ -715,12 +715,12 @@ gen8_emit_gpgpu_walk(struct intel_bb *ibb,
 		     0); /* width:1 */
 
 	/* thread group X */
-	intel_bb_out(ibb, 0);
+	intel_bb_out(ibb, x / 16);
 	intel_bb_out(ibb, 0);
 	intel_bb_out(ibb, x_dim);
 
 	/* thread group Y */
-	intel_bb_out(ibb, 0);
+	intel_bb_out(ibb, y);
 	intel_bb_out(ibb, 0);
 	intel_bb_out(ibb, y_dim);
 
@@ -948,6 +948,7 @@ xehp_emit_state_base_address(struct intel_bb *ibb)
 
 void
 xehp_emit_compute_walk(struct intel_bb *ibb,
+		       unsigned int x, unsigned int y,
 		       unsigned int width, unsigned int height,
 		       struct xehp_interface_descriptor_data *pidd,
 		       uint8_t color)
@@ -965,8 +966,8 @@ xehp_emit_compute_walk(struct intel_bb *ibb,
 	 * Then thread group X = width / 16 (aligned to 16)
 	 * thread group Y = height;
 	 */
-	x_dim = (width + 15) / 16;
-	y_dim = height;
+	x_dim = (x + width + 15) / 16;
+	y_dim = y + height;
 
 	intel_bb_out(ibb, XEHP_COMPUTE_WALKER | 0x25);
 
@@ -994,8 +995,8 @@ xehp_emit_compute_walk(struct intel_bb *ibb,
 	intel_bb_out(ibb, 1);					//dw9
 
 	/* group id x/y/z */
-	intel_bb_out(ibb, 0);					//dw10
-	intel_bb_out(ibb, 0);					//dw11
+	intel_bb_out(ibb, x / 16);				//dw10
+	intel_bb_out(ibb, y);					//dw11
 	intel_bb_out(ibb, 0);					//dw12
 
 	/* partition id / partition size */
lib/gpu_cmds.h +1 -0
index 92cbbde9..b7ed64f8 100644
@@ -138,6 +138,7 @@ xehp_emit_state_base_address(struct intel_bb *ibb);
 
 void
 xehp_emit_compute_walk(struct intel_bb *ibb,
+		       unsigned int x, unsigned int y,
 		       unsigned int width, unsigned int height,
 		       struct xehp_interface_descriptor_data *pidd,
 		       uint8_t color);