Skip to contentSkip to conversation

powerpc: fsl_soc: Use of_range_to_resource() for "ranges" parsing

PATCH Applied Rob Herring 2 participants 2 messages Jun 9, 2023 – Jul 3, 2023 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: fsl_soc: Use of_range_to_resource() for "ranges" parsing

"ranges" is a standard property with common parsing functions. Users shouldn't be implementing their own parsing of it. Refactor the FSL RapidIO "ranges" parsing to use of_range_to_resource() instead.

---
 arch/powerpc/sysdev/fsl_soc.c | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)
arch/powerpc/sysdev/fsl_soc.c +4 -12
index 6ebbbca41065..68709743450e 100644
@@ -51,18 +51,10 @@ phys_addr_t get_immrbase(void)
 
 	soc = of_find_node_by_type(NULL, "soc");
 	if (soc) {
-		int size;
-		u32 naddr;
-		const __be32 *prop = of_get_property(soc, "#address-cells", &size);
-
-		if (prop && size == 4)
-			naddr = be32_to_cpup(prop);
-		else
-			naddr = 2;
-
-		prop = of_get_property(soc, "ranges", &size);
-		if (prop)
-			immrbase = of_translate_address(soc, prop + naddr);
+		struct resource res;
+
+		if (!of_range_to_resource(soc, 0, &res))
+			immrbase = res.start;
 
 		of_node_put(soc);
 	}
Signature · 1 line
2.39.2