Skip to contentSkip to conversation

mm-compaction-add-trace-event-for-fast-freepages-isolation.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Jun 9, 2023

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm: compaction: add trace event for fast freepages isolation
has been removed from the -mm tree. Its filename was
mm-compaction-add-trace-event-for-fast-freepages-isolation.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Baolin Wang <[email protected]>
Subject: mm: compaction: add trace event for fast freepages isolation
Date: Thu, 25 May 2023 20:54:00 +0800

The fast_isolate_freepages() can also isolate freepages, but we can not know the fast isolation efficiency to understand the fast isolation pressure. So add a trace event to show some numbers to help to understand the efficiency for fast freepages isolation.

---

 include/trace/events/compaction.h |   11 +++++++++++
 mm/compaction.c                   |    6 +++++-
 2 files changed, 16 insertions(+), 1 deletion(-)
include/trace/events/compaction.h renamed from include/trace/events/compaction.h~mm-compaction-add-trace-event-for-fast-freepages-isolation +11 -0
@@ -64,6 +64,17 @@ DEFINE_EVENT(mm_compaction_isolate_templ
 	TP_ARGS(start_pfn, end_pfn, nr_scanned, nr_taken)
 );
 
+DEFINE_EVENT(mm_compaction_isolate_template, mm_compaction_fast_isolate_freepages,
+
+	TP_PROTO(
+		unsigned long start_pfn,
+		unsigned long end_pfn,
+		unsigned long nr_scanned,
+		unsigned long nr_taken),
+
+	TP_ARGS(start_pfn, end_pfn, nr_scanned, nr_taken)
+);
+
 #ifdef CONFIG_COMPACTION
 TRACE_EVENT(mm_compaction_migratepages,
 
mm/compaction.c renamed from mm/compaction.c~mm-compaction-add-trace-event-for-fast-freepages-isolation +5 -1
@@ -1416,7 +1416,7 @@ static int next_search_order(struct comp
 static void fast_isolate_freepages(struct compact_control *cc)
 {
 	unsigned int limit = max(1U, freelist_scan_limit(cc) >> 1);
-	unsigned int nr_scanned = 0;
+	unsigned int nr_scanned = 0, total_isolated = 0;
 	unsigned long low_pfn, min_pfn, highest = 0;
 	unsigned long nr_isolated = 0;
 	unsigned long distance;
@@ -1515,6 +1515,7 @@ static void fast_isolate_freepages(struc
 				set_page_private(page, order);
 				nr_isolated = 1 << order;
 				nr_scanned += nr_isolated - 1;
+				total_isolated += nr_isolated;
 				cc->nr_freepages += nr_isolated;
 				list_add_tail(&page->lru, &cc->freepages);
 				count_compact_events(COMPACTISOLATED, nr_isolated);
@@ -1535,6 +1536,9 @@ static void fast_isolate_freepages(struc
 			limit = max(1U, limit >> 1);
 	}
 
+	trace_mm_compaction_fast_isolate_freepages(min_pfn, cc->free_pfn,
+						   nr_scanned, total_isolated);
+
 	if (!page) {
 		cc->fast_search_fail++;
 		if (scan_start) {

_

Patches currently in -mm which might be from [email protected] are