Skip to contentSkip to conversation

Documentation/hwmon: Fix description of devm_hwmon_device_unregister()

PATCH Applied Yongsheng Yang 3 participants 4 messages Jun 9, 2023 – Jun 12, 2023

Subsystems (2)

v2 of 3 Applied Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Documentation/hwmon: Fix description of devm_hwmon_device_unregister()

Use devm_hwmon_device_register_with_info to replace hwmon_device_register_with_info in description of devm_hwmon_device_unregister.

---
 Documentation/hwmon/hwmon-kernel-api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/hwmon/hwmon-kernel-api.rst +1 -1
index c2d1e0299d8d..6cacf7daf25c 100644
@@ -66,7 +66,7 @@ hwmon_device_register_with_info.
 
 devm_hwmon_device_unregister does not normally have to be called. It is only
 needed for error handling, and only needed if the driver probe fails after
-the call to hwmon_device_register_with_info and if the automatic (device
+the call to devm_hwmon_device_register_with_info and if the automatic (device
 managed) removal would be too late.
 
 All supported hwmon device registration functions only accept valid device
Signature · 1 line
2.37.1
Reviewed-by on v2 1/1
#1 lore raw

Documentation/hwmon/hwmon-kernel-api.rst hwmon_device_register_with_info. · line 72

Quoted 13 lines · Yongsheng Yang
Documentation/hwmon/hwmon-kernel-api.rst +1 -1
index c2d1e0299d8d..6cacf7daf25c 100644
@@ -66,7 +66,7 @@ hwmon_device_register_with_info.
 
 devm_hwmon_device_unregister does not normally have to be called. It is only
 needed for error handling, and only needed if the driver probe fails after
-the call to hwmon_device_register_with_info and if the automatic (device
+the call to devm_hwmon_device_register_with_info and if the automatic (device
 managed) removal would be too late.
 
 All supported hwmon device registration functions only accept valid device

LGTM, thanks!

Signature · 1 line
An old man doll... just what I always wanted! - Clara
maintainer Applied
#2 lore raw
In reply to Yongsheng Yang
Quoted 4 lines · Yongsheng Yang

Use devm_hwmon_device_register_with_info to replace hwmon_device_register_with_info in description of devm_hwmon_device_unregister.

You didn't add () to function names, but I guess it is better to do that in a separate patch anyway.

Applied.

Thanks,
Guenter

Quoted 19 lines
---
 Documentation/hwmon/hwmon-kernel-api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/hwmon/hwmon-kernel-api.rst +1 -1
index c2d1e0299d8d..6cacf7daf25c 100644
@@ -66,7 +66,7 @@ hwmon_device_register_with_info.
 
 devm_hwmon_device_unregister does not normally have to be called. It is only
 needed for error handling, and only needed if the driver probe fails after
-the call to hwmon_device_register_with_info and if the automatic (device
+the call to devm_hwmon_device_register_with_info and if the automatic (device
 managed) removal would be too late.
 
 All supported hwmon device registration functions only accept valid device
#3 lore raw
Quoted 6 lines · Yongsheng Yang
Quoted 4 lines

Use devm_hwmon_device_register_with_info to replace hwmon_device_register_with_info in description of devm_hwmon_device_unregister.

Quoted 8 lines

You didn't add () to function names, but I guess it is better to do that in a separate patch anyway.

Applied.

Thanks,
Guenter

Ok, I just add () to function names in commit message title. I will add () to function names releate in the whole commit message. Then I will post the updated version.

Thanks

Yongsheng

Quoted 19 lines
Quoted 19 lines
---
 Documentation/hwmon/hwmon-kernel-api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/hwmon/hwmon-kernel-api.rst +1 -1
index c2d1e0299d8d..6cacf7daf25c 100644
@@ -66,7 +66,7 @@ hwmon_device_register_with_info.
 
 devm_hwmon_device_unregister does not normally have to be called. It is only
 needed for error handling, and only needed if the driver probe fails after
-the call to hwmon_device_register_with_info and if the automatic (device
+the call to devm_hwmon_device_register_with_info and if the automatic (device
 managed) removal would be too late.
 
 All supported hwmon device registration functions only accept valid device