Skip to contentSkip to conversation

target/tricore: Fix out-of-bounds index in imask instruction

PATCH In review Siqi Chen 2 participants 2 messages Jun 12, 2023

lore
Share & tools
lore

Siqi Chen

author
#0 lore raw

PATCH 1/1 target/tricore: Fix out-of-bounds index in imask instruction

When translating "imask" instruction of Tricore architecture, QEMU did not check whether the register index was out of bounds, resulting in a global-buffer-overflow.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1698

---
 target/tricore/translate.c | 1 +
 1 file changed, 1 insertion(+)
target/tricore/translate.c +1 -0
index cd33a1dcdd..3b8d3f53ee 100644
@@ -5331,6 +5331,7 @@ static void decode_rcrw_insert(DisasContext *ctx)
 
     switch (op2) {
     case OPC2_32_RCRW_IMASK:
+        CHECK_REG_PAIR(r4);
         tcg_gen_andi_tl(temp, cpu_gpr_d[r3], 0x1f);
         tcg_gen_movi_tl(temp2, (1 << width) - 1);
         tcg_gen_shl_tl(cpu_gpr_d[r4 + 1], temp2, temp);
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Siqi Chen

When translating "imask" instruction of Tricore architecture, QEMU did not check whether the register index was out of bounds, resulting in a global-buffer-overflow.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1698

---
 target/tricore/translate.c | 1 +
 1 file changed, 1 insertion(+)

Cheers,
Bastian