Revert "drm/amd/display: fix dpms_off issue when disabling bios mode"
Subsystems (3)
Alex Deucher
maintainerPATCH 1/1 Revert "drm/amd/display: fix dpms_off issue when disabling bios mode"
This reverts commit 58e67bb3c131da5ee14e4842b08e53f4888dce0a.
This patch was reverted, but came back again as
commit 58e67bb3c131 ("drm/amd/display: fix dpms_off issue when disabling bios mode") Revert it again as it breaks Asus G513QY / 6800M laptops.
--- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/core/dc.c +1 -1
@@ -1296,7 +1296,7 @@ static void disable_vbios_mode_if_required(if (pix_clk_100hz != requested_pix_clk_100hz) { dc->link_srv->set_dpms_off (pipe); - pipe->stream->dpms_off = true; + pipe->stream->dpms_off = false; } } }
Signature · 1 line
2.40.1
Quoted 6 lines · Alex Deucher
This reverts commit
58e67bb3c131da5ee14e4842b08e53f4888dce0a.This patch was reverted, but came back again as
commit58e67bb3c131("drm/amd/display: fixdpms_offissue when disabling bios mode") Revert it again as it breaks Asus G513QY / 6800M laptops.
Quoted 6 lines
Cc Rodrigo Siqueira <[email protected]>Cc Zhongwei <[email protected]>Cc Harry Wentland <[email protected]>Cc Mike Lothian <[email protected]>Signed-off-by Alex Deucher <[email protected]>
Harry
Quoted 17 lines
--- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/dc/core/dc.c +1
-1@@ -1296,7 +1296,7 @@ static void disable_vbios_mode_if_required(if (pix_clk_100hz != requested_pix_clk_100hz) { dc->link_srv->set_dpms_off (pipe); - pipe->stream->dpms_off = true; + pipe->stream->dpms_off = false; } } }
Thanks
I'm happy to help debug this further
Quoted 37 lines · Harry Wentland
Quoted 6 lines · Alex Deucher
This reverts commit
58e67bb3c131da5ee14e4842b08e53f4888dce0a.This patch was reverted, but came back again as
commit58e67bb3c131("drm/amd/display: fixdpms_offissue when disabling bios mode") Revert it again as it breaks Asus G513QY / 6800M laptops.Quoted 6 lines
Cc Rodrigo Siqueira <[email protected]>Cc Zhongwei <[email protected]>Cc Harry Wentland <[email protected]>Cc Mike Lothian <[email protected]>Signed-off-by Alex Deucher <[email protected]>Reviewed-by Harry Wentland <[email protected]>Harry
Quoted 17 lines
--- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/dc/core/dc.c +1
-1@@ -1296,7 +1296,7 @@ static void disable_vbios_mode_if_required(if (pix_clk_100hz != requested_pix_clk_100hz) { dc->link_srv->set_dpms_off (pipe); - pipe->stream->dpms_off = true; + pipe->stream->dpms_off = false; } } }