Skip to contentSkip to conversation

dbusmock: only recommend python3-pygobject

PATCH Superseded [email protected] 2 participants 2 messages Jun 12, 2023 – Jun 13, 2023

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dbusmock: only recommend python3-pygobject

From: Ross Burton <[email protected]>

dbusmock doesn't actually hard-depend on pygobject, some of the templates use it but it isn't mandatory.

Change the RDEPENDS to RRECOMMENDS, and only recommend if g-i is enabled.

---
 meta/recipes-devtools/python/python3-dbusmock_0.29.0.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-devtools/python/python3-dbusmock_0.29.0.bb +2 -1
index 32a43e00b99..0c6db336892 100644
@@ -13,9 +13,10 @@ DEPENDS += "python3-setuptools-scm-native"
 
 RDEPENDS:${PN} += "\
     ${PYTHON_PN}-dbus \
-    ${PYTHON_PN}-pygobject \
     ${PYTHON_PN}-unittest \
     ${PYTHON_PN}-xml \
     "
 
+RRECOMMENDS:${PN} = "${@bb.utils.contains('DISTRO_FEATURES', 'gobject-introspection-data', '${PYTHON_PN}-pygobject', '', d)}"
+
 BBCLASSEXTEND = "native"
Signature · 1 line
2.34.1
#1 lore raw

This caused:

WARNING: lib32-python3-dbusmock-0.29.0-r0 do_package: QA Issue: lib32-python3-dbusmock package lib32-python3-dbusmock - suspicious values 'python3-pygobject' in RRECOMMENDS

https://autobuilder.yoctoproject.org/typhoon/#/builders/108/builds/4650/steps/12/logs/warnings
https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/7176/steps/11/logs/warnings

Quoted 41 lines · Ross Burton

From: Ross Burton <[email protected]>

dbusmock doesn't actually hard-depend on pygobject, some of the templates use it but it isn't mandatory.

Change the RDEPENDS to RRECOMMENDS, and only recommend if g-i is enabled.

---
 meta/recipes-devtools/python/python3-dbusmock_0.29.0.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-devtools/python/python3-dbusmock_0.29.0.bb +2 -1
index 32a43e00b99..0c6db336892 100644
@@ -13,9 +13,10 @@ DEPENDS += "python3-setuptools-scm-native"
 
 RDEPENDS:${PN} += "\
     ${PYTHON_PN}-dbus \
-    ${PYTHON_PN}-pygobject \
     ${PYTHON_PN}-unittest \
     ${PYTHON_PN}-xml \
     "
 
+RRECOMMENDS:${PN} = "${@bb.utils.contains('DISTRO_FEATURES', 'gobject-introspection-data', '${PYTHON_PN}-pygobject', '', d)}"
+
 BBCLASSEXTEND = "native"
Signature · 11 lines
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#182678): https://lists.openembedded.org/g/openembedded-core/message/182678
Mute This Topic: https://lists.openembedded.org/mt/99486101/3617179
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com