ASoC: tlv320aic32x4: pll: Remove impossible condition in clk_aic32x4_pll_determine_rate()
Subsystems (4)
Stephen Boyd
maintainerPATCH 1/1 ASoC: tlv320aic32x4: pll: Remove impossible condition in clk_aic32x4_pll_determine_rate()
Smatch warns:
sound/soc/codecs/tlv320aic32x4-clk.c:219 clk_aic32x4_pll_determine_rate() warn: unsigned 'rate' is never less than zero.
Cc Maxime Ripard <[email protected]>
Reported-by kernel test robot <[email protected]>
Fixes 25d43ec352ea ("ASoC: tlv320aic32x4: pll: Switch to determine_rate")
Signed-off-by Stephen Boyd <[email protected]>
--- sound/soc/codecs/tlv320aic32x4-clk.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
sound/soc/codecs/tlv320aic32x4-clk.c +1 -5
@@ -208,18 +208,14 @@ static int clk_aic32x4_pll_determine_rate(struct clk_hw *hw, struct clk_rate_request *req) {struct clk_aic32x4_pll_muldiv settings; -unsigned long rate;int ret; ret =clk_aic32x4_pll_calc_muldiv (&settings, req->rate, req->best_parent_rate);if (ret <0 )return -EINVAL ; - rate =clk_aic32x4_pll_calc_rate (&settings, req->best_parent_rate); -if (rate <0 ) -return rate; + req->rate =clk_aic32x4_pll_calc_rate (&settings, req->best_parent_rate); - req->rate = rate;return 0 ; }
Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/ https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
Quoted 9 lines · Stephen Boyd
Smatch warns:
sound/soc/codecs/tlv320aic32x4-clk.c:219clk_aic32x4_pll_determine_rate()warn: unsigned 'rate' is never less than zero.Cc Maxime Ripard <[email protected]>Reported-by kernel test robot <[email protected]>Fixes 25d43ec352ea ("ASoC: tlv320aic32x4: pll: Switch to determine_rate")Signed-off-by Stephen Boyd <[email protected]>
Thanks for taking care of this
Reviewed-by Maxime Ripard <[email protected]>
Maxime
Quoting Stephen Boyd (2023-06-12 18:12:00)
Quoted 10 lines
Smatch warns:
sound/soc/codecs/tlv320aic32x4-clk.c:219clk_aic32x4_pll_determine_rate()warn: unsigned 'rate' is never less than zero.Cc Maxime Ripard <[email protected]>Reported-by kernel test robot <[email protected]>Fixes 25d43ec352ea ("ASoC: tlv320aic32x4: pll: Switch to determine_rate")Signed-off-by Stephen Boyd <[email protected]>---
Applied to clk-next