Skip to contentSkip to conversation

cgroup/misc: Expose misc.current on cgroup v2 root

PATCH Applied LeiZhou-97 2 participants 2 messages Jun 13, 2023 – Jun 21, 2023

Subsystems (2)
lore
Share & tools
lore

LeiZhou-97

author
#0 lore raw

PATCH 1/1 cgroup/misc: Expose misc.current on cgroup v2 root

Hello,

This patch is to expose misc.current on cgroup v2 root for tracking how much of the resource has been consumed in total on the system.

Most of the cloud infrastucture use cgroup to fetch the host information for scheduling purpose.

Currently, the misc controller can be used by Intel TDX HKIDs and AMD SEV ASIDs, which are both used for creating encrypted VMs. Intel TDX and AMD SEV are mostly be used by the cloud providers for providing confidential VMs.

In actual use of a server, these confidential VMs may be launched in different ways. For the cloud solution, there are kubvirt and coco (tracked by kubepods.slice); on host, they can be booted directly through qemu by end user (tracked by user.slice), etc.

In this complex environment, when wanting to know how many resource is used in total it has to iterate through all existing slices to get the value of each misc.current and add them up to calculate the total number of consumed keys.

So exposing misc.current to root cgroup tends to give much easier when calculates how much resource has been used in total, which helps to schedule and count resources for the cloud infrastucture.

---
 Documentation/admin-guide/cgroup-v2.rst | 2 +-
 kernel/cgroup/misc.c                    | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
Documentation/admin-guide/cgroup-v2.rst +1 -1
index f67c0829350b..d9f3768a10db 100644
@@ -2439,7 +2439,7 @@ Miscellaneous controller provides 3 interface files. If two misc resources (res_
 	  res_b 10
 
   misc.current
-        A read-only flat-keyed file shown in the non-root cgroups.  It shows
+        A read-only flat-keyed file shown in the all cgroups.  It shows
         the current usage of the resources in the cgroup and its children.::
 
 	  $ cat misc.current
kernel/cgroup/misc.c +0 -1
index fe3e8a0eb7ed..ae2f4dd47508 100644
@@ -357,7 +357,6 @@ static struct cftype misc_cg_files[] = {
 	{
 		.name = "current",
 		.seq_show = misc_cg_current_show,
-		.flags = CFTYPE_NOT_ON_ROOT,
 	},
 	{
 		.name = "capacity",
Signature · 1 line
2.40.1
maintainer Applied
#1 lore raw
Quoted 23 lines · On Tue, Jun 13, 2023 at 06:59:29PM +0800, LeiZhou-97 wrote:

Hello,

This patch is to expose misc.current on cgroup v2 root for tracking how much of the resource has been consumed in total on the system.

Most of the cloud infrastucture use cgroup to fetch the host information for scheduling purpose.

Currently, the misc controller can be used by Intel TDX HKIDs and AMD SEV ASIDs, which are both used for creating encrypted VMs. Intel TDX and AMD SEV are mostly be used by the cloud providers for providing confidential VMs.

In actual use of a server, these confidential VMs may be launched in different ways. For the cloud solution, there are kubvirt and coco (tracked by kubepods.slice); on host, they can be booted directly through qemu by end user (tracked by user.slice), etc.

In this complex environment, when wanting to know how many resource is used in total it has to iterate through all existing slices to get the value of each misc.current and add them up to calculate the total number of consumed keys.

Quoted 5 lines

So exposing misc.current to root cgroup tends to give much easier when calculates how much resource has been used in total, which helps to schedule and count resources for the cloud infrastucture.

Applied to cgroup/for-6.5.

Thanks.

Signature · 1 line
tejun