Skip to contentSkip to conversation

media: staging: atomisp: select V4L2_FWNODE

PATCH In review Sakari Ailus 3 participants 4 messages Jun 13, 2023

Subsystems (4)
lore
Share & tools
lore

Sakari Ailus

author reviewer
#0 lore raw

PATCH 1/1 media: staging: atomisp: select V4L2_FWNODE

Select V4L2_FWNODE as the driver depends on it.

Fixes aa31f6514047 ("media: atomisp: allow building the driver again")
---
 drivers/staging/media/atomisp/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/media/atomisp/Kconfig +1 -0
index c9bff98e5309a..e9b168ba97bf1 100644
@@ -13,6 +13,7 @@ config VIDEO_ATOMISP
 	tristate "Intel Atom Image Signal Processor Driver"
 	depends on VIDEO_DEV && INTEL_ATOMISP
 	depends on PMIC_OPREGION
+	select V4L2_FWNODE
 	select IOSF_MBI
 	select VIDEOBUF2_VMALLOC
 	select VIDEO_V4L2_SUBDEV_API
Signature · 1 line
2.30.2
Tested-by on v1 1/1
#1 lore raw
Quoted 1 line · Sakari Ailus

Select V4L2_FWNODE as the driver depends on it.

Quoted 1 line

I believe this should be @linux.intel.com, but it doesn't matter.

Quoted 21 lines
Fixes aa31f6514047 ("media: atomisp: allow building the driver again")
---
 drivers/staging/media/atomisp/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/media/atomisp/Kconfig +1 -0
index c9bff98e5309a..e9b168ba97bf1 100644
@@ -13,6 +13,7 @@ config VIDEO_ATOMISP
 	tristate "Intel Atom Image Signal Processor Driver"
 	depends on VIDEO_DEV && INTEL_ATOMISP
 	depends on PMIC_OPREGION
+	select V4L2_FWNODE
 	select IOSF_MBI
 	select VIDEOBUF2_VMALLOC
 	select VIDEO_V4L2_SUBDEV_API
Signature · 1 line
2.30.2
Signature · 2 lines
With Best Regards,
Andy Shevchenko
author reviewer
#2 lore raw

Hi Andy,

Quoted 8 lines · Andy Shevchenko
Quoted 1 line · Sakari Ailus

Select V4L2_FWNODE as the driver depends on it.

Quoted 1 line

I believe this should be @linux.intel.com, but it doesn't matter.

I can change that before sending the PR. You used you @intel.com e-mail for sending it, just FYI.

Signature · 3 lines
Kind regards,

Sakari Ailus
Reviewed-by on v1 1/1
#3 lore raw
In reply to Sakari Ailus

Hi,

Quoted 5 lines · Sakari Ailus

Select V4L2_FWNODE as the driver depends on it.

Fixes aa31f6514047 ("media: atomisp: allow building the driver again")

Thanks, patch looks good to me:

Mauro this is a build fix for the recent atomisp pull-req for 6.5, can you merge this please.

Regards,

Hans

Quoted 16 lines
---
 drivers/staging/media/atomisp/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/media/atomisp/Kconfig +1 -0
index c9bff98e5309a..e9b168ba97bf1 100644
@@ -13,6 +13,7 @@ config VIDEO_ATOMISP
 	tristate "Intel Atom Image Signal Processor Driver"
 	depends on VIDEO_DEV && INTEL_ATOMISP
 	depends on PMIC_OPREGION
+	select V4L2_FWNODE
 	select IOSF_MBI
 	select VIDEOBUF2_VMALLOC
 	select VIDEO_V4L2_SUBDEV_API