Skip to contentSkip to conversation

scsi: ufs: ufs-pci: Add support for Intel Arrow Lake

PATCH Applied Adrian Hunter 3 participants 6 messages Jun 13, 2023 – Jun 22, 2023 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: ufs: ufs-pci: Add support for Intel Arrow Lake

Add PCI ID to support Intel Arrow Lake, same as MTL.

---
 drivers/ufs/host/ufshcd-pci.c | 1 +
 1 file changed, 1 insertion(+)
drivers/ufs/host/ufshcd-pci.c +1 -0
index 38276dac8e52..cf3987773051 100644
@@ -599,6 +599,7 @@ static const struct pci_device_id ufshcd_pci_tbl[] = {
 	{ PCI_VDEVICE(INTEL, 0x54FF), (kernel_ulong_t)&ufs_intel_adl_hba_vops },
 	{ PCI_VDEVICE(INTEL, 0x7E47), (kernel_ulong_t)&ufs_intel_mtl_hba_vops },
 	{ PCI_VDEVICE(INTEL, 0xA847), (kernel_ulong_t)&ufs_intel_mtl_hba_vops },
+	{ PCI_VDEVICE(INTEL, 0x7747), (kernel_ulong_t)&ufs_intel_mtl_hba_vops },
 	{ }	/* terminate list */
 };
 
Signature · 1 line
2.34.1
#1 lore raw
Quoted 1 line · Adrian Hunter

Add PCI ID to support Intel Arrow Lake, same as MTL.

The patch looks good to me but the "same as MTL" text in the patch description looks confusing to me?

Thanks,

Bart.

author Reviewed-by Avri Altman Reviewed-by Bart Van Assche
#2 lore raw
Quoted 4 lines · Bart Van Assche
Quoted 1 line · Adrian Hunter

Add PCI ID to support Intel Arrow Lake, same as MTL.

The patch looks good to me but the "same as MTL" text in the patch description looks confusing to me?

The code change is using the same driver data as MTL:

drivers/ufs/host/ufshcd-pci.c +1 -0
index 38276dac8e52..cf3987773051 100644
@@ -599,6 +599,7 @@ static const struct pci_device_id ufshcd_pci_tbl[] = {
 	{ PCI_VDEVICE(INTEL, 0x54FF), (kernel_ulong_t)&ufs_intel_adl_hba_vops },
 	{ PCI_VDEVICE(INTEL, 0x7E47), (kernel_ulong_t)&ufs_intel_mtl_hba_vops },
 	{ PCI_VDEVICE(INTEL, 0xA847), (kernel_ulong_t)&ufs_intel_mtl_hba_vops },
+	{ PCI_VDEVICE(INTEL, 0x7747), (kernel_ulong_t)&ufs_intel_mtl_hba_vops },	<--- here
 	{ }	/* terminate list */
 };
 

MTL is Meteor Lake. The abbreviation is not unheard of in commit messages. A web search for Intel MTL brings up the answer.

And there is this earlier patch to the same code:

commit 4049f7acef3eb37c1ea0df45f3ffc29404f4e708

Author: Adrian Hunter <[email protected]>
Date:   Mon Apr 4 08:50:38 2022 +0300

scsi: ufs: ufs-pci: Add support for Intel MTL

Add PCI ID and callbacks to support Intel Meteor Lake (MTL).

Reviewed-by
#3 lore raw
Quoted 7 lines · Adrian Hunter
Quoted 4 lines · Bart Van Assche
Quoted 1 line · Adrian Hunter

Add PCI ID to support Intel Arrow Lake, same as MTL.

The patch looks good to me but the "same as MTL" text in the patch description looks confusing to me?

The code change is using the same driver data as MTL: [ ... ]

Information about whether only the MTL code is reused or whether the UFS controller is identical to the MTL UFS controller would be welcome. Anyway, feel free to add: