Skip to contentSkip to conversation

time: clocksource-wdtest: Remove unnecessary initialization of variable 'ret'

PATCH In review Li zeming 2 participants 2 messages Jun 12, 2023 Timekeeping, clocksource core, NTP, alarmtimer

lore
Share & tools
lore

Li zeming

author
#0 lore raw

PATCH 1/1 time: clocksource-wdtest: Remove unnecessary initialization of variable 'ret'

ret is assigned first, so it does not need to initialize the assignment.

---
 kernel/time/clocksource-wdtest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/time/clocksource-wdtest.c +1 -1
index df922f49d171..bf89700aa9bf 100644
@@ -181,7 +181,7 @@ static void clocksource_wdtest_cleanup(void)
 
 static int __init clocksource_wdtest_init(void)
 {
-	int ret = 0;
+	int ret;
 
 	wdtest_print_module_parms();
 
Signature · 1 line
2.18.2
#1 lore raw

Li!

On Wed, Jun 14 2023 at 03:35, Li zeming wrote:

Can you please pick the proper prefixes and not create random ones.

https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-subject

Quoted 2 lines

ret is assigned first, so it does not need to initialize the assignment.

This sentence does not make sense. You cannot initialize an assignment. What you want to say is something like this.

'ret' is always assigned before being checked, so initializing the variable is not required.

No?

Thanks,

tglx