Skip to contentSkip to conversation

Remove power-domains property for devices with compatible ti,am62-sa3ul

PATCH Superseded Kamlesh Gurudasani 1 participant 3 messages Jun 20, 2023

Subsystems (3)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v4 cover Remove power-domains property for devices with compatible ti,am62-sa3ul

SYSFW don't allow access to power of devices with compatible ti,am62-sa3ul from main domain.

Power-domains property, if present will try to access the power of the device, which will result into failure in probing of driver for that device.

Make power-domains property as false for devices with compatible ti,am62-sa3ul.

---
Changes in v4:
- s/items/contains/ for dt-binding patch
- Added "fixes commit" for dt-binding patch
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Add patch dt-bindings: crypto: ti,sa2ul: make power-domains conditional
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Make commit message clearer

---
Kamlesh Gurudasani (2):
dt-bindings: crypto: ti,sa2ul: make power-domains conditional
arm64: dts: ti: k3-am62-main: Remove power-domains from crypto node

 Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 +++++++++++++-
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi               |  1 -
 2 files changed, 13 insertions(+), 2 deletions(-)

---
base-commit: 53ab6975c12d1ad86c599a8927e8c698b144d669
change-id: 20230614-sa3ul-cb4bd1bb4d08

Best regards,

Signature · 1 line
Kamlesh Gurudasani <[email protected]>
#1 lore raw

PATCH v4 1/2 dt-bindings: crypto: ti,sa2ul: make power-domains conditional

Devices specific to compatible ti,am62-sa3ul don't have control over power of SA3UL from main domain.

"power-domains" property in crypto node tries to access the SA3UL power, for which it gets NACK and hence, driver doesn't probe properly for those particular devices.

Make "power-domains" property as false for devices with compatible ti,am62-sa3ul.

Fixes 2ce9a7299bf6 ("dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation")
---
 Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml +13 -1
index 77ec8bc70bf7..f0ef7685550a 100644
@@ -66,10 +66,22 @@ patternProperties:
 required:
   - compatible
   - reg
-  - power-domains
   - dmas
   - dma-names
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: ti,am62-sa3ul
+    then:
+      properties:
+        power-domains: false
+    else:
+      required:
+        - power-domains
+
 additionalProperties: false
 
 examples:
Signature · 1 line
2.34.1
#2 lore raw

PATCH v4 2/2 arm64: dts: ti: k3-am62-main: Remove power-domains from crypto node

In reply to Kamlesh Gurudasani

Only SYSFW has control of SA3UL power.
From SYSFW 08.04.00.002, for security reasons, device ID for power management of SA3UL has been removed.

"power-domains" property in crypto node tries to access the SA3UL, for which it gets NACK and hence, SA3UL driver doesn't probe properly.

Fixes 8af893654c02 ("arm64: dts: ti: k3-am62-main: Enable crypto accelerator")
---
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am62-main.dtsi +0 -1
index b3e4857bbbe4..18a6e9ffaf58 100644
@@ -174,7 +174,6 @@ k3_reset: reset-controller {
 	crypto: crypto@40900000 {
 		compatible = "ti,am62-sa3ul";
 		reg = <0x00 0x40900000 0x00 0x1200>;
-		power-domains = <&k3_pds 70 TI_SCI_PD_SHARED>;
 		#address-cells = <2>;
 		#size-cells = <2>;
 		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
Signature · 1 line
2.34.1