Remove power-domains property for devices with compatible ti,am62-sa3ul
v5 cover Remove power-domains property for devices with compatible ti,am62-sa3ul
SYSFW don't allow access to power of devices with compatible ti,am62-sa3ul from main domain.
Power-domains property, if present will try to access the power of the device, which will result into failure in probing of driver for that device.
Make power-domains property as false for devices with compatible ti,am62-sa3ul.
---
Changes in v5:
- Update recipient list
- Link to v4: https://lore.kernel.org/r/[email protected]
Changes in v4:
- s/items/contains/ for dt-binding patch
- Added "fixes commit" for dt-binding patch
- Link to v3: https://lore.kernel.org/r/[email protected]
Changes in v3:
- Add patch dt-bindings: crypto: ti,sa2ul: make power-domains conditional
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- Make commit message clearer
---
Kamlesh Gurudasani (2):
dt-bindings: crypto: ti,sa2ul: make power-domains conditional
arm64: dts: ti: k3-am62-main: Remove power-domains from crypto node
Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 +++++++++++++- arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 1 - 2 files changed, 13 insertions(+), 2 deletions(-)
---
base-commit: 53ab6975c12d1ad86c599a8927e8c698b144d669
change-id: 20230614-sa3ul-cb4bd1bb4d08
Best regards,
Signature · 7 lines
Kamlesh Gurudasani <[email protected]> _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v5 1/2 dt-bindings: crypto: ti,sa2ul: make power-domains conditional
Devices specific to compatible ti,am62-sa3ul don't have control over power of SA3UL from main domain.
"power-domains" property in crypto node tries to access the SA3UL power, for which it gets NACK and hence, driver doesn't probe properly for those particular devices.
Make "power-domains" property as false for devices with compatible ti,am62-sa3ul.
--- Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml +13 -1
@@ -66,10 +66,22 @@ patternProperties: required: - compatible - reg - - power-domains - dmas - dma-names +allOf: + - if: + properties: + compatible: + contains: + const: ti,am62-sa3ul + then: + properties: + power-domains: false + else: + required: + - power-domains + additionalProperties: false examples:
Signature · 7 lines
2.34.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Nishanth Menon
maintainerRe: [PATCH v5 1/2] dt-bindings: crypto: ti,sa2ul: make power-domains conditional
Quoted 10 lines · Kamlesh Gurudasani
Devices specific to compatible ti,am62-sa3ul don't have control over power of SA3UL from main domain.
"power-domains" property in crypto node tries to access the SA3UL power, for which it gets NACK and hence, driver doesn't probe properly for those particular devices.
Make "power-domains" property as false for devices with compatible ti,am62-sa3ul.
Quoted 7 lines
Fixes 2ce9a7299bf6 ("dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation")Reviewed-by Conor Dooley <[email protected]>Signed-off-by Kamlesh Gurudasani <[email protected]>--- Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
Herbert, Do you see a problem if I pick this patch via TI SoC Tree?
if you are OK, I'd like to take the series to keep it clean.
Quoted 33 lines
Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml +13
-1@@ -66,10 +66,22 @@ patternProperties: required: - compatible - reg - - power-domains - dmas - dma-names +allOf: + - if: + properties: + compatible: + contains: + const: ti,am62-sa3ul + then: + properties: + power-domains: false + else: + required: + - power-domains + additionalProperties: false examples:Signature · 2 lines
-- 2.34.1
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
PATCH v5 2/2 arm64: dts: ti: k3-am62-main: Remove power-domains from crypto node
In reply to Kamlesh GurudasaniOnly SYSFW has control of SA3UL power.
Quoted 1 line
From SYSFW 08.04.00.002, for security reasons, device ID for power
management of SA3UL has been removed.
"power-domains" property in crypto node tries to access the SA3UL, for which it gets NACK and hence, SA3UL driver doesn't probe properly.
--- arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 1 - 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am62-main.dtsi +0 -1
@@ -174,7 +174,6 @@ k3_reset: reset-controller { crypto: crypto@40900000 { compatible = "ti,am62-sa3ul"; reg = <0x00 0x40900000 0x00 0x1200>; - power-domains = <&k3_pds 70 TI_SCI_PD_SHARED>; #address-cells = <2>; #size-cells = <2>; ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
Signature · 7 lines
2.34.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Herbert,
I am going to assume that you are ok with me picking this series up as this results in a few broken boots for various boards. Let me know if that is not the case, and I will drop the series from my tree.
Hi Kamlesh Gurudasani,
Quoted 8 lines · Kamlesh Gurudasani
SYSFW don't allow access to power of devices with compatible ti,am62-sa3ul from main domain.
Power-domains property, if present will try to access the power of the device, which will result into failure in probing of driver for that device.
[...]
I have applied the following to branch ti-k3-dts-next on [1]. Thank you!
[1/2] dt-bindings: crypto: ti,sa2ul: make power-domains conditional
commit: e1f7d17a734c5c617d05c3d188939d5032d3d5a2
[2/2] arm64: dts: ti: k3-am62-main: Remove power-domains from crypto node
commit: b573bf35ef3f113c1717fa22cefdfdfbb83aec70All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Herbert Xu
maintainerQuoted 5 lines · Nishanth Menon
Herbert,
I am going to assume that you are ok with me picking this series up as this results in a few broken boots for various boards. Let me know if that is not the case, and I will drop the series from my tree.
Sure, no problems.
Thanks!
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt