bus: ti-sysc: Flush posted write on enable before reset
Tony Lindgren
maintainerPATCH 1/1 bus: ti-sysc: Flush posted write on enable before reset
The am335x devices started producing boot errors for resetting musb module in because of subtle timing changes:
Unhandled fault: external abort on non-linefetch (0x1008)
...sysc_poll_reset_sysconfig from sysc_reset+0x109/0x12 sysc_reset from sysc_probe+0xa99/0xeb0
...
The fix is to flush posted write after enable before reset during probe. Note that some devices also need to specify the delay after enable with ti,sysc-delay-us, but this is not needed for musb on am335x based on my tests.
Reported-by kernelci.org bot <[email protected]>
Fixes 596e7955692b ("bus: ti-sysc: Add support for software reset")
Signed-off-by Tony Lindgren <[email protected]>
--- drivers/bus/ti-sysc.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/bus/ti-sysc.c +2 -0
@@ -2142,6 +2142,8 @@ static int sysc_reset(struct sysc *ddata) sysc_val =sysc_read_sysconfig (ddata); sysc_val |= sysc_mask;sysc_write (ddata, sysc_offset, sysc_val); +/* Flush posted write */ + sysc_val =sysc_read_sysconfig (ddata); }if (ddata->cfg.srst_udelay)
Signature · 6 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel