Skip to contentSkip to conversation

MAINTAINERS: repair pattern in ARM/Amlogic Meson SoC CLOCK FRAMEWORK

PATCH In review Lukas Bulwahn 3 participants 3 messages Jun 14, 2023 – Jun 22, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: repair pattern in ARM/Amlogic Meson SoC CLOCK FRAMEWORK

Commit e6c6ddb397e2 ("dt-bindings: clock: meson: add A1 PLL clock controller bindings") adds a file entry with pattern "include/dt-bindings/clock/a1*" to the ARM/Amlogic Meson SoC CLOCK FRAMEWORK section. However, all header files added in the patch series to add Amlogic A1 clock controller drivers carry the prefix "amlogic,a1", and there are not header files matching "a1*".

Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a broken reference.

Adjust the pattern of this file entry to match the headers actually added.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index 08c7efe271c3..08f7c69c67c4 100644
@@ -1887,7 +1887,7 @@ L:	[email protected]
 S:	Maintained
 F:	Documentation/devicetree/bindings/clock/amlogic*
 F:	drivers/clk/meson/
-F:	include/dt-bindings/clock/a1*
+F:	include/dt-bindings/clock/amlogic,a1*
 F:	include/dt-bindings/clock/gxbb*
 F:	include/dt-bindings/clock/meson*
 
Signature · 1 line
2.17.1
reviewer
#1 lore raw
Quoted 7 lines · Lukas Bulwahn

Commit e6c6ddb397e2 ("dt-bindings: clock: meson: add A1 PLL clock controller bindings") adds a file entry with pattern "include/dt-bindings/clock/a1*" to the ARM/Amlogic Meson SoC CLOCK FRAMEWORK section. However, all header files added in the patch series to add Amlogic A1 clock controller drivers carry the prefix "amlogic,a1", and there are not header files matching "a1*".

Quoted 6 lines

Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a broken reference.

Adjust the pattern of this file entry to match the headers actually added.

Added fix tag:

Fixes e6c6ddb397e2 ("dt-bindings: clock: meson: add A1 PLL clock controller bindings")

and applied through the amlogic clock tree.
Thx

Quoted 16 lines
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index 08c7efe271c3..08f7c69c67c4 100644
@@ -1887,7 +1887,7 @@ L:	[email protected]
 S:	Maintained
 F:	Documentation/devicetree/bindings/clock/amlogic*
 F:	drivers/clk/meson/
-F:	include/dt-bindings/clock/a1*
+F:	include/dt-bindings/clock/amlogic,a1*
 F:	include/dt-bindings/clock/gxbb*
 F:	include/dt-bindings/clock/meson*
Reviewed-by on v1 1/1
#2 lore raw
In reply to Lukas Bulwahn

Dear Lukas,

I want to express my sincere gratitude for promptly correcting my mistake. Your help is truly appreciated. Thank you very much!

Quoted 22 lines · Lukas Bulwahn

Commit e6c6ddb397e2 ("dt-bindings: clock: meson: add A1 PLL clock controller bindings") adds a file entry with pattern "include/dt-bindings/clock/a1*" to the ARM/Amlogic Meson SoC CLOCK FRAMEWORK section. However, all header files added in the patch series to add Amlogic A1 clock controller drivers carry the prefix "amlogic,a1", and there are not header files matching "a1*".

Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a broken reference.

Adjust the pattern of this file entry to match the headers actually added.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index 08c7efe271c3..08f7c69c67c4 100644

MAINTAINERS L: [email protected] · line 1893

Quoted 8 lines
MAINTAINERS +1 -1
@@ -1887,7 +1887,7 @@ L:	[email protected]
 S:	Maintained
 F:	Documentation/devicetree/bindings/clock/amlogic*
 F:	drivers/clk/meson/
-F:	include/dt-bindings/clock/a1*
+F:	include/dt-bindings/clock/amlogic,a1*
 F:	include/dt-bindings/clock/gxbb*
 F:	include/dt-bindings/clock/meson*
 
Quoted 3 lines
Signature · 1 line
2.17.1
Signature · 2 lines
Thank you,
Dmitry