Skip to contentSkip to conversation

ixgbe: Allow setting IVAR register for X550EM_a

PATCH Applied Vladimir Ratnikov 3 participants 4 messages Jun 14, 2023 – Jun 21, 2023 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ixgbe: Allow setting IVAR register for X550EM_a

Fix interrupt mode initialization for X550EM_a revision

---
 drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ixgbe/ixgbe_ethdev.c +1 -0
index 43aea2e16f..d44ef37a7a 100644
@@ -5952,6 +5952,7 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t direction,
 	} else if ((hw->mac.type == ixgbe_mac_82599EB) ||
 			(hw->mac.type == ixgbe_mac_X540) ||
 			(hw->mac.type == ixgbe_mac_X550) ||
+			(hw->mac.type == ixgbe_mac_X550EM_a) ||
 			(hw->mac.type == ixgbe_mac_X550EM_x)) {
 		if (direction == -1) {
 			/* other causes */
Signature · 1 line
2.34.1
#1 lore raw

Ruifeng, there seems to be a unit testing failure on ARM that is preventing the patch from being merged. Could you help on this?
https://patchwork.dpdk.org/project/dpdk/patch/[email protected]/

Quoted 31 lines

-----Original Message-----
From: Vladimir Ratnikov <[email protected]>
Sent: Wednesday, June 14, 2023 9:26 PM
To: Yang, Qiming <[email protected]>; Wu, Wenjun1 <[email protected]>
Cc: [email protected]; Vladimir Ratnikov <[email protected]>
Subject: [PATCH] ixgbe: Allow setting IVAR register for X550EM_a

Fix interrupt mode initialization for X550EM_a revision

---
 drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ixgbe/ixgbe_ethdev.c +1 -0
index 43aea2e16f..d44ef37a7a 100644
@@ -5952,6 +5952,7 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t
 direction,
 	} else if ((hw->mac.type == ixgbe_mac_82599EB) ||
 			(hw->mac.type == ixgbe_mac_X540) ||
 			(hw->mac.type == ixgbe_mac_X550) ||
+			(hw->mac.type == ixgbe_mac_X550EM_a) ||
 			(hw->mac.type == ixgbe_mac_X550EM_x)) {
 		if (direction == -1) {

/* other causes */
--
2.34.1

#2 lore raw

Hi All,

It seems a false positive. I have tested the patch with aarch32 link_bond_autotest on arm server, and the test cases all succeed.

Best Regards,
Joyce

Quoted 28 lines

-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Monday, June 19, 2023 9:09 AM
To: Vladimir Ratnikov <[email protected]>; Yang, Qiming <[email protected]>; Wu, Wenjun1 <[email protected]>
Cc: [email protected]; Ruifeng Wang <[email protected]>
Subject: RE: [PATCH] ixgbe: Allow setting IVAR register for X550EM_a

Ruifeng, there seems to be a unit testing failure on ARM that is preventing the patch from being merged. Could you help on this?
https://patchwork.dpdk.org/project/dpdk/patch/20230614132626.2214-1-
[email protected]/

Quoted 15 lines

-----Original Message-----
From: Vladimir Ratnikov <[email protected]>
Sent: Wednesday, June 14, 2023 9:26 PM
To: Yang, Qiming <[email protected]>; Wu, Wenjun1 <[email protected]>
Cc: [email protected]; Vladimir Ratnikov <[email protected]>
Subject: [PATCH] ixgbe: Allow setting IVAR register for X550EM_a

Fix interrupt mode initialization for X550EM_a revision

---
 drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
Quoted 16 lines
Quoted 14 lines
drivers/net/ixgbe/ixgbe_ethdev.c +1 -0
index 43aea2e16f..d44ef37a7a 100644
@@ -5952,6 +5952,7 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t
 direction,
    } else if ((hw->mac.type == ixgbe_mac_82599EB) ||
                    (hw->mac.type == ixgbe_mac_X540) ||
                    (hw->mac.type == ixgbe_mac_X550) ||
+                   (hw->mac.type == ixgbe_mac_X550EM_a) ||
                    (hw->mac.type == ixgbe_mac_X550EM_x)) {
            if (direction == -1) {
                    /* other causes */
Quoted 2 lines

--
2.34.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Acked-by Applied
#3 lore raw
Quoted 11 lines

-----Original Message-----
From: Joyce Kong <[email protected]>
Sent: Monday, June 19, 2023 5:45 PM
To: Zhang, Qi Z <[email protected]>; Vladimir Ratnikov <[email protected]>; Yang, Qiming <[email protected]>; Wu, Wenjun1 <[email protected]>
Cc: [email protected]; Ruifeng Wang <[email protected]>
Subject: RE: [PATCH] ixgbe: Allow setting IVAR register for X550EM_a

Quoted 7 lines

Hi All,

It seems a false positive. I have tested the patch with aarch32 link_bond_autotest on arm server, and the test cases all succeed.

Best Regards,
Joyce

Thanks for the confirm.

Quoted 22 lines
Quoted 22 lines

-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Monday, June 19, 2023 9:09 AM
To: Vladimir Ratnikov <[email protected]>; Yang, Qiming <[email protected]>; Wu, Wenjun1 <[email protected]>
Cc: [email protected]; Ruifeng Wang <[email protected]>
Subject: RE: [PATCH] ixgbe: Allow setting IVAR register for X550EM_a

Ruifeng, there seems to be a unit testing failure on ARM that is preventing the patch from being merged. Could you help on this?
https://patchwork.dpdk.org/project/dpdk/patch/20230614132626.2214-1-
[email protected]/

Quoted 8 lines

-----Original Message-----
From: Vladimir Ratnikov <[email protected]>
Sent: Wednesday, June 14, 2023 9:26 PM
To: Yang, Qiming <[email protected]>; Wu, Wenjun1 <[email protected]>
Cc: [email protected]; Vladimir Ratnikov <[email protected]>
Subject: [PATCH] ixgbe: Allow setting IVAR register for X550EM_a

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Fix interrupt mode initialization for X550EM_a revision

Applied to dpdk-next-net-intel.

Thanks
Qi