Skip to contentSkip to conversation

linux: make kconfig depend on host-make

PATCH Applied Florian Larysch 3 participants 3 messages Jun 14, 2023 – Jul 6, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 linux: make kconfig depend on host-make

Commit 0b9efc991f ("linux: use BR2_MAKE") switched LINUX_MAKE to $(BR2_MAKE). However, this also implicitly sets LINUX_KCONFIG_MAKE.

Thus, when host-make is being used in a build that has PER_PACKAGE_DIRECTORIES enabled, the dotconfig step will try to use the make instance from the host directory, but since it is not listed in LINUX_KCONFIG_DEPENDENCIES, it won't be available yet at that point in time.

Add an explicit dependency to LINUX_KCONFIG_DEPENDENCIES to have it copied over early enough.

---
 linux/linux.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
linux/linux.mk +2 -1
index cc36b5251d..1c4fe45ac9 100644
@@ -88,7 +88,8 @@ LINUX_DEPENDENCIES += \
 # only if the host does not have them.
 LINUX_KCONFIG_DEPENDENCIES = \
 	$(BR2_BISON_HOST_DEPENDENCY) \
-	$(BR2_FLEX_HOST_DEPENDENCY)
+	$(BR2_FLEX_HOST_DEPENDENCY) \
+	$(BR2_MAKE_HOST_DEPENDENCY)
 
 # Starting with 4.18, the kconfig in the kernel calls the
 # cross-compiler to check its capabilities. So we need the
Signature · 6 lines
2.40.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 9 lines · Florian Larysch

Commit 0b9efc991f ("linux: use BR2_MAKE") switched LINUX_MAKE to $(BR2_MAKE). However, this also implicitly sets LINUX_KCONFIG_MAKE.

Thus, when host-make is being used in a build that has PER_PACKAGE_DIRECTORIES enabled, the dotconfig step will try to use the make instance from the host directory, but since it is not listed in LINUX_KCONFIG_DEPENDENCIES, it won't be available yet at that point in time.

Quoted 4 lines

Add an explicit dependency to LINUX_KCONFIG_DEPENDENCIES to have it copied over early enough.

Applied to master, thanks.

Regards,
Arnout

Quoted 9 lines
---
  linux/linux.mk | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
linux/linux.mk +0 -0
index cc36b5251d..1c4fe45ac9 100644

linux/linux.mk LINUX_DEPENDENCIES += \ · line 95

Quoted 9 lines
linux/linux.mk +2 -1
@@ -88,7 +88,8 @@ LINUX_DEPENDENCIES += \
  # only if the host does not have them.
  LINUX_KCONFIG_DEPENDENCIES = \
  	$(BR2_BISON_HOST_DEPENDENCY) \
-	$(BR2_FLEX_HOST_DEPENDENCY)
+	$(BR2_FLEX_HOST_DEPENDENCY) \
+	$(BR2_MAKE_HOST_DEPENDENCY)
 
  # Starting with 4.18, the kconfig in the kernel calls the
  # cross-compiler to check its capabilities. So we need the

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
In reply to Florian Larysch
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Florian" == Florian Larysch <[email protected]> writes:

Commit 0b9efc991f ("linux: use BR2_MAKE") switched LINUX_MAKE to $(BR2_MAKE). However, this also implicitly sets LINUX_KCONFIG_MAKE.

Thus, when host-make is being used in a build that has PER_PACKAGE_DIRECTORIES enabled, the dotconfig step will try to use the make instance from the host directory, but since it is not listed in LINUX_KCONFIG_DEPENDENCIES, it won't be available yet at that point in time.

Quoted 4 lines

Add an explicit dependency to LINUX_KCONFIG_DEPENDENCIES to have it copied over early enough.

Committed to 2023.05.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot