Skip to contentSkip to conversation

udplite/dccp: Print deprecation notice.

PATCH Applied Kuniyuki Iwashima 2 participants 4 messages Jun 14, 2023 – Jun 15, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover udplite/dccp: Print deprecation notice.

UDP-Lite is assumed to have no users for 7 years, and DCCP is orphaned for 7 years too.

Let's add deprecation notice and see if anyone responds to it.

Kuniyuki Iwashima (2):
udplite: Print deprecation notice.
dccp: Print deprecation notice.

 net/dccp/proto.c   | 3 +++
 net/ipv4/udplite.c | 2 ++
 net/ipv6/udplite.c | 4 ++++
 3 files changed, 9 insertions(+)
Signature · 1 line
2.30.2
#1 lore raw

PATCH 1/2 udplite: Print deprecation notice.

Recently syzkaller reported a 7-year-old null-ptr-deref [0] that occurs when a UDP-Lite socket tries to allocate a buffer under memory pressure.

Someone should have stumbled on the bug much earlier if UDP-Lite had been used in a real app. Also, we do not always need a large UDP-Lite workload to hit the bug since UDP and UDP-Lite share the same memory accounting limit.

Removing UDP-Lite would simplify UDP code removing a bunch of conditionals in fast path.

Let's add a deprecation notice when UDP-Lite socket is created and schedule its removal to 2025.

---
 net/ipv4/udplite.c | 2 ++
 net/ipv6/udplite.c | 4 ++++
 2 files changed, 6 insertions(+)
net/ipv4/udplite.c +2 -0
index 56d94d23b9e0..143f93a12f25 100644
@@ -22,6 +22,8 @@ static int udplite_sk_init(struct sock *sk)
 {
 	udp_init_sock(sk);
 	udp_sk(sk)->pcflag = UDPLITE_BIT;
+	pr_warn_once("UDP-Lite is deprecated and scheduled to be removed in 2025, "
+		     "please contact the netdev mailing list\n");
 	return 0;
 }
 
net/ipv6/udplite.c +4 -0
index 3bab0cc13697..8e010d07917a 100644
@@ -8,6 +8,8 @@
  *  Changes:
  *  Fixes:
  */
+#define pr_fmt(fmt) "UDPLite6: " fmt
+
 #include <linux/export.h>
 #include <linux/proc_fs.h>
 #include "udp_impl.h"
@@ -16,6 +18,8 @@ static int udplitev6_sk_init(struct sock *sk)
 {
 	udpv6_init_sock(sk);
 	udp_sk(sk)->pcflag = UDPLITE_BIT;
+	pr_warn_once("UDP-Lite is deprecated and scheduled to be removed in 2025, "
+		     "please contact the netdev mailing list\n");
 	return 0;
 }
 
Signature · 1 line
2.30.2
#2 lore raw

PATCH 2/2 dccp: Print deprecation notice.

In reply to Kuniyuki Iwashima

DCCP was marked as Orphan in the MAINTAINERS entry 2 years ago in commit 054c4610bd05 ("MAINTAINERS: dccp: move Gerrit Renker to CREDITS"). It says we haven't heard from the maintainer for five years, so DCCP is not well maintained for 7 years now.

Recently DCCP only receives updates for bugs, and major distros disable it by default.

Removing DCCP would allow for better organisation of TCP fields to reduce the number of cache lines hit in the fast path.

Let's add a deprecation notice when DCCP socket is created and schedule its removal to 2025.

---
 net/dccp/proto.c | 3 +++
 1 file changed, 3 insertions(+)
net/dccp/proto.c +3 -0
index a06b5641287a..b0ebf853cb07 100644
@@ -191,6 +191,9 @@ int dccp_init_sock(struct sock *sk, const __u8 ctl_sock_initialized)
 	struct dccp_sock *dp = dccp_sk(sk);
 	struct inet_connection_sock *icsk = inet_csk(sk);
 
+	pr_warn_once("DCCP is deprecated and scheduled to be removed in 2025, "
+		     "please contact the netdev mailing list\n");
+
 	icsk->icsk_rto		= DCCP_TIMEOUT_INIT;
 	icsk->icsk_syn_retries	= sysctl_dccp_request_retries;
 	sk->sk_state		= DCCP_CLOSED;
Signature · 1 line
2.30.2
#3 lore raw
In reply to Kuniyuki Iwashima
This series was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Wed, 14 Jun 2023 12:47:03 -0700 you wrote:

UDP-Lite is assumed to have no users for 7 years, and DCCP is orphaned for 7 years too.

Let's add deprecation notice and see if anyone responds to it.

Kuniyuki Iwashima (2):
udplite: Print deprecation notice.
dccp: Print deprecation notice.

[...]

Here is the summary with links:
- [v1,net,1/2] udplite: Print deprecation notice.

    https://git.kernel.org/netdev/net/c/be28c14ac8bb
  - [v1,net,2/2] dccp: Print deprecation notice.
    https://git.kernel.org/netdev/net/c/b144fcaf46d4

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html