Skip to contentSkip to conversation

arm64: dts: qcom: ipq9574: Use assigned-clock-rates for QUP I2C core clks

PATCH Applied Devi Priya 3 participants 5 messages Jun 15, 2023 – Jul 22, 2023

Subsystems (3)
lore
Share & tools
lore

Devi Priya

author
#0 lore raw

PATCH 1/1 arm64: dts: qcom: ipq9574: Use assigned-clock-rates for QUP I2C core clks

Use assigned-clock-rates property for configuring the QUP I2C core clocks to operate at nominal frequency.

---
 arch/arm64/boot/dts/qcom/ipq9574.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/qcom/ipq9574.dtsi +8 -0
index 0baeb10bbdae..78bf7f9c455a 100644
@@ -361,6 +361,8 @@
 			clocks = <&gcc GCC_BLSP1_QUP2_I2C_APPS_CLK>,
 				 <&gcc GCC_BLSP1_AHB_CLK>;
 			clock-names = "core", "iface";
+			assigned-clocks = <&gcc GCC_BLSP1_QUP2_I2C_APPS_CLK>;
+			assigned-clock-rates = <50000000>;
 			dmas = <&blsp_dma 14>, <&blsp_dma 15>;
 			dma-names = "tx", "rx";
 			status = "disabled";
@@ -389,6 +391,8 @@
 			clocks = <&gcc GCC_BLSP1_QUP3_I2C_APPS_CLK>,
 				 <&gcc GCC_BLSP1_AHB_CLK>;
 			clock-names = "core", "iface";
+			assigned-clocks = <&gcc GCC_BLSP1_QUP3_I2C_APPS_CLK>;
+			assigned-clock-rates = <50000000>;
 			dmas = <&blsp_dma 16>, <&blsp_dma 17>;
 			dma-names = "tx", "rx";
 			status = "disabled";
@@ -417,6 +421,8 @@
 			clocks = <&gcc GCC_BLSP1_QUP4_I2C_APPS_CLK>,
 				 <&gcc GCC_BLSP1_AHB_CLK>;
 			clock-names = "core", "iface";
+			assigned-clocks = <&gcc GCC_BLSP1_QUP4_I2C_APPS_CLK>;
+			assigned-clock-rates = <50000000>;
 			dmas = <&blsp_dma 18>, <&blsp_dma 19>;
 			dma-names = "tx", "rx";
 			status = "disabled";
@@ -446,6 +452,8 @@
 			clocks = <&gcc GCC_BLSP1_QUP5_I2C_APPS_CLK>,
 				 <&gcc GCC_BLSP1_AHB_CLK>;
 			clock-names = "core", "iface";
+			assigned-clocks = <&gcc GCC_BLSP1_QUP5_I2C_APPS_CLK>;
+			assigned-clock-rates = <50000000>;
 			dmas = <&blsp_dma 20>, <&blsp_dma 21>;
 			dma-names = "tx", "rx";
 			status = "disabled";
Signature · 1 line
2.17.1
#1 lore raw
Quoted 5 lines · Devi Priya

Use assigned-clock-rates property for configuring the QUP I2C core clocks to operate at nominal frequency.

---

There's probably some logic behind this, and it almost sounds like it'd be fitting to introduce an OPP table for I2C hosts, especially given the voltage requirements.

Konrad

Quoted 43 lines
 arch/arm64/boot/dts/qcom/ipq9574.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/qcom/ipq9574.dtsi +8 -0
index 0baeb10bbdae..78bf7f9c455a 100644
@@ -361,6 +361,8 @@
 			clocks = <&gcc GCC_BLSP1_QUP2_I2C_APPS_CLK>,
 				 <&gcc GCC_BLSP1_AHB_CLK>;
 			clock-names = "core", "iface";
+			assigned-clocks = <&gcc GCC_BLSP1_QUP2_I2C_APPS_CLK>;
+			assigned-clock-rates = <50000000>;
 			dmas = <&blsp_dma 14>, <&blsp_dma 15>;
 			dma-names = "tx", "rx";
 			status = "disabled";
@@ -389,6 +391,8 @@
 			clocks = <&gcc GCC_BLSP1_QUP3_I2C_APPS_CLK>,
 				 <&gcc GCC_BLSP1_AHB_CLK>;
 			clock-names = "core", "iface";
+			assigned-clocks = <&gcc GCC_BLSP1_QUP3_I2C_APPS_CLK>;
+			assigned-clock-rates = <50000000>;
 			dmas = <&blsp_dma 16>, <&blsp_dma 17>;
 			dma-names = "tx", "rx";
 			status = "disabled";
@@ -417,6 +421,8 @@
 			clocks = <&gcc GCC_BLSP1_QUP4_I2C_APPS_CLK>,
 				 <&gcc GCC_BLSP1_AHB_CLK>;
 			clock-names = "core", "iface";
+			assigned-clocks = <&gcc GCC_BLSP1_QUP4_I2C_APPS_CLK>;
+			assigned-clock-rates = <50000000>;
 			dmas = <&blsp_dma 18>, <&blsp_dma 19>;
 			dma-names = "tx", "rx";
 			status = "disabled";
@@ -446,6 +452,8 @@
 			clocks = <&gcc GCC_BLSP1_QUP5_I2C_APPS_CLK>,
 				 <&gcc GCC_BLSP1_AHB_CLK>;
 			clock-names = "core", "iface";
+			assigned-clocks = <&gcc GCC_BLSP1_QUP5_I2C_APPS_CLK>;
+			assigned-clock-rates = <50000000>;
 			dmas = <&blsp_dma 20>, <&blsp_dma 21>;
 			dma-names = "tx", "rx";
 			status = "disabled";
author
#2 lore raw
Quoted 11 lines · Konrad Dybcio
Quoted 5 lines · Devi Priya

Use assigned-clock-rates property for configuring the QUP I2C core clocks to operate at nominal frequency.

---

There's probably some logic behind this, and it almost sounds like it'd be fitting to introduce an OPP table for I2C hosts, especially given the voltage requirements.

Konrad

The qup i2c core clocks are not scalable and operate at fixed frequency. The assigned-clock-rates are used to configure the clock frequency if it is not done by the bootloaders.

Thanks,
Devi Priya

Quoted 43 lines
Quoted 43 lines
  arch/arm64/boot/dts/qcom/ipq9574.dtsi | 8 ++++++++
  1 file changed, 8 insertions(+)
arch/arm64/boot/dts/qcom/ipq9574.dtsi +8 -0
index 0baeb10bbdae..78bf7f9c455a 100644
@@ -361,6 +361,8 @@
  			clocks = <&gcc GCC_BLSP1_QUP2_I2C_APPS_CLK>,
  				 <&gcc GCC_BLSP1_AHB_CLK>;
  			clock-names = "core", "iface";
+			assigned-clocks = <&gcc GCC_BLSP1_QUP2_I2C_APPS_CLK>;
+			assigned-clock-rates = <50000000>;
  			dmas = <&blsp_dma 14>, <&blsp_dma 15>;
  			dma-names = "tx", "rx";
  			status = "disabled";
@@ -389,6 +391,8 @@
  			clocks = <&gcc GCC_BLSP1_QUP3_I2C_APPS_CLK>,
  				 <&gcc GCC_BLSP1_AHB_CLK>;
  			clock-names = "core", "iface";
+			assigned-clocks = <&gcc GCC_BLSP1_QUP3_I2C_APPS_CLK>;
+			assigned-clock-rates = <50000000>;
  			dmas = <&blsp_dma 16>, <&blsp_dma 17>;
  			dma-names = "tx", "rx";
  			status = "disabled";
@@ -417,6 +421,8 @@
  			clocks = <&gcc GCC_BLSP1_QUP4_I2C_APPS_CLK>,
  				 <&gcc GCC_BLSP1_AHB_CLK>;
  			clock-names = "core", "iface";
+			assigned-clocks = <&gcc GCC_BLSP1_QUP4_I2C_APPS_CLK>;
+			assigned-clock-rates = <50000000>;
  			dmas = <&blsp_dma 18>, <&blsp_dma 19>;
  			dma-names = "tx", "rx";
  			status = "disabled";
@@ -446,6 +452,8 @@
  			clocks = <&gcc GCC_BLSP1_QUP5_I2C_APPS_CLK>,
  				 <&gcc GCC_BLSP1_AHB_CLK>;
  			clock-names = "core", "iface";
+			assigned-clocks = <&gcc GCC_BLSP1_QUP5_I2C_APPS_CLK>;
+			assigned-clock-rates = <50000000>;
  			dmas = <&blsp_dma 20>, <&blsp_dma 21>;
  			dma-names = "tx", "rx";
  			status = "disabled";
#3 lore raw
Quoted 9 lines · Devi Priya
Quoted 6 lines · Konrad Dybcio
Quoted 5 lines · Devi Priya

Use assigned-clock-rates property for configuring the QUP I2C core clocks to operate at nominal frequency.

---

Quoted 8 lines
Quoted 5 lines

There's probably some logic behind this, and it almost sounds like it'd be fitting to introduce an OPP table for I2C hosts, especially given the voltage requirements.

Konrad

The qup i2c core clocks are not scalable and operate at fixed frequency. The assigned-clock-rates are used to configure the clock frequency if it is not done by the bootloaders.

OPP tables with a single entry are totally fine.

Konrad

Quoted 46 lines

Thanks,
Devi Priya

Quoted 43 lines
Quoted 43 lines

  arch/arm64/boot/dts/qcom/ipq9574.dtsi | 8 ++++++++

  1 file changed, 8 insertions(+)
arch/arm64/boot/dts/qcom/ipq9574.dtsi +8 -0
index 0baeb10bbdae..78bf7f9c455a 100644
@@ -361,6 +361,8 @@
               clocks = <&gcc GCC_BLSP1_QUP2_I2C_APPS_CLK>,
                    <&gcc GCC_BLSP1_AHB_CLK>;
               clock-names = "core", "iface";
+            assigned-clocks = <&gcc GCC_BLSP1_QUP2_I2C_APPS_CLK>;
+            assigned-clock-rates = <50000000>;
               dmas = <&blsp_dma 14>, <&blsp_dma 15>;
               dma-names = "tx", "rx";
               status = "disabled";
@@ -389,6 +391,8 @@
               clocks = <&gcc GCC_BLSP1_QUP3_I2C_APPS_CLK>,
                    <&gcc GCC_BLSP1_AHB_CLK>;
               clock-names = "core", "iface";
+            assigned-clocks = <&gcc GCC_BLSP1_QUP3_I2C_APPS_CLK>;
+            assigned-clock-rates = <50000000>;
               dmas = <&blsp_dma 16>, <&blsp_dma 17>;
               dma-names = "tx", "rx";
               status = "disabled";
@@ -417,6 +421,8 @@
               clocks = <&gcc GCC_BLSP1_QUP4_I2C_APPS_CLK>,
                    <&gcc GCC_BLSP1_AHB_CLK>;
               clock-names = "core", "iface";
+            assigned-clocks = <&gcc GCC_BLSP1_QUP4_I2C_APPS_CLK>;
+            assigned-clock-rates = <50000000>;
               dmas = <&blsp_dma 18>, <&blsp_dma 19>;
               dma-names = "tx", "rx";
               status = "disabled";
@@ -446,6 +452,8 @@
               clocks = <&gcc GCC_BLSP1_QUP5_I2C_APPS_CLK>,
                    <&gcc GCC_BLSP1_AHB_CLK>;
               clock-names = "core", "iface";
+            assigned-clocks = <&gcc GCC_BLSP1_QUP5_I2C_APPS_CLK>;
+            assigned-clock-rates = <50000000>;
               dmas = <&blsp_dma 20>, <&blsp_dma 21>;
               dma-names = "tx", "rx";
               status = "disabled";
maintainer Applied
#4 lore raw
In reply to Devi Priya
Quoted 4 lines · Devi Priya

Use assigned-clock-rates property for configuring the QUP I2C core clocks to operate at nominal frequency.

Applied, thanks!

[1/1] arm64: dts: qcom: ipq9574: Use assigned-clock-rates for QUP I2C core clks

      commit: 5229c1d6a0c7d7d8f51a27833e568909b8707c39

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>