Skip to contentSkip to conversation

drm/bridge: tc358764: Fix debug print parameter order

PATCH Applied Marek Vasut 2 participants 2 messages Jun 15, 2023 – Jun 16, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/bridge: tc358764: Fix debug print parameter order

The debug print parameters were swapped in the output and they were printed as decimal values, both the hardware address and the value. Update the debug print to print the parameters in correct order, and use hexadecimal print for both address and value.

Fixes f38b7cca6d0e ("drm/bridge: tc358764: Add DSI to LVDS bridge driver")

---
Cc: Andrzej Hajda <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Jernej Skrabec <[email protected]>
Cc: Jonas Karlman <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: Robert Foss <[email protected]>
Cc: [email protected]

---
 drivers/gpu/drm/bridge/tc358764.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/tc358764.c +1 -1
index f85654f1b1045..8e938a7480f37 100644
@@ -176,7 +176,7 @@ static void tc358764_read(struct tc358764 *ctx, u16 addr, u32 *val)
 	if (ret >= 0)
 		le32_to_cpus(val);
 
-	dev_dbg(ctx->dev, "read: %d, addr: %d\n", addr, *val);
+	dev_dbg(ctx->dev, "read: addr=0x%04x data=0x%08x\n", addr, *val);
 }
 
 static void tc358764_write(struct tc358764 *ctx, u16 addr, u32 val)
Signature · 1 line
2.39.2
maintainer Reviewed-by on v1 1/1 Applied
#1 lore raw

From: Robert Foss <[email protected]>

Quoted 6 lines · Marek Vasut

The debug print parameters were swapped in the output and they were printed as decimal values, both the hardware address and the value. Update the debug print to print the parameters in correct order, and use hexadecimal print for both address and value.

Applied, thanks!

[1/1] drm/bridge: tc358764: Fix debug print parameter order

      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=7f947be02aab

Rob