Skip to contentSkip to conversation

gpio: mpc8xxx: Remove unused of_gpio.h inclusion

PATCH Applied Andy Shevchenko 3 participants 3 messages Jun 15, 2023 – Jun 19, 2023 GPIO

lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 gpio: mpc8xxx: Remove unused of_gpio.h inclusion

The of_gpio.h is not and shouldn't be used in the GPIO drivers. Remove it.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/gpio/gpio-mpc8xxx.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpio/gpio-mpc8xxx.c +0 -1
index 3eb08cd1fdc0..35214e9de4ce 100644
@@ -12,7 +12,6 @@
 #include <linux/spinlock.h>
 #include <linux/io.h>
 #include <linux/of.h>
-#include <linux/of_gpio.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
 #include <linux/of_platform.h>
Signature · 1 line
2.40.0.1.gaa8946217a0b
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · On Thursday 15 June 2023 19:25:14 Andy Shevchenko wrote:

The of_gpio.h is not and shouldn't be used in the GPIO drivers. Remove it.

Signed-off-by Andy Shevchenko <[email protected]>
Reviewed-by Pali Rohár <[email protected]>
Quoted 19 lines
---
 drivers/gpio/gpio-mpc8xxx.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpio/gpio-mpc8xxx.c +0 -1
index 3eb08cd1fdc0..35214e9de4ce 100644
@@ -12,7 +12,6 @@
 #include <linux/spinlock.h>
 #include <linux/io.h>
 #include <linux/of.h>
-#include <linux/of_gpio.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
 #include <linux/of_platform.h>
Signature · 1 line
2.40.0.1.gaa8946217a0b
Applied
#2 lore raw
In reply to Andy Shevchenko
Quoted 22 lines · Andy Shevchenko

The of_gpio.h is not and shouldn't be used in the GPIO drivers. Remove it.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/gpio/gpio-mpc8xxx.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpio/gpio-mpc8xxx.c +0 -2
index 3eb08cd1fdc0..35214e9de4ce 100644
@@ -12,7 +12,6 @@
 #include <linux/spinlock.h>
 #include <linux/io.h>
 #include <linux/of.h>
-#include <linux/of_gpio.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
 #include <linux/of_platform.h>
--
Quoted 2 lines

2.40.0.1.gaa8946217a0b

Applied, thanks!

Bart