Skip to contentSkip to conversation

mtd: rawnand: Remove unused of_gpio.h inclusion

PATCH In review Andy Shevchenko 3 participants 5 messages Jun 15, 2023 – Oct 6, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: rawnand: Remove unused of_gpio.h inclusion

The of_gpio.h is not and shouldn't be used in the drivers. Remove it.

---
 drivers/mtd/nand/raw/nand_base.c | 1 -
 drivers/mtd/nand/raw/xway_nand.c | 1 -
 2 files changed, 2 deletions(-)
drivers/mtd/nand/raw/nand_base.c +0 -1
index a6af521832aa..132e3bee8f5a 100644
@@ -42,7 +42,6 @@
 #include <linux/io.h>
 #include <linux/mtd/partitions.h>
 #include <linux/of.h>
-#include <linux/of_gpio.h>
 #include <linux/gpio/consumer.h>
 
 #include "internals.h"
drivers/mtd/nand/raw/xway_nand.c +0 -1
index 6b1e2a2bba15..5a19b6b314b4 100644
@@ -6,7 +6,6 @@
  */
 
 #include <linux/mtd/rawnand.h>
-#include <linux/of_gpio.h>
 #include <linux/of_platform.h>
 
 #include <lantiq_soc.h>
Signature · 6 lines
2.40.0.1.gaa8946217a0b


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
#2 lore raw
Quoted 7 lines · Martin Blumenstingl
Quoted 4 lines · Andy Shevchenko

The of_gpio.h is not and shouldn't be used in the drivers. Remove it.

Thank you!

Can it be applied now?

Signature · 8 lines
With Best Regards,
Andy Shevchenko



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
#3 lore raw

+Cc: GPIO maintainers

Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Martin Blumenstingl
Quoted 1 line · Andy Shevchenko
Quoted 8 lines
Quoted 4 lines
Quoted 3 lines

The of_gpio.h is not and shouldn't be used in the drivers. Remove it.

Thank you!

Can it be applied now?

So, this is still not applied, does it mean we need to go via GPIO tree with it?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#4 lore raw

Hi Andy,

[email protected] wrote on Fri, 6 Oct 2023 18:14:24 +0300:

Quoted 10 lines

+Cc: GPIO maintainers

Quoted 7 lines · Andy Shevchenko
Quoted 6 lines · Martin Blumenstingl
Quoted 4 lines · Andy Shevchenko

The of_gpio.h is not and shouldn't be used in the drivers. Remove it.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Thank you!

Can it be applied now?

So, this is still not applied, does it mean we need to go via GPIO tree with it?

I remember your ping and also answering it, but I cannot find it. Let me look into this. In any case, apologies for that.

Thanks,
Miquèl