Skip to contentSkip to conversation

drm/panel: simple: Add Powertip PH800480T013 drm_display_mode flags

PATCH Applied Marek Vasut 3 participants 3 messages Jun 15, 2023 – Jun 30, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/panel: simple: Add Powertip PH800480T013 drm_display_mode flags

Add missing drm_display_mode DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC flags. Those are used by various bridges in the pipeline to correctly configure its sync signals polarity.

Fixes d69de69f2be1 ("drm/panel: simple: Add Powertip PH800480T013 panel")

---
Cc: Daniel Vetter <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: [email protected]

---
 drivers/gpu/drm/panel/panel-simple.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/panel/panel-simple.c +1 -0
index b81b21901940b..a0f4302de130a 100644
@@ -3202,6 +3202,7 @@ static const struct drm_display_mode powertip_ph800480t013_idf02_mode = {
 	.vsync_start = 480 + 49,
 	.vsync_end = 480 + 49 + 2,
 	.vtotal = 480 + 49 + 2 + 22,
+	.flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
 };
 
 static const struct panel_desc powertip_ph800480t013_idf02  = {
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Marek Vasut

Add missing drm_display_mode DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC flags. Those are used by various bridges in the pipeline to correctly configure its sync signals polarity.

Fixes d69de69f2be1 ("drm/panel: simple: Add Powertip PH800480T013 panel")

I do not know PowerTip, but the patch looks fine.

Quoted 24 lines

---
Cc: Daniel Vetter <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: [email protected]

---
 drivers/gpu/drm/panel/panel-simple.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/panel/panel-simple.c +1 -0
index b81b21901940b..a0f4302de130a 100644
@@ -3202,6 +3202,7 @@ static const struct drm_display_mode powertip_ph800480t013_idf02_mode = {
 	.vsync_start = 480 + 49,
 	.vsync_end = 480 + 49 + 2,
 	.vtotal = 480 + 49 + 2 + 22,
+	.flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
 };
 
 static const struct panel_desc powertip_ph800480t013_idf02  = {
Signature · 1 line
2.39.2
maintainer Applied
#2 lore raw
In reply to Marek Vasut

Hi,

Quoted 5 lines · Marek Vasut

Add missing drm_display_mode DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC flags. Those are used by various bridges in the pipeline to correctly configure its sync signals polarity.

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes)

[1/1] drm/panel: simple: Add Powertip PH800480T013 drm_display_mode flags

      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=1c519980aced3da1fae37c1339cf43b24eccdee7
Signature · 1 line
Neil