Skip to contentSkip to conversation

drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

PATCH Superseded Zhanjun Dong 4 participants 8 messages Jun 15, 2023 – Jul 24, 2023

Subsystems (2)

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset.
Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync version for reset path, it is safe as the worker has the trylock code to handle the lock; Meanwhile keep the sync version for park/fini to ensure the worker is not still running during suspend or shutdown.

WARNING: possible circular locking dependency detected 6.4.0-rc1-drmtip_1340-g31e3463b0edb+ #1 Not tainted
------------------------------------------------------
kms_pipe_crc_ba/6415 is trying to acquire lock:
ffff88813e6cc640 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}, at: __flush_work+0x42/0x530

but task is already holding lock:
ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #3 (&gt->reset.mutex){+.+.}-{3:3}:

        lock_acquire+0xd8/0x2d0
        i915_gem_shrinker_taints_mutex+0x31/0x50 [i915]
        intel_gt_init_reset+0x65/0x80 [i915]
        intel_gt_common_init_early+0xe1/0x170 [i915]
        intel_root_gt_init_early+0x48/0x60 [i915]
        i915_driver_probe+0x671/0xcb0 [i915]
        i915_pci_probe+0xdc/0x210 [i915]
        pci_device_probe+0x95/0x120
        really_probe+0x164/0x3c0
        __driver_probe_device+0x73/0x160
        driver_probe_device+0x19/0xa0
        __driver_attach+0xb6/0x180
        bus_for_each_dev+0x77/0xd0
        bus_add_driver+0x114/0x210
        driver_register+0x5b/0x110
        __pfx_vgem_open+0x3/0x10 [vgem]
        do_one_initcall+0x57/0x270
        do_init_module+0x5f/0x220
        load_module+0x1ca4/0x1f00
        __do_sys_finit_module+0xb4/0x130
        do_syscall_64+0x3c/0x90
        entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #2 (fs_reclaim){+.+.}-{0:0}:

        lock_acquire+0xd8/0x2d0
        fs_reclaim_acquire+0xac/0xe0
        kmem_cache_alloc+0x32/0x260
        i915_vma_instance+0xb2/0xc60 [i915]
        i915_gem_object_ggtt_pin_ww+0x175/0x370 [i915]
        vm_fault_gtt+0x22d/0xf60 [i915]
        __do_fault+0x2f/0x1d0
        do_pte_missing+0x4a/0xd20
        __handle_mm_fault+0x5b0/0x790
        handle_mm_fault+0xa2/0x230
        do_user_addr_fault+0x3ea/0xa10
        exc_page_fault+0x68/0x1a0
        asm_exc_page_fault+0x26/0x30

-> #1 (&gt->reset.backoff_srcu){++++}-{0:0}:

        lock_acquire+0xd8/0x2d0
        _intel_gt_reset_lock+0x57/0x330 [i915]
        guc_timestamp_ping+0x35/0x130 [i915]
        process_one_work+0x250/0x510
        worker_thread+0x4f/0x3a0
        kthread+0xff/0x130
        ret_from_fork+0x29/0x50

-> #0 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}:

        check_prev_add+0x90/0xc60
        __lock_acquire+0x1998/0x2590
        lock_acquire+0xd8/0x2d0
        __flush_work+0x74/0x530
        __cancel_work_timer+0x14f/0x1f0
        intel_guc_submission_reset_prepare+0x81/0x4b0 [i915]
        intel_uc_reset_prepare+0x9c/0x120 [i915]
        reset_prepare+0x21/0x60 [i915]
        intel_gt_reset+0x1dd/0x470 [i915]
        intel_gt_reset_global+0xfb/0x170 [i915]
        intel_gt_handle_error+0x368/0x420 [i915]
        intel_gt_debugfs_reset_store+0x5c/0xc0 [i915]
        i915_wedged_set+0x29/0x40 [i915]
        simple_attr_write_xsigned.constprop.0+0xb4/0x110
        full_proxy_write+0x52/0x80
        vfs_write+0xc5/0x4f0
        ksys_write+0x64/0xe0
        do_syscall_64+0x3c/0x90
        entry_SYSCALL_64_after_hwframe+0x72/0xdc

other info that might help us debug this:

 Chain exists of:
  (work_completion)(&(&guc->timestamp.work)->work) --> fs_reclaim --> &gt->reset.mutex
  Possible unsafe locking scenario:
        CPU0                    CPU1
        ----                    ----
   lock(&gt->reset.mutex);
                                lock(fs_reclaim);
                                lock(&gt->reset.mutex);
   lock((work_completion)(&(&guc->timestamp.work)->work));

*** DEADLOCK ***
3 locks held by kms_pipe_crc_ba/6415:
#0: ffff888101541430 (sb_writers#15){.+.+}-{0:0}, at: ksys_write+0x64/0xe0
#1: ffff888136c7eab8 (&attr->mutex){+.+.}-{3:3}, at: simple_attr_write_xsigned.constprop.0+0x47/0x110 #2: ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

v2: Add sync flag to guc_cancel_busyness_worker to ensure reset path calls asynchronous cancel.
v3: Add sync flag to intel_guc_submission_disable to ensure reset path calls asynchronous cancel.

---
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c   | 17 ++++++++++-------
 .../gpu/drm/i915/gt/uc/intel_guc_submission.h   |  2 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc.c           |  4 ++--
 3 files changed, 13 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +10 -7
index a0e3ef1c65d2..ef4300246ce1 100644
@@ -1357,9 +1357,12 @@ static void guc_enable_busyness_worker(struct intel_guc *guc)
 	mod_delayed_work(system_highpri_wq, &guc->timestamp.work, guc->timestamp.ping_delay);
 }
 
-static void guc_cancel_busyness_worker(struct intel_guc *guc)
+static void guc_cancel_busyness_worker(struct intel_guc *guc, bool sync)
 {
-	cancel_delayed_work_sync(&guc->timestamp.work);
+	if (sync)
+		cancel_delayed_work_sync(&guc->timestamp.work);
+	else
+		cancel_delayed_work(&guc->timestamp.work);
 }
 
 static void __reset_guc_busyness_stats(struct intel_guc *guc)
@@ -1370,7 +1373,7 @@ static void __reset_guc_busyness_stats(struct intel_guc *guc)
 	unsigned long flags;
 	ktime_t unused;
 
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, false);
 
 	spin_lock_irqsave(&guc->timestamp.lock, flags);
 
@@ -1485,7 +1488,7 @@ static int guc_init_engine_stats(struct intel_guc *guc)
 
 static void guc_fini_engine_stats(struct intel_guc *guc)
 {
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, true);
 }
 
 void intel_guc_busyness_park(struct intel_gt *gt)
@@ -1500,7 +1503,7 @@ void intel_guc_busyness_park(struct intel_gt *gt)
 	 * and causes an unclaimed register access warning. Cancel the worker
 	 * synchronously here.
 	 */
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, true);
 
 	/*
 	 * Before parking, we should sample engine busyness stats if we need to.
@@ -4501,9 +4504,9 @@ int intel_guc_submission_enable(struct intel_guc *guc)
 }
 
 /* Note: By the time we're here, GuC may have already been reset */
-void intel_guc_submission_disable(struct intel_guc *guc)
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync)
 {
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, sync);
 
 	/* Semaphore interrupt disable and route to host */
 	guc_route_semaphores(guc, false);
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h +1 -1
index c57b29cdb1a6..a77de0d6ed58 100644
@@ -16,7 +16,7 @@ struct intel_engine_cs;
 void intel_guc_submission_init_early(struct intel_guc *guc);
 int intel_guc_submission_init(struct intel_guc *guc);
 int intel_guc_submission_enable(struct intel_guc *guc);
-void intel_guc_submission_disable(struct intel_guc *guc);
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync);
 void intel_guc_submission_fini(struct intel_guc *guc);
 int intel_guc_preempt_work_create(struct intel_guc *guc);
 void intel_guc_preempt_work_destroy(struct intel_guc *guc);
drivers/gpu/drm/i915/gt/uc/intel_uc.c +2 -2
index 18250fb64bd8..edf13f89830e 100644
@@ -566,7 +566,7 @@ static int __uc_init_hw(struct intel_uc *uc)
 	 * We've failed to load the firmware :(
 	 */
 err_submission:
-	intel_guc_submission_disable(guc);
+	intel_guc_submission_disable(guc, true);
 err_log_capture:
 	__uc_capture_load_err_log(uc);
 err_rps:
@@ -597,7 +597,7 @@ static void __uc_fini_hw(struct intel_uc *uc)
 		return;
 
 	if (intel_uc_uses_guc_submission(uc))
-		intel_guc_submission_disable(guc);
+		intel_guc_submission_disable(guc, false);
 
 	__uc_sanitize(uc);
 }
Signature · 1 line
2.34.1
#1 lore raw

V3 is to follow John's suggestion option 1. The better option is in discussion and might have boarder impact.

Meanwhile we can start with option 1, check CI system report and see if issue getting better.

Regards,

Zhanjun Dong

Quoted 205 lines · Zhanjun Dong

This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset.
Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync version for reset path, it is safe as the worker has the trylock code to handle the lock; Meanwhile keep the sync version for park/fini to ensure the worker is not still running during suspend or shutdown.

WARNING: possible circular locking dependency detected 6.4.0-rc1-drmtip_1340-g31e3463b0edb+ #1 Not tainted
------------------------------------------------------
kms_pipe_crc_ba/6415 is trying to acquire lock:
ffff88813e6cc640 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}, at: __flush_work+0x42/0x530

but task is already holding lock:
ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #3 (&gt->reset.mutex){+.+.}-{3:3}:

         lock_acquire+0xd8/0x2d0
         i915_gem_shrinker_taints_mutex+0x31/0x50 [i915]
         intel_gt_init_reset+0x65/0x80 [i915]
         intel_gt_common_init_early+0xe1/0x170 [i915]
         intel_root_gt_init_early+0x48/0x60 [i915]
         i915_driver_probe+0x671/0xcb0 [i915]
         i915_pci_probe+0xdc/0x210 [i915]
         pci_device_probe+0x95/0x120
         really_probe+0x164/0x3c0
         __driver_probe_device+0x73/0x160
         driver_probe_device+0x19/0xa0
         __driver_attach+0xb6/0x180
         bus_for_each_dev+0x77/0xd0
         bus_add_driver+0x114/0x210
         driver_register+0x5b/0x110
         __pfx_vgem_open+0x3/0x10 [vgem]
         do_one_initcall+0x57/0x270
         do_init_module+0x5f/0x220
         load_module+0x1ca4/0x1f00
         __do_sys_finit_module+0xb4/0x130
         do_syscall_64+0x3c/0x90
         entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #2 (fs_reclaim){+.+.}-{0:0}:

         lock_acquire+0xd8/0x2d0
         fs_reclaim_acquire+0xac/0xe0
         kmem_cache_alloc+0x32/0x260
         i915_vma_instance+0xb2/0xc60 [i915]
         i915_gem_object_ggtt_pin_ww+0x175/0x370 [i915]
         vm_fault_gtt+0x22d/0xf60 [i915]
         __do_fault+0x2f/0x1d0
         do_pte_missing+0x4a/0xd20
         __handle_mm_fault+0x5b0/0x790
         handle_mm_fault+0xa2/0x230
         do_user_addr_fault+0x3ea/0xa10
         exc_page_fault+0x68/0x1a0
         asm_exc_page_fault+0x26/0x30

-> #1 (&gt->reset.backoff_srcu){++++}-{0:0}:

         lock_acquire+0xd8/0x2d0
         _intel_gt_reset_lock+0x57/0x330 [i915]
         guc_timestamp_ping+0x35/0x130 [i915]
         process_one_work+0x250/0x510
         worker_thread+0x4f/0x3a0
         kthread+0xff/0x130
         ret_from_fork+0x29/0x50

-> #0 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}:

         check_prev_add+0x90/0xc60
         __lock_acquire+0x1998/0x2590
         lock_acquire+0xd8/0x2d0
         __flush_work+0x74/0x530
         __cancel_work_timer+0x14f/0x1f0
         intel_guc_submission_reset_prepare+0x81/0x4b0 [i915]
         intel_uc_reset_prepare+0x9c/0x120 [i915]
         reset_prepare+0x21/0x60 [i915]
         intel_gt_reset+0x1dd/0x470 [i915]
         intel_gt_reset_global+0xfb/0x170 [i915]
         intel_gt_handle_error+0x368/0x420 [i915]
         intel_gt_debugfs_reset_store+0x5c/0xc0 [i915]
         i915_wedged_set+0x29/0x40 [i915]
         simple_attr_write_xsigned.constprop.0+0xb4/0x110
         full_proxy_write+0x52/0x80
         vfs_write+0xc5/0x4f0
         ksys_write+0x64/0xe0
         do_syscall_64+0x3c/0x90
         entry_SYSCALL_64_after_hwframe+0x72/0xdc

other info that might help us debug this:

  Chain exists of:
   (work_completion)(&(&guc->timestamp.work)->work) --> fs_reclaim --> &gt->reset.mutex
   Possible unsafe locking scenario:
         CPU0                    CPU1
         ----                    ----
    lock(&gt->reset.mutex);
                                 lock(fs_reclaim);
                                 lock(&gt->reset.mutex);
    lock((work_completion)(&(&guc->timestamp.work)->work));

*** DEADLOCK ***
3 locks held by kms_pipe_crc_ba/6415:

   #0: ffff888101541430 (sb_writers#15){.+.+}-{0:0}, at: ksys_write+0x64/0xe0
   #1: ffff888136c7eab8 (&attr->mutex){+.+.}-{3:3}, at: simple_attr_write_xsigned.constprop.0+0x47/0x110
   #2: ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

v2: Add sync flag to guc_cancel_busyness_worker to ensure reset path calls asynchronous cancel.
v3: Add sync flag to intel_guc_submission_disable to ensure reset path calls asynchronous cancel.

---
  .../gpu/drm/i915/gt/uc/intel_guc_submission.c   | 17 ++++++++++-------
  .../gpu/drm/i915/gt/uc/intel_guc_submission.h   |  2 +-
  drivers/gpu/drm/i915/gt/uc/intel_uc.c           |  4 ++--
  3 files changed, 13 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +10 -7
index a0e3ef1c65d2..ef4300246ce1 100644
@@ -1357,9 +1357,12 @@ static void guc_enable_busyness_worker(struct intel_guc *guc)
  	mod_delayed_work(system_highpri_wq, &guc->timestamp.work, guc->timestamp.ping_delay);
  }
 
-static void guc_cancel_busyness_worker(struct intel_guc *guc)
+static void guc_cancel_busyness_worker(struct intel_guc *guc, bool sync)
  {
-	cancel_delayed_work_sync(&guc->timestamp.work);
+	if (sync)
+		cancel_delayed_work_sync(&guc->timestamp.work);
+	else
+		cancel_delayed_work(&guc->timestamp.work);
  }
 
  static void __reset_guc_busyness_stats(struct intel_guc *guc)
@@ -1370,7 +1373,7 @@ static void __reset_guc_busyness_stats(struct intel_guc *guc)
  	unsigned long flags;
  	ktime_t unused;
 
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, false);
 
  	spin_lock_irqsave(&guc->timestamp.lock, flags);
 
@@ -1485,7 +1488,7 @@ static int guc_init_engine_stats(struct intel_guc *guc)
 
  static void guc_fini_engine_stats(struct intel_guc *guc)
  {
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, true);
  }
 
  void intel_guc_busyness_park(struct intel_gt *gt)
@@ -1500,7 +1503,7 @@ void intel_guc_busyness_park(struct intel_gt *gt)
  	 * and causes an unclaimed register access warning. Cancel the worker
  	 * synchronously here.
  	 */
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, true);
 
  	/*
  	 * Before parking, we should sample engine busyness stats if we need to.
@@ -4501,9 +4504,9 @@ int intel_guc_submission_enable(struct intel_guc *guc)
  }
 
  /* Note: By the time we're here, GuC may have already been reset */
-void intel_guc_submission_disable(struct intel_guc *guc)
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync)
  {
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, sync);
 
  	/* Semaphore interrupt disable and route to host */
  	guc_route_semaphores(guc, false);
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h +1 -1
index c57b29cdb1a6..a77de0d6ed58 100644
@@ -16,7 +16,7 @@ struct intel_engine_cs;
  void intel_guc_submission_init_early(struct intel_guc *guc);
  int intel_guc_submission_init(struct intel_guc *guc);
  int intel_guc_submission_enable(struct intel_guc *guc);
-void intel_guc_submission_disable(struct intel_guc *guc);
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync);
  void intel_guc_submission_fini(struct intel_guc *guc);
  int intel_guc_preempt_work_create(struct intel_guc *guc);
  void intel_guc_preempt_work_destroy(struct intel_guc *guc);
drivers/gpu/drm/i915/gt/uc/intel_uc.c +2 -2
index 18250fb64bd8..edf13f89830e 100644
@@ -566,7 +566,7 @@ static int __uc_init_hw(struct intel_uc *uc)
  	 * We've failed to load the firmware :(
  	 */
  err_submission:
-	intel_guc_submission_disable(guc);
+	intel_guc_submission_disable(guc, true);
  err_log_capture:
  	__uc_capture_load_err_log(uc);
  err_rps:
@@ -597,7 +597,7 @@ static void __uc_fini_hw(struct intel_uc *uc)
  		return;
 
  	if (intel_uc_uses_guc_submission(uc))
-		intel_guc_submission_disable(guc);
+		intel_guc_submission_disable(guc, false);
 
  	__uc_sanitize(uc);
  }
#2 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev3)

In reply to Zhanjun Dong
== Series Details ==

== Series Details ==

Series: drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev3)
URL : https://patchwork.freedesktop.org/series/118898/
State : warning

== Summary ==

Error: dim checkpatch failed
b11466545138 drm/i915: Avoid circular locking dependency when flush delayed work on gt reset -:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7:
This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset.

total: 0 errors, 1 warnings, 0 checks, 73 lines checked

#3 lore raw

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev3)

In reply to Zhanjun Dong
== Series Details ==

== Series Details ==

Series: drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev3)
URL : https://patchwork.freedesktop.org/series/118898/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.

#4 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev3)

In reply to Zhanjun Dong
== Series Details ==

== Series Details ==

Series: drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev3)
URL : https://patchwork.freedesktop.org/series/118898/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13276 -> Patchwork_118898v3
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/index.html

Participating hosts (38 -> 40)
------------------------------

Additional (3): fi-blb-e6850 fi-bsw-nick fi-bsw-n3050
Missing (1): fi-snb-2520m

Known issues
------------

Here are the changes found in Patchwork_118898v3 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_lmem_swapping@basic:
- bat-adln-1: NOTRUN -> [SKIP][1] ([i915#4613]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-adln-1/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-bsw-nick: NOTRUN -> [SKIP][2] ([fdo#109271]) +51 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/fi-bsw-nick/igt@[email protected]
- bat-rplp-1: NOTRUN -> [SKIP][3] ([i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-rplp-1/igt@[email protected]

* igt@gem_lmem_swapping@random-engines:
- fi-bsw-n3050: NOTRUN -> [SKIP][4] ([fdo#109271]) +25 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/fi-bsw-n3050/igt@[email protected]
- bat-adlp-6: NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-adlp-6/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-blb-e6850: NOTRUN -> [SKIP][6] ([fdo#109271]) +37 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/fi-blb-e6850/igt@[email protected]

* igt@i915_pm_rps@basic-api:
- bat-adlp-6: NOTRUN -> [SKIP][7] ([i915#6621])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-adlp-6/igt@[email protected]
- bat-rplp-1: NOTRUN -> [SKIP][8] ([i915#6621])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-rplp-1/igt@[email protected]
- bat-adln-1: NOTRUN -> [SKIP][9] ([i915#6621])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-adln-1/igt@[email protected]

* igt@i915_selftest@live@requests:
- bat-mtlp-6: [PASS][10] -> [DMESG-FAIL][11] ([i915#8497])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/bat-mtlp-6/igt@i915_selftest@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-mtlp-6/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@slpc:
- bat-rpls-1: [PASS][12] -> [DMESG-WARN][13] ([i915#6367])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/bat-rpls-1/igt@i915_selftest@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- bat-adlp-6: NOTRUN -> [ABORT][14] ([i915#8210])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-adlp-6/igt@[email protected]

* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-rplp-1: NOTRUN -> [SKIP][15] ([i915#7828])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-rplp-1/igt@[email protected]
- bat-adln-1: NOTRUN -> [SKIP][16] ([i915#7828])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-adln-1/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-hdmi-a-2:
- fi-bsw-n3050: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#4579]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/fi-bsw-n3050/igt@kms_pipe_crc_basic@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][18] ([i915#1845] / [i915#5354]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-dg2-11/igt@[email protected]

* igt@kms_setmode@basic-clone-single-crtc:
- fi-bsw-nick: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#4579])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/fi-bsw-nick/igt@[email protected]
- bat-adlp-6: NOTRUN -> [SKIP][20] ([i915#3555] / [i915#4579])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-adlp-6/igt@[email protected]
- bat-adln-1: NOTRUN -> [SKIP][21] ([i915#3555] / [i915#4579])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-adln-1/igt@[email protected]
- fi-blb-e6850: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#4579])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/fi-blb-e6850/igt@[email protected]

* igt@prime_vgem@basic-fence-read:
- bat-adlp-6: NOTRUN -> [SKIP][23] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-adlp-6/igt@[email protected]

* igt@prime_vgem@basic-read:
- bat-rplp-1: NOTRUN -> [SKIP][24] ([i915#3708]) +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-rplp-1/igt@[email protected]

* igt@prime_vgem@basic-write:
- bat-adln-1: NOTRUN -> [SKIP][25] ([fdo#109295] / [i915#3291]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-adln-1/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@gt_mocs:
- bat-mtlp-6: [DMESG-FAIL][26] ([i915#7059]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html

* igt@i915_selftest@live@slpc:
- bat-mtlp-6: [DMESG-WARN][28] ([i915#6367]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/bat-mtlp-6/igt@i915_selftest@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-mtlp-6/igt@i915_selftest@[email protected]
- bat-rpls-2: [DMESG-WARN][30] ([i915#6367]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/bat-rpls-2/igt@i915_selftest@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-rpls-2/igt@i915_selftest@[email protected]

* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-a-edp-1:
- bat-adlp-6: [ABORT][32] ([i915#7977] / [i915#8434]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/bat-adlp-6/igt@kms_pipe_crc_basic@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-adlp-6/igt@kms_pipe_crc_basic@[email protected]

* igt@kms_psr@sprite_plane_onoff:
- bat-adln-1: [ABORT][34] ([i915#8442]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/bat-adln-1/igt@kms_psr@sprite_plane_onoff.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-adln-1/igt@kms_psr@sprite_plane_onoff.html

#### Warnings ####

* igt@kms_setmode@basic-clone-single-crtc:
- bat-rplp-1: [ABORT][36] ([i915#4579] / [i915#8260]) -> [SKIP][37] ([i915#3555] / [i915#4579])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/bat-rplp-1/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/bat-rplp-1/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7977]: https://gitlab.freedesktop.org/drm/intel/issues/7977
[i915#8210]: https://gitlab.freedesktop.org/drm/intel/issues/8210
[i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260
[i915#8434]: https://gitlab.freedesktop.org/drm/intel/issues/8434
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497

Build changes
-------------

* Linux: CI_DRM_13276 -> Patchwork_118898v3

CI-20190529: 20190529
CI_DRM_13276: afe49e3c604f9690c9d499185149f83bd259601c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7332: 2a25a6109e8af4b0a69a717cc8710dcafed4bb4c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118898v3: afe49e3c604f9690c9d499185149f83bd259601c @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

4ca34cf0fe78 drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/index.html

#5 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev3)

In reply to Zhanjun Dong
== Series Details ==

== Series Details ==

Series: drm/i915: Avoid circular locking dependency when flush delayed work on gt reset (rev3)
URL : https://patchwork.freedesktop.org/series/118898/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13276_full -> Patchwork_118898v3_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_118898v3_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_118898v3_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (7 -> 7)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_118898v3_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_softpin@noreloc:
- shard-glk: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-glk7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-glk6/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_118898v3_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@drm_fdinfo@most-busy-check-all@rcs0:
- shard-rkl: [PASS][3] -> [FAIL][4] ([i915#7742])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-rkl-2/igt@drm_fdinfo@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-rkl-4/igt@drm_fdinfo@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-glk: [PASS][5] -> [ABORT][6] ([i915#5566])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-glk2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-glk8/igt@[email protected]

* igt@i915_pm_dc@dc9-dpms:
- shard-tglu: [PASS][7] -> [SKIP][8] ([i915#4281])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-tglu-9/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-tglu-3/igt@[email protected]

* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-rkl: [PASS][9] -> [SKIP][10] ([i915#1397]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-rkl-1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-rkl-7/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#2346])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-glk1/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-glk7/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][13] -> [FAIL][14] ([i915#2346])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

* igt@kms_cursor_legacy@single-move@pipe-b:
- shard-rkl: [PASS][15] -> [INCOMPLETE][16] ([i915#8011]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-rkl-4/igt@kms_cursor_legacy@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-rkl-7/igt@kms_cursor_legacy@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#79])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-glk2/igt@kms_flip@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-glk8/igt@kms_flip@[email protected]

* igt@kms_hdr@invalid-hdr:
- shard-rkl: NOTRUN -> [SKIP][19] ([i915#4579] / [i915#6953] / [i915#8228])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-rkl-7/igt@[email protected]

* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [FAIL][20] ([i915#8292])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-rkl-2/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#4579]) +10 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-snb1/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-hdmi-a-1.html

* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][22] ([i915#4579] / [i915#5176]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-rkl-7/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-upscale-with-rotation-20x20@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][23] ([i915#5176]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-rkl-6/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][24] ([i915#5235]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-rkl-4/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][25] ([i915#4579] / [i915#5235]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-rkl-2/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][26] ([fdo#109271]) +19 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-snb1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-hdmi-a-1.html

* igt@kms_setmode@basic@pipe-a-vga-1:
- shard-snb: NOTRUN -> [FAIL][27] ([i915#5465]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-snb5/igt@kms_setmode@[email protected]

#### Possible fixes ####

* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- shard-rkl: [FAIL][28] ([i915#7742]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-rkl-2/igt@drm_fdinfo@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-rkl-6/igt@drm_fdinfo@[email protected]

* igt@gem_ctx_exec@basic-nohangcheck:
- shard-rkl: [FAIL][30] ([i915#6268]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-rkl-3/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-rkl-1/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][32] ([i915#2846]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-glk5/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-glk9/igt@[email protected]

* igt@gem_exec_fair@basic-none@bcs0:
- shard-rkl: [FAIL][34] ([i915#2842]) -> [PASS][35] +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-rkl-4/igt@gem_exec_fair@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-rkl-2/igt@gem_exec_fair@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- {shard-dg1}: [FAIL][36] ([i915#3591]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-dg1-19/igt@i915_pm_rc6_residency@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-dg1-16/igt@i915_pm_rc6_residency@[email protected]

* igt@i915_pm_rpm@dpms-lpsp:
- shard-rkl: [SKIP][38] ([i915#1397]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-rkl-6/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-rkl-7/igt@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- shard-rkl: [FAIL][40] ([fdo#103375]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-rkl-3/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-rkl-7/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [FAIL][42] ([i915#2346]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-apl4/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-apl3/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-glk: [FAIL][44] ([i915#2346]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

* igt@kms_cursor_legacy@forked-move@pipe-b:
- shard-rkl: [INCOMPLETE][46] ([i915#8011]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-rkl-7/igt@kms_cursor_legacy@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-rkl-6/igt@kms_cursor_legacy@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
- shard-glk: [FAIL][48] ([i915#79]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-glk2/igt@kms_flip@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-glk8/igt@kms_flip@[email protected]

#### Warnings ####

* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-tglu: [WARN][50] ([i915#2681]) -> [FAIL][51] ([i915#2681] / [i915#3591])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13276/shard-tglu-4/igt@i915_pm_rc6_residency@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/shard-tglu-6/igt@i915_pm_rc6_residency@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347

Build changes
-------------

* Linux: CI_DRM_13276 -> Patchwork_118898v3

CI-20190529: 20190529
CI_DRM_13276: afe49e3c604f9690c9d499185149f83bd259601c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7332: 2a25a6109e8af4b0a69a717cc8710dcafed4bb4c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118898v3: afe49e3c604f9690c9d499185149f83bd259601c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118898v3/index.html

Acked-by on v3 1/1
#6 lore raw
In reply to Zhanjun Dong

Hi,

Quoted 102 lines · Zhanjun Dong

This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset.
Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync version for reset path, it is safe as the worker has the trylock code to handle the lock; Meanwhile keep the sync version for park/fini to ensure the worker is not still running during suspend or shutdown.

WARNING: possible circular locking dependency detected 6.4.0-rc1-drmtip_1340-g31e3463b0edb+ #1 Not tainted
------------------------------------------------------
kms_pipe_crc_ba/6415 is trying to acquire lock:
ffff88813e6cc640 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}, at: __flush_work+0x42/0x530

but task is already holding lock:
ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #3 (&gt->reset.mutex){+.+.}-{3:3}:

        lock_acquire+0xd8/0x2d0
        i915_gem_shrinker_taints_mutex+0x31/0x50 [i915]
        intel_gt_init_reset+0x65/0x80 [i915]
        intel_gt_common_init_early+0xe1/0x170 [i915]
        intel_root_gt_init_early+0x48/0x60 [i915]
        i915_driver_probe+0x671/0xcb0 [i915]
        i915_pci_probe+0xdc/0x210 [i915]
        pci_device_probe+0x95/0x120
        really_probe+0x164/0x3c0
        __driver_probe_device+0x73/0x160
        driver_probe_device+0x19/0xa0
        __driver_attach+0xb6/0x180
        bus_for_each_dev+0x77/0xd0
        bus_add_driver+0x114/0x210
        driver_register+0x5b/0x110
        __pfx_vgem_open+0x3/0x10 [vgem]
        do_one_initcall+0x57/0x270
        do_init_module+0x5f/0x220
        load_module+0x1ca4/0x1f00
        __do_sys_finit_module+0xb4/0x130
        do_syscall_64+0x3c/0x90
        entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #2 (fs_reclaim){+.+.}-{0:0}:

        lock_acquire+0xd8/0x2d0
        fs_reclaim_acquire+0xac/0xe0
        kmem_cache_alloc+0x32/0x260
        i915_vma_instance+0xb2/0xc60 [i915]
        i915_gem_object_ggtt_pin_ww+0x175/0x370 [i915]
        vm_fault_gtt+0x22d/0xf60 [i915]
        __do_fault+0x2f/0x1d0
        do_pte_missing+0x4a/0xd20
        __handle_mm_fault+0x5b0/0x790
        handle_mm_fault+0xa2/0x230
        do_user_addr_fault+0x3ea/0xa10
        exc_page_fault+0x68/0x1a0
        asm_exc_page_fault+0x26/0x30

-> #1 (&gt->reset.backoff_srcu){++++}-{0:0}:

        lock_acquire+0xd8/0x2d0
        _intel_gt_reset_lock+0x57/0x330 [i915]
        guc_timestamp_ping+0x35/0x130 [i915]
        process_one_work+0x250/0x510
        worker_thread+0x4f/0x3a0
        kthread+0xff/0x130
        ret_from_fork+0x29/0x50

-> #0 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}:

        check_prev_add+0x90/0xc60
        __lock_acquire+0x1998/0x2590
        lock_acquire+0xd8/0x2d0
        __flush_work+0x74/0x530
        __cancel_work_timer+0x14f/0x1f0
        intel_guc_submission_reset_prepare+0x81/0x4b0 [i915]
        intel_uc_reset_prepare+0x9c/0x120 [i915]
        reset_prepare+0x21/0x60 [i915]
        intel_gt_reset+0x1dd/0x470 [i915]
        intel_gt_reset_global+0xfb/0x170 [i915]
        intel_gt_handle_error+0x368/0x420 [i915]
        intel_gt_debugfs_reset_store+0x5c/0xc0 [i915]
        i915_wedged_set+0x29/0x40 [i915]
        simple_attr_write_xsigned.constprop.0+0xb4/0x110
        full_proxy_write+0x52/0x80
        vfs_write+0xc5/0x4f0
        ksys_write+0x64/0xe0
        do_syscall_64+0x3c/0x90
        entry_SYSCALL_64_after_hwframe+0x72/0xdc

other info that might help us debug this:

 Chain exists of:
  (work_completion)(&(&guc->timestamp.work)->work) --> fs_reclaim --> &gt->reset.mutex
  Possible unsafe locking scenario:
        CPU0                    CPU1
        ----                    ----
   lock(&gt->reset.mutex);
                                lock(fs_reclaim);
                                lock(&gt->reset.mutex);
   lock((work_completion)(&(&guc->timestamp.work)->work));

*** DEADLOCK ***
3 locks held by kms_pipe_crc_ba/6415:
#0: ffff888101541430 (sb_writers#15){.+.+}-{0:0}, at: ksys_write+0x64/0xe0
#1: ffff888136c7eab8 (&attr->mutex){+.+.}-{3:3}, at: simple_attr_write_xsigned.constprop.0+0x47/0x110 #2: ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

Quoted 4 lines

v2: Add sync flag to guc_cancel_busyness_worker to ensure reset path calls asynchronous cancel.
v3: Add sync flag to intel_guc_submission_disable to ensure reset path calls asynchronous cancel.

Any further comment on this?

Andi

Quoted 101 lines
---
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c   | 17 ++++++++++-------
 .../gpu/drm/i915/gt/uc/intel_guc_submission.h   |  2 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc.c           |  4 ++--
 3 files changed, 13 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +10 -7
index a0e3ef1c65d2..ef4300246ce1 100644
@@ -1357,9 +1357,12 @@ static void guc_enable_busyness_worker(struct intel_guc *guc)
 	mod_delayed_work(system_highpri_wq, &guc->timestamp.work, guc->timestamp.ping_delay);
 }
 
-static void guc_cancel_busyness_worker(struct intel_guc *guc)
+static void guc_cancel_busyness_worker(struct intel_guc *guc, bool sync)
 {
-	cancel_delayed_work_sync(&guc->timestamp.work);
+	if (sync)
+		cancel_delayed_work_sync(&guc->timestamp.work);
+	else
+		cancel_delayed_work(&guc->timestamp.work);
 }
 
 static void __reset_guc_busyness_stats(struct intel_guc *guc)
@@ -1370,7 +1373,7 @@ static void __reset_guc_busyness_stats(struct intel_guc *guc)
 	unsigned long flags;
 	ktime_t unused;
 
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, false);
 
 	spin_lock_irqsave(&guc->timestamp.lock, flags);
 
@@ -1485,7 +1488,7 @@ static int guc_init_engine_stats(struct intel_guc *guc)
 
 static void guc_fini_engine_stats(struct intel_guc *guc)
 {
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, true);
 }
 
 void intel_guc_busyness_park(struct intel_gt *gt)
@@ -1500,7 +1503,7 @@ void intel_guc_busyness_park(struct intel_gt *gt)
 	 * and causes an unclaimed register access warning. Cancel the worker
 	 * synchronously here.
 	 */
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, true);
 
 	/*
 	 * Before parking, we should sample engine busyness stats if we need to.
@@ -4501,9 +4504,9 @@ int intel_guc_submission_enable(struct intel_guc *guc)
 }
 
 /* Note: By the time we're here, GuC may have already been reset */
-void intel_guc_submission_disable(struct intel_guc *guc)
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync)
 {
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, sync);
 
 	/* Semaphore interrupt disable and route to host */
 	guc_route_semaphores(guc, false);
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h +1 -1
index c57b29cdb1a6..a77de0d6ed58 100644
@@ -16,7 +16,7 @@ struct intel_engine_cs;
 void intel_guc_submission_init_early(struct intel_guc *guc);
 int intel_guc_submission_init(struct intel_guc *guc);
 int intel_guc_submission_enable(struct intel_guc *guc);
-void intel_guc_submission_disable(struct intel_guc *guc);
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync);
 void intel_guc_submission_fini(struct intel_guc *guc);
 int intel_guc_preempt_work_create(struct intel_guc *guc);
 void intel_guc_preempt_work_destroy(struct intel_guc *guc);
drivers/gpu/drm/i915/gt/uc/intel_uc.c +2 -2
index 18250fb64bd8..edf13f89830e 100644
@@ -566,7 +566,7 @@ static int __uc_init_hw(struct intel_uc *uc)
 	 * We've failed to load the firmware :(
 	 */
 err_submission:
-	intel_guc_submission_disable(guc);
+	intel_guc_submission_disable(guc, true);
 err_log_capture:
 	__uc_capture_load_err_log(uc);
 err_rps:
@@ -597,7 +597,7 @@ static void __uc_fini_hw(struct intel_uc *uc)
 		return;
 
 	if (intel_uc_uses_guc_submission(uc))
-		intel_guc_submission_disable(guc);
+		intel_guc_submission_disable(guc, false);
 
 	__uc_sanitize(uc);
 }
Signature · 1 line
2.34.1
#7 lore raw
In reply to Zhanjun Dong
Quoted 197 lines · Zhanjun Dong

This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset.
Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync version for reset path, it is safe as the worker has the trylock code to handle the lock; Meanwhile keep the sync version for park/fini to ensure the worker is not still running during suspend or shutdown.

WARNING: possible circular locking dependency detected 6.4.0-rc1-drmtip_1340-g31e3463b0edb+ #1 Not tainted
------------------------------------------------------
kms_pipe_crc_ba/6415 is trying to acquire lock:
ffff88813e6cc640 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}, at: __flush_work+0x42/0x530

but task is already holding lock:
ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #3 (&gt->reset.mutex){+.+.}-{3:3}:

         lock_acquire+0xd8/0x2d0
         i915_gem_shrinker_taints_mutex+0x31/0x50 [i915]
         intel_gt_init_reset+0x65/0x80 [i915]
         intel_gt_common_init_early+0xe1/0x170 [i915]
         intel_root_gt_init_early+0x48/0x60 [i915]
         i915_driver_probe+0x671/0xcb0 [i915]
         i915_pci_probe+0xdc/0x210 [i915]
         pci_device_probe+0x95/0x120
         really_probe+0x164/0x3c0
         __driver_probe_device+0x73/0x160
         driver_probe_device+0x19/0xa0
         __driver_attach+0xb6/0x180
         bus_for_each_dev+0x77/0xd0
         bus_add_driver+0x114/0x210
         driver_register+0x5b/0x110
         __pfx_vgem_open+0x3/0x10 [vgem]
         do_one_initcall+0x57/0x270
         do_init_module+0x5f/0x220
         load_module+0x1ca4/0x1f00
         __do_sys_finit_module+0xb4/0x130
         do_syscall_64+0x3c/0x90
         entry_SYSCALL_64_after_hwframe+0x72/0xdc

-> #2 (fs_reclaim){+.+.}-{0:0}:

         lock_acquire+0xd8/0x2d0
         fs_reclaim_acquire+0xac/0xe0
         kmem_cache_alloc+0x32/0x260
         i915_vma_instance+0xb2/0xc60 [i915]
         i915_gem_object_ggtt_pin_ww+0x175/0x370 [i915]
         vm_fault_gtt+0x22d/0xf60 [i915]
         __do_fault+0x2f/0x1d0
         do_pte_missing+0x4a/0xd20
         __handle_mm_fault+0x5b0/0x790
         handle_mm_fault+0xa2/0x230
         do_user_addr_fault+0x3ea/0xa10
         exc_page_fault+0x68/0x1a0
         asm_exc_page_fault+0x26/0x30

-> #1 (&gt->reset.backoff_srcu){++++}-{0:0}:

         lock_acquire+0xd8/0x2d0
         _intel_gt_reset_lock+0x57/0x330 [i915]
         guc_timestamp_ping+0x35/0x130 [i915]
         process_one_work+0x250/0x510
         worker_thread+0x4f/0x3a0
         kthread+0xff/0x130
         ret_from_fork+0x29/0x50

-> #0 ((work_completion)(&(&guc->timestamp.work)->work)){+.+.}-{0:0}:

         check_prev_add+0x90/0xc60
         __lock_acquire+0x1998/0x2590
         lock_acquire+0xd8/0x2d0
         __flush_work+0x74/0x530
         __cancel_work_timer+0x14f/0x1f0
         intel_guc_submission_reset_prepare+0x81/0x4b0 [i915]
         intel_uc_reset_prepare+0x9c/0x120 [i915]
         reset_prepare+0x21/0x60 [i915]
         intel_gt_reset+0x1dd/0x470 [i915]
         intel_gt_reset_global+0xfb/0x170 [i915]
         intel_gt_handle_error+0x368/0x420 [i915]
         intel_gt_debugfs_reset_store+0x5c/0xc0 [i915]
         i915_wedged_set+0x29/0x40 [i915]
         simple_attr_write_xsigned.constprop.0+0xb4/0x110
         full_proxy_write+0x52/0x80
         vfs_write+0xc5/0x4f0
         ksys_write+0x64/0xe0
         do_syscall_64+0x3c/0x90
         entry_SYSCALL_64_after_hwframe+0x72/0xdc

other info that might help us debug this:

  Chain exists of:
   (work_completion)(&(&guc->timestamp.work)->work) --> fs_reclaim --> &gt->reset.mutex
   Possible unsafe locking scenario:
         CPU0                    CPU1
         ----                    ----
    lock(&gt->reset.mutex);
                                 lock(fs_reclaim);
                                 lock(&gt->reset.mutex);
    lock((work_completion)(&(&guc->timestamp.work)->work));

*** DEADLOCK ***
3 locks held by kms_pipe_crc_ba/6415:

   #0: ffff888101541430 (sb_writers#15){.+.+}-{0:0}, at: ksys_write+0x64/0xe0
   #1: ffff888136c7eab8 (&attr->mutex){+.+.}-{3:3}, at: simple_attr_write_xsigned.constprop.0+0x47/0x110
   #2: ffff88813e6cce90 (&gt->reset.mutex){+.+.}-{3:3}, at: intel_gt_reset+0x19e/0x470 [i915]

v2: Add sync flag to guc_cancel_busyness_worker to ensure reset path calls asynchronous cancel.
v3: Add sync flag to intel_guc_submission_disable to ensure reset path calls asynchronous cancel.

---
  .../gpu/drm/i915/gt/uc/intel_guc_submission.c   | 17 ++++++++++-------
  .../gpu/drm/i915/gt/uc/intel_guc_submission.h   |  2 +-
  drivers/gpu/drm/i915/gt/uc/intel_uc.c           |  4 ++--
  3 files changed, 13 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +10 -7
index a0e3ef1c65d2..ef4300246ce1 100644
@@ -1357,9 +1357,12 @@ static void guc_enable_busyness_worker(struct intel_guc *guc)
  	mod_delayed_work(system_highpri_wq, &guc->timestamp.work, guc->timestamp.ping_delay);
  }
 
-static void guc_cancel_busyness_worker(struct intel_guc *guc)
+static void guc_cancel_busyness_worker(struct intel_guc *guc, bool sync)
  {
-	cancel_delayed_work_sync(&guc->timestamp.work);
+	if (sync)
+		cancel_delayed_work_sync(&guc->timestamp.work);
+	else
+		cancel_delayed_work(&guc->timestamp.work);
  }
 
  static void __reset_guc_busyness_stats(struct intel_guc *guc)
@@ -1370,7 +1373,7 @@ static void __reset_guc_busyness_stats(struct intel_guc *guc)
  	unsigned long flags;
  	ktime_t unused;
 
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, false);
 
  	spin_lock_irqsave(&guc->timestamp.lock, flags);
 
@@ -1485,7 +1488,7 @@ static int guc_init_engine_stats(struct intel_guc *guc)
 
  static void guc_fini_engine_stats(struct intel_guc *guc)
  {
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, true);
  }
 
  void intel_guc_busyness_park(struct intel_gt *gt)
@@ -1500,7 +1503,7 @@ void intel_guc_busyness_park(struct intel_gt *gt)
  	 * and causes an unclaimed register access warning. Cancel the worker
  	 * synchronously here.
  	 */
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, true);
 
  	/*
  	 * Before parking, we should sample engine busyness stats if we need to.
@@ -4501,9 +4504,9 @@ int intel_guc_submission_enable(struct intel_guc *guc)
  }
 
  /* Note: By the time we're here, GuC may have already been reset */
-void intel_guc_submission_disable(struct intel_guc *guc)
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync)
  {
-	guc_cancel_busyness_worker(guc);
+	guc_cancel_busyness_worker(guc, sync);
 
  	/* Semaphore interrupt disable and route to host */
  	guc_route_semaphores(guc, false);
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h +1 -1
index c57b29cdb1a6..a77de0d6ed58 100644
@@ -16,7 +16,7 @@ struct intel_engine_cs;
  void intel_guc_submission_init_early(struct intel_guc *guc);
  int intel_guc_submission_init(struct intel_guc *guc);
  int intel_guc_submission_enable(struct intel_guc *guc);
-void intel_guc_submission_disable(struct intel_guc *guc);
+void intel_guc_submission_disable(struct intel_guc *guc, bool sync);
  void intel_guc_submission_fini(struct intel_guc *guc);
  int intel_guc_preempt_work_create(struct intel_guc *guc);
  void intel_guc_preempt_work_destroy(struct intel_guc *guc);
drivers/gpu/drm/i915/gt/uc/intel_uc.c +1 -1
index 18250fb64bd8..edf13f89830e 100644
@@ -566,7 +566,7 @@ static int __uc_init_hw(struct intel_uc *uc)
  	 * We've failed to load the firmware :(
  	 */
  err_submission:
-	intel_guc_submission_disable(guc);
+	intel_guc_submission_disable(guc, true);
  err_log_capture:
  	__uc_capture_load_err_log(uc);
  err_rps:

drivers/gpu/drm/i915/gt/uc/intel_uc.c static void __uc_fini_hw(struct intel_uc *uc) · line 600

Quoted 5 lines
drivers/gpu/drm/i915/gt/uc/intel_uc.c +1 -1
@@ -597,7 +597,7 @@ static void __uc_fini_hw(struct intel_uc *uc)
  		return;
 
  	if (intel_uc_uses_guc_submission(uc))
-		intel_guc_submission_disable(guc);
+		intel_guc_submission_disable(guc, false);

This one is potentially a problem.

AFAICT, '__uc_fini_hw' is actually becomes 'intel_uc_fini_hw' (through the magick of UC macro-ised function declarations!). And that is only called from the bail out error path of GT init and the driver remove path. Both of those should be synchronous waits to ensure that the worker is guaranteed gone before unloading the driver. However, the GT init path is presumably called as part of a full GT reset. And in theory, it could fail (e.g. because the hardware is toast and hence the reset in the first place). And in that case, it needs to be the async cancel.

One option would be to pass a 'in reset' flag all the way through the GT init path, but that sounds really intrusive and messy. The simpler alternative would be to make this always synchronous and just accept that the circular locking warning may occur in exceedingly rare cases. Again, the circular lock detection is bogus because we have the early exit in the case of a locked mutex. So it is not an actual problem. In which case, living with the warning in the super rare case of a failed GT reset seems acceptable to me.

John.

Quoted 3 lines
drivers/gpu/drm/i915/gt/uc/intel_uc.c +0 -0
  	__uc_sanitize(uc);
  }