memory tiering: calculate abstract distance based on ACPI HMAT
Subsystems (4)
cover memory tiering: calculate abstract distance based on ACPI HMAT
We have the explicit memory tiers framework to manage systems with multiple types of memory, e.g., DRAM in DIMM slots and CXL memory devices. Where, same kind of memory devices will be grouped into memory types, then put into memory tiers. To describe the performance of a memory type, abstract distance is defined. Which is in direct proportion to the memory latency and inversely proportional to the memory bandwidth. To keep the code as simple as possible, fixed abstract distance is used in dax/kmem to describe slow memory such as Optane DCPMM.
To support more memory types, in this series, we added the abstract distance calculation algorithm management mechanism, provided a algorithm implementation based on ACPI HMAT, and used the general abstract distance calculation interface in dax/kmem driver. So, dax/kmem can support HBM (high bandwidth memory) in addition to the original Optane DCPMM.
Best Regards,
Huang, Ying
RFC 1/4 memory tiering: add abstract distance calculation algorithms management
The abstract distance may be calculated by various drivers, such as ACPI HMAT, CXL CDAT, etc. While it may be used by various code which hot-add memory node, such as dax/kmem etc. To decouple the algorithm users and the providers, the abstract distance calculation algorithms management mechanism is implemented in this patch. It provides interface for the providers to register the implementation, and interface for the users.
Multiple algorithm implementations can cooperate via calculating abstract distance for different memory nodes. The preference of algorithm implementations can be specified via priority (notifier_block.priority).
--- include/linux/memory-tiers.h | 19 ++++++++++++ mm/memory-tiers.c | 59 ++++++++++++++++++++++++++++++++++++ 2 files changed, 78 insertions(+)
include/linux/memory-tiers.h +19 -0
@@ -6,6 +6,7 @@#include <linux/nodemask.h> #include <linux/kref.h> #include <linux/mmzone.h> +#include <linux/notifier.h> /* * Each tier cover a abstrace distance chunk size of 128 */
@@ -36,6 +37,9 @@ struct memory_dev_type *alloc_memory_type(int adistance);void destroy_memory_type (struct memory_dev_type *memtype);void init_node_memory_type (int node,struct memory_dev_type *default_type);void clear_node_memory_type (int node,struct memory_dev_type *memtype); +int register_mt_adistance_algorithm (struct notifier_block *nb); +int unregister_mt_adistance_algorithm (struct notifier_block *nb); +int mt_calc_adistance (int node,int *adist);#ifdef CONFIG_MIGRATION int next_demotion_node (int node);void node_get_allowed_targets (pg_data_t *pgdat,nodemask_t *targets);
@@ -97,5 +101,20 @@ static inline bool node_is_toptier(int node) {return true; } + +static inline int register_mt_adistance_algorithm (struct notifier_block *nb) +{ +return 0 ; +} + +static inline int unregister_mt_adistance_algorithm (struct notifier_block *nb) +{ +return 0 ; +} + +static inline int mt_calc_adistance (int node,int *adist) +{ +return NOTIFY_DONE ; +}#endif /* CONFIG_NUMA */ #endif /* _LINUX_MEMORY_TIERS_H */
mm/memory-tiers.c +59 -0
77 lines not on this page · raw message
Signature · 1 line
2.39.2
RFC 2/4 acpi, hmat: refactor hmat_register_target_initiators()
In reply to Huang YingPreviously, in hmat_register_target_initiators(), the performance attributes are calculated and the corresponding sysfs links and files are created too. Which is called during memory onlining.
But now, to calculate the abstract distance of a memory target before memory onlining, we need to calculate the performance attributes for a memory target without creating sysfs links and files.
To do that, hmat_register_target_initiators() is refactored to make it possible to calculate performance attributes separately.
--- drivers/acpi/numa/hmat.c | 81 +++++++++++++++------------------------- 1 file changed, 30 insertions(+), 51 deletions(-)
drivers/acpi/numa/hmat.c +30 -51
@@ -582,28 +582,25 @@ static int initiators_to_nodemask(unsigned long *p_nodes)return 0 ; } -static void hmat_register_target_initiators (struct memory_target *target) +static void hmat_update_target_attrs (struct memory_target *target, +unsigned long *p_nodes,int access) { - static DECLARE_BITMAP(p_nodes, MAX_NUMNODES);struct memory_initiator *initiator; -unsigned int mem_nid, cpu_nid; +unsigned int cpu_nid;struct memory_locality *loc =NULL ;u32 best =0 ; -bool access0done = false;int i; - mem_nid =pxm_to_node (target->memory_pxm); +bitmap_zero (p_nodes,MAX_NUMNODES );/* -* If the Address Range Structure provides a local processor pxm, link +* If the Address Range Structure provides a local processor pxm, set * only that one. Otherwise, find the best performance attributes and -* register all initiators that match. +* collect all initiators that match. */ if (target->processor_pxm !=PXM_INVAL ) { cpu_nid =pxm_to_node (target->processor_pxm); -register_memory_node_under_compute_node (mem_nid, cpu_nid,0 ); - access0done = true; -if (node_state (cpu_nid,N_CPU )) { -register_memory_node_under_compute_node (mem_nid, cpu_nid,1 ); +if (access ==0 ||node_state (cpu_nid,N_CPU )) { +set_bit (target->processor_pxm, p_nodes);return ; } }
@@ -617,47 +614,10 @@ static void hmat_register_target_initiators(struct memory_target *target)* We'll also use the sorting to prime the candidate nodes with known * initiators. */ -bitmap_zero (p_nodes,MAX_NUMNODES );list_sort (NULL , &initiators, initiator_cmp);if (initiators_to_nodemask (p_nodes) <0 )return ; -if (!access0done) { -for (i =WRITE_LATENCY ; i <=READ_BANDWIDTH ; i++) { - loc = localities_types[i]; -if (!loc) -continue ; - - best =0 ; -list_for_each_entry (initiator, &initiators, node) { -u32 value; - -if (!test_bit (initiator->processor_pxm, p_nodes)) -continue ; - - value =hmat_initiator_perf (target, initiator, - loc->hmat_loc); -if (hmat_update_best (loc->hmat_loc->data_type, value, &best)) -bitmap_clear (p_nodes,0 , initiator->processor_pxm); -if (value != best) -clear_bit (initiator->processor_pxm, p_nodes); - } -if (best) -hmat_update_target_access (target, loc->hmat_loc->data_type, - best,0 ); - } - -for_each_set_bit (i, p_nodes,MAX_NUMNODES ) { - cpu_nid =pxm_to_node (i); -register_memory_node_under_compute_node (mem_nid, cpu_nid,0 ); - } - } - -/* Access 1 ignores Generic Initiators */ -bitmap_zero (p_nodes,MAX_NUMNODES ); -if (initiators_to_nodemask (p_nodes) <0 ) -return ; -for (i =WRITE_LATENCY ; i <=READ_BANDWIDTH ; i++) { loc = localities_types[i];if (!loc)
@@ -667,7 +627,7 @@ static void hmat_register_target_initiators(struct memory_target *target)list_for_each_entry (initiator, &initiators, node) {u32 value; -if (!initiator->has_cpu) { +if (access ==1 && !initiator->has_cpu) {clear_bit (initiator->processor_pxm, p_nodes);continue ; }
@@ -681,14 +641,33 @@ static void hmat_register_target_initiators(struct memory_target *target)clear_bit (initiator->processor_pxm, p_nodes); }if (best) -hmat_update_target_access (target, loc->hmat_loc->data_type, best,1 ); +hmat_update_target_access (target, loc->hmat_loc->data_type, best, access); } +} + +static void __hmat_register_target_initiators (struct memory_target *target, +unsigned long *p_nodes, +int access) +{ +unsigned int mem_nid, cpu_nid; +int i; + + mem_nid =pxm_to_node (target->memory_pxm); +hmat_update_target_attrs (target, p_nodes, access);for_each_set_bit (i, p_nodes,MAX_NUMNODES ) { cpu_nid =pxm_to_node (i); -register_memory_node_under_compute_node (mem_nid, cpu_nid,1 ); +register_memory_node_under_compute_node (mem_nid, cpu_nid, access); } } +static void hmat_register_target_initiators (struct memory_target *target) +{ + static DECLARE_BITMAP(p_nodes, MAX_NUMNODES); + +__hmat_register_target_initiators (target, p_nodes,0 ); +__hmat_register_target_initiators (target, p_nodes,1 ); +} +static void hmat_register_target_cache (struct memory_target *target) {unsigned mem_nid =pxm_to_node (target->memory_pxm);
Signature · 1 line
2.39.2
RFC 3/4 acpi, hmat: calculate abstract distance with HMAT
In reply to Huang YingA memory tiering abstract distance calculation algorithm based on ACPI HMAT is implemented. The basic idea is as follows.
The performance attributes of system default DRAM nodes are recorded as the base line. Whose abstract distance is MEMTIER_ADISTANCE_DRAM. Then, the ratio of the abstract distance of a memory node (target) to MEMTIER_ADISTANCE_DRAM is scaled based on the ratio of the performance attributes of the node to that of the default DRAM nodes.
--- drivers/acpi/numa/hmat.c | 124 ++++++++++++++++++++++++++++++++++- include/linux/memory-tiers.h | 2 + mm/memory-tiers.c | 2 +- 3 files changed, 126 insertions(+), 2 deletions(-)
drivers/acpi/numa/hmat.c +123 -1
@@ -24,6 +24,7 @@#include <linux/node.h> #include <linux/sysfs.h> #include <linux/dax.h> +#include <linux/memory-tiers.h> static u8 hmat_revision;static int hmat_disable__initdata ;
@@ -759,6 +760,123 @@ static int hmat_callback(struct notifier_block *self,return NOTIFY_OK ; } +static int hmat_adistance_disabled; +static struct node_hmem_attrs default_dram_attrs; + +static void dump_hmem_attrs (struct node_hmem_attrs *attrs) +{ +pr_cont ("read_latency: %u, write_latency: %u, read_bandwidth: %u, write_bandwidth: %u\n" , + attrs->read_latency, attrs->write_latency, + attrs->read_bandwidth, attrs->write_bandwidth); +} + +static void disable_hmat_adistance_algorithm (void ) +{ + hmat_adistance_disabled = true; +} + +static int hmat_init_default_dram_attrs (void ) +{ +struct memory_target *target; +struct node_hmem_attrs *attrs; +int nid, pxm; +int nid_dram =NUMA_NO_NODE ; + +if (default_dram_attrs.read_latency + + default_dram_attrs.write_latency !=0 ) +return 0 ; + +if (!default_dram_type) +return -EIO ; + +for_each_node_mask (nid, default_dram_type->nodes) { + pxm =node_to_pxm (nid); + target =find_mem_target (pxm); +if (!target) +continue ; + attrs = &target->hmem_attrs[1 ]; +if (nid_dram ==NUMA_NO_NODE ) { +if (attrs->read_latency + attrs->write_latency ==0 || + attrs->read_bandwidth + attrs->write_bandwidth ==0 ) { +pr_info ("hmat: invalid hmem attrs for default DRAM node: %d,\n" , + nid); +pr_info (" " ); +dump_hmem_attrs (attrs); +pr_info (" disable hmat based abstract distance algorithm.\n" ); +disable_hmat_adistance_algorithm (); +return -EIO ; + } + nid_dram = nid; + default_dram_attrs = *attrs; +continue ; + } +if (abs (attrs->read_latency - default_dram_attrs.read_latency) *10 > + default_dram_attrs.read_latency || +abs (attrs->write_latency - default_dram_attrs.write_latency) *10 > + default_dram_attrs.write_latency || +abs (attrs->read_bandwidth - default_dram_attrs.read_bandwidth) *10 > + default_dram_attrs.read_bandwidth) { +pr_info ("hmat: hmem attrs for DRAM nodes mismatch.\n" ); +pr_info (" node %d:" , nid_dram); +dump_hmem_attrs (&default_dram_attrs); +pr_info (" node %d:" , nid); +dump_hmem_attrs (attrs); +pr_info (" disable hmat based abstract distance algorithm.\n" ); +disable_hmat_adistance_algorithm (); +return -EIO ; + } + } + +return 0 ; +} + +static int hmat_calculate_adistance (struct notifier_block *self, +unsigned long nid,void *data) +{ + static DECLARE_BITMAP(p_nodes, MAX_NUMNODES); +struct memory_target *target; +struct node_hmem_attrs *attrs; +int *adist = data; +int pxm; + +if (hmat_adistance_disabled) +return NOTIFY_OK ; + + pxm =node_to_pxm (nid); + target =find_mem_target (pxm); +if (!target) +return NOTIFY_OK ; + +if (hmat_init_default_dram_attrs ()) +return NOTIFY_OK ; + +mutex_lock (&target_lock); +hmat_update_target_attrs (target, p_nodes,1 ); +mutex_unlock (&target_lock); + + attrs = &target->hmem_attrs[1 ]; + +if (attrs->read_latency + attrs->write_latency ==0 || + attrs->read_bandwidth + attrs->write_bandwidth ==0 ) +return NOTIFY_OK ; + + *adist =MEMTIER_ADISTANCE_DRAM * + (attrs->read_latency + attrs->write_latency) / + (default_dram_attrs.read_latency + + default_dram_attrs.write_latency) * + (default_dram_attrs.read_bandwidth + + default_dram_attrs.write_bandwidth) / + (attrs->read_bandwidth + attrs->write_bandwidth); + +return NOTIFY_STOP ; +} + +static __meminitdata struct notifier_block hmat_adist_nb = +{ + .notifier_call = hmat_calculate_adistance, + .priority =100 , +}; +static __init void hmat_free_structures (void ) {struct memory_target *target, *tnext;
@@ -801,6 +919,7 @@ static __init int hmat_init(void)struct acpi_table_header *tbl;enum acpi_hmat_type i;acpi_status status; +int usage;if (srat_disabled () || hmat_disable)return 0 ;
@@ -841,8 +960,11 @@ static __init int hmat_init(void)hmat_register_targets ();/* Keep the table and structures if the notifier may use them */ -if (!hotplug_memory_notifier (hmat_callback,HMAT_CALLBACK_PRI )) + usage = !hotplug_memory_notifier (hmat_callback,HMAT_CALLBACK_PRI ); + usage += !register_mt_adistance_algorithm (&hmat_adist_nb); +if (usage)return 0 ; + out_put:hmat_free_structures ();acpi_put_table (tbl);
include/linux/memory-tiers.h +2 -0
@@ -33,6 +33,7 @@ struct memory_dev_type {#ifdef CONFIG_NUMA extern bool numa_demotion_enabled; +extern struct memory_dev_type *default_dram_type;struct memory_dev_type *alloc_memory_type (int adistance);void destroy_memory_type (struct memory_dev_type *memtype);void init_node_memory_type (int node,struct memory_dev_type *default_type);
@@ -64,6 +65,7 @@ static inline bool node_is_toptier(int node)#else #define numa_demotion_enabled false +#define default_dram_type NULL/* * CONFIG_NUMA implementation returns non NULL error. */
mm/memory-tiers.c +1 -1
@@ -37,7 +37,7 @@ struct node_memory_type_map {static DEFINE_MUTEX (memory_tier_lock);static LIST_HEAD (memory_tiers);static struct node_memory_type_map node_memory_types[MAX_NUMNODES ]; -static struct memory_dev_type *default_dram_type; +struct memory_dev_type *default_dram_type;static struct bus_type memory_tier_subsys = { .name ="memory_tiering" ,
Signature · 1 line
2.39.2
Re: [RFC 3/4] acpi, hmat: calculate abstract distance with HMAT
Quoted 98 lines · Huang Ying
A memory tiering abstract distance calculation algorithm based on ACPI HMAT is implemented. The basic idea is as follows.
The performance attributes of system default DRAM nodes are recorded as the base line. Whose abstract distance is
MEMTIER_ADISTANCE_DRAM. Then, the ratio of the abstract distance of a memory node (target) toMEMTIER_ADISTANCE_DRAMis scaled based on the ratio of the performance attributes of the node to that of the default DRAM nodes.Signed-off-by "Huang, Ying" <[email protected]>Cc Aneesh Kumar K.V <[email protected]>Cc Wei Xu <[email protected]>Cc Alistair Popple <[email protected]>Cc Dan Williams <[email protected]>Cc Dave Hansen <[email protected]>Cc Davidlohr Bueso <[email protected]>Cc Johannes Weiner <[email protected]>Cc Jonathan Cameron <[email protected]>Cc Michal Hocko <[email protected]>Cc Yang Shi <[email protected]>Cc Rafael J Wysocki <[email protected]>--- drivers/acpi/numa/hmat.c | 124 ++++++++++++++++++++++++++++++++++- include/linux/memory-tiers.h | 2 + mm/memory-tiers.c | 2 +- 3 files changed, 126 insertions(+), 2 deletions(-)drivers/acpi/numa/hmat.c +56
-0@@ -24,6 +24,7 @@#include <linux/node.h> #include <linux/sysfs.h> #include <linux/dax.h> +#include <linux/memory-tiers.h> static u8 hmat_revision;static int hmat_disable__initdata ;@@ -759,6 +760,123 @@ static int hmat_callback(struct notifier_block *self,return NOTIFY_OK ; } +static int hmat_adistance_disabled; +static struct node_hmem_attrs default_dram_attrs; + +static void dump_hmem_attrs (struct node_hmem_attrs *attrs) +{ +pr_cont ("read_latency: %u, write_latency: %u, read_bandwidth: %u, write_bandwidth: %u\n" , + attrs->read_latency, attrs->write_latency, + attrs->read_bandwidth, attrs->write_bandwidth); +} + +static void disable_hmat_adistance_algorithm (void ) +{ + hmat_adistance_disabled = true; +} + +static int hmat_init_default_dram_attrs(void) +{ + struct memory_target *target; + struct node_hmem_attrs *attrs; + int nid, pxm; + int nid_dram = NUMA_NO_NODE; + + if (default_dram_attrs.read_latency + + default_dram_attrs.write_latency != 0) + return 0; + + if (!default_dram_type) + return -EIO; + + for_each_node_mask(nid, default_dram_type->nodes) { + pxm = node_to_pxm(nid); + target = find_mem_target(pxm); + if (!target) + continue; + attrs = &target->hmem_attrs[1]; + if (nid_dram == NUMA_NO_NODE) { + if (attrs->read_latency + attrs->write_latency == 0 || + attrs->read_bandwidth + attrs->write_bandwidth == 0) { + pr_info("hmat: invalid hmem attrs for default DRAM node: %d,\n", + nid); + pr_info(" "); + dump_hmem_attrs(attrs); + pr_info(" disable hmat based abstract distance algorithm.\n"); + disable_hmat_adistance_algorithm(); + return -EIO; + } + nid_dram = nid; + default_dram_attrs = *attrs; + continue; + } + if (abs(attrs->read_latency - default_dram_attrs.read_latency) * 10 > + default_dram_attrs.read_latency || + abs(attrs->write_latency - default_dram_attrs.write_latency) * 10 > + default_dram_attrs.write_latency || + abs(attrs->read_bandwidth - default_dram_attrs.read_bandwidth) * 10 >
drivers/acpi/numa/hmat.c static int hmat_callback(struct notifier_block *self, · line 827
Quoted 10 lines
drivers/acpi/numa/hmat.c +10
-0+ default_dram_attrs.read_bandwidth) { +pr_info ("hmat: hmem attrs for DRAM nodes mismatch.\n" ); +pr_info (" node %d:" , nid_dram); +dump_hmem_attrs (&default_dram_attrs); +pr_info (" node %d:" , nid); +dump_hmem_attrs (attrs); +pr_info (" disable hmat based abstract distance algorithm.\n" ); +disable_hmat_adistance_algorithm (); +return -EIO ; + }
What is this check about? what is the significance of 10? Can you add the details as a code comment ?
Quoted 32 lines
drivers/acpi/numa/hmat.c +32
-0+ } + +return 0 ; +} + +static int hmat_calculate_adistance (struct notifier_block *self, +unsigned long nid,void *data) +{ + static DECLARE_BITMAP(p_nodes, MAX_NUMNODES); +struct memory_target *target; +struct node_hmem_attrs *attrs; +int *adist = data; +int pxm; + +if (hmat_adistance_disabled) +return NOTIFY_OK ; + + pxm =node_to_pxm (nid); + target =find_mem_target (pxm); +if (!target) +return NOTIFY_OK ; + +if (hmat_init_default_dram_attrs ()) +return NOTIFY_OK ; + +mutex_lock (&target_lock); +hmat_update_target_attrs (target, p_nodes,1 ); +mutex_unlock (&target_lock); + + attrs = &target->hmem_attrs[1 ]; + + if (attrs->read_latency + attrs->write_latency == 0 ||
drivers/acpi/numa/hmat.c static int hmat_callback(struct notifier_block *self, · line 869
Quoted 10 lines
drivers/acpi/numa/hmat.c +10
-0+ attrs->read_bandwidth + attrs->write_bandwidth == 0) +return NOTIFY_OK ; + + *adist =MEMTIER_ADISTANCE_DRAM * + (attrs->read_latency + attrs->write_latency) / + (default_dram_attrs.read_latency + + default_dram_attrs.write_latency) * + (default_dram_attrs.read_bandwidth + + default_dram_attrs.write_bandwidth) / + (attrs->read_bandwidth + attrs->write_bandwidth);
Can you write a comment describing how we use all these attributes in deriving the abstract distance value?
Quoted 69 lines
drivers/acpi/numa/hmat.c +15
-1+ +return NOTIFY_STOP ; +} + +static __meminitdata struct notifier_block hmat_adist_nb = +{ + .notifier_call = hmat_calculate_adistance, + .priority =100 , +}; +static __init void hmat_free_structures (void ) {struct memory_target *target, *tnext;@@ -801,6 +919,7 @@ static __init int hmat_init(void)struct acpi_table_header *tbl;enum acpi_hmat_type i;acpi_status status; +int usage;if (srat_disabled () || hmat_disable)return 0 ;@@ -841,8 +960,11 @@ static __init int hmat_init(void)hmat_register_targets ();/* Keep the table and structures if the notifier may use them */ -if (!hotplug_memory_notifier (hmat_callback,HMAT_CALLBACK_PRI )) + usage = !hotplug_memory_notifier (hmat_callback,HMAT_CALLBACK_PRI ); + usage += !register_mt_adistance_algorithm (&hmat_adist_nb); +if (usage)return 0 ; + out_put:hmat_free_structures ();acpi_put_table (tbl);include/linux/memory-tiers.h +2
-0@@ -33,6 +33,7 @@ struct memory_dev_type {#ifdef CONFIG_NUMA extern bool numa_demotion_enabled; +extern struct memory_dev_type *default_dram_type;struct memory_dev_type *alloc_memory_type (int adistance);void destroy_memory_type (struct memory_dev_type *memtype);void init_node_memory_type (int node,struct memory_dev_type *default_type);@@ -64,6 +65,7 @@ static inline bool node_is_toptier(int node)#else #define numa_demotion_enabled false +#define default_dram_type NULL/* * CONFIG_NUMA implementation returns non NULL error. */ mm/memory-tiers.c +1
-1@@ -37,7 +37,7 @@ struct node_memory_type_map {static DEFINE_MUTEX (memory_tier_lock);static LIST_HEAD (memory_tiers);static struct node_memory_type_map node_memory_types[MAX_NUMNODES ]; -static struct memory_dev_type *default_dram_type; +struct memory_dev_type *default_dram_type;static struct bus_type memory_tier_subsys = { .name ="memory_tiering" ,Signature · 1 line
2.39.2
Re: [RFC 3/4] acpi, hmat: calculate abstract distance with HMAT
Hi, Aneesh,
Thanks for your comments.
Quoted 105 lines · Aneesh Kumar K.V
Quoted 103 lines · Huang Ying
A memory tiering abstract distance calculation algorithm based on ACPI HMAT is implemented. The basic idea is as follows.
The performance attributes of system default DRAM nodes are recorded as the base line. Whose abstract distance is
MEMTIER_ADISTANCE_DRAM. Then, the ratio of the abstract distance of a memory node (target) toMEMTIER_ADISTANCE_DRAMis scaled based on the ratio of the performance attributes of the node to that of the default DRAM nodes.Signed-off-by "Huang, Ying" <[email protected]>Cc Aneesh Kumar K.V <[email protected]>Cc Wei Xu <[email protected]>Cc Alistair Popple <[email protected]>Cc Dan Williams <[email protected]>Cc Dave Hansen <[email protected]>Cc Davidlohr Bueso <[email protected]>Cc Johannes Weiner <[email protected]>Cc Jonathan Cameron <[email protected]>Cc Michal Hocko <[email protected]>Cc Yang Shi <[email protected]>Cc Rafael J Wysocki <[email protected]>--- drivers/acpi/numa/hmat.c | 124 ++++++++++++++++++++++++++++++++++- include/linux/memory-tiers.h | 2 + mm/memory-tiers.c | 2 +- 3 files changed, 126 insertions(+), 2 deletions(-)drivers/acpi/numa/hmat.c +61
-0@@ -24,6 +24,7 @@#include <linux/node.h> #include <linux/sysfs.h> #include <linux/dax.h> +#include <linux/memory-tiers.h> static u8 hmat_revision;static int hmat_disable__initdata ;@@ -759,6 +760,123 @@ static int hmat_callback(struct notifier_block *self,return NOTIFY_OK ; } +static int hmat_adistance_disabled; +static struct node_hmem_attrs default_dram_attrs; + +static void dump_hmem_attrs (struct node_hmem_attrs *attrs) +{ +pr_cont ("read_latency: %u, write_latency: %u, read_bandwidth: %u, write_bandwidth: %u\n" , + attrs->read_latency, attrs->write_latency, + attrs->read_bandwidth, attrs->write_bandwidth); +} + +static void disable_hmat_adistance_algorithm (void ) +{ + hmat_adistance_disabled = true; +} + +static int hmat_init_default_dram_attrs (void ) +{ +struct memory_target *target; +struct node_hmem_attrs *attrs; +int nid, pxm; +int nid_dram =NUMA_NO_NODE ; + +if (default_dram_attrs.read_latency + + default_dram_attrs.write_latency !=0 ) +return 0 ; + +if (!default_dram_type) +return -EIO ; + +for_each_node_mask (nid, default_dram_type->nodes) { + pxm =node_to_pxm (nid); + target =find_mem_target (pxm); +if (!target) +continue ; + attrs = &target->hmem_attrs[1 ]; +if (nid_dram ==NUMA_NO_NODE ) { +if (attrs->read_latency + attrs->write_latency ==0 || + attrs->read_bandwidth + attrs->write_bandwidth ==0 ) { +pr_info ("hmat: invalid hmem attrs for default DRAM node: %d,\n" , + nid); +pr_info (" " ); +dump_hmem_attrs (attrs); +pr_info (" disable hmat based abstract distance algorithm.\n" ); +disable_hmat_adistance_algorithm (); +return -EIO ; + } + nid_dram = nid; + default_dram_attrs = *attrs; +continue ; + } +if (abs (attrs->read_latency - default_dram_attrs.read_latency) *10 > + default_dram_attrs.read_latency || +abs (attrs->write_latency - default_dram_attrs.write_latency) *10 > + default_dram_attrs.write_latency || +abs (attrs->read_bandwidth - default_dram_attrs.read_bandwidth) *10 > + default_dram_attrs.read_bandwidth) { +pr_info ("hmat: hmem attrs for DRAM nodes mismatch.\n" ); +pr_info (" node %d:" , nid_dram); +dump_hmem_attrs (&default_dram_attrs); +pr_info (" node %d:" , nid);
Quoted 8 lines
drivers/acpi/numa/hmat.c static int hmat_callback(struct notifier_block *self, · line 808
Quoted 5 lines
drivers/acpi/numa/hmat.c +5
-0+dump_hmem_attrs (attrs); +pr_info (" disable hmat based abstract distance algorithm.\n" ); +disable_hmat_adistance_algorithm (); +return -EIO ; + }What is this check about? what is the significance of 10? Can you add the details as a code comment ?
We want to check the validity of HMAT here. We expect the performance of all default DRAM nodes are almost same, that is, the variation is less than 10%. And that will be used as base to calculate the abstract distance of other memory devices. If there is large variation among the performance of default DRAM nodes, it's hard to set a reasonable base for abstract distance calculation.
I will add some comments for this in the next version.
Quoted 39 lines
Quoted 39 lines
drivers/acpi/numa/hmat.c +38
-0+ } + +return 0 ; +} + +static int hmat_calculate_adistance (struct notifier_block *self, +unsigned long nid,void *data) +{ + static DECLARE_BITMAP(p_nodes, MAX_NUMNODES); +struct memory_target *target; +struct node_hmem_attrs *attrs; +int *adist = data; +int pxm; + +if (hmat_adistance_disabled) +return NOTIFY_OK ; + + pxm =node_to_pxm (nid); + target =find_mem_target (pxm); +if (!target) +return NOTIFY_OK ; + +if (hmat_init_default_dram_attrs ()) +return NOTIFY_OK ; + +mutex_lock (&target_lock); +hmat_update_target_attrs (target, p_nodes,1 ); +mutex_unlock (&target_lock); + + attrs = &target->hmem_attrs[1 ]; + +if (attrs->read_latency + attrs->write_latency ==0 || + attrs->read_bandwidth + attrs->write_bandwidth ==0 ) +return NOTIFY_OK ; + + *adist =MEMTIER_ADISTANCE_DRAM * + (attrs->read_latency + attrs->write_latency) / + (default_dram_attrs.read_latency +
Quoted 8 lines
drivers/acpi/numa/hmat.c static int hmat_callback(struct notifier_block *self, · line 869
Quoted 4 lines
drivers/acpi/numa/hmat.c +4
-0+ default_dram_attrs.write_latency) * + (default_dram_attrs.read_bandwidth + + default_dram_attrs.write_bandwidth) / + (attrs->read_bandwidth + attrs->write_bandwidth);Can you write a comment describing how we use all these attributes in deriving the abstract distance value?
Sure. How about the following text?
The abstract distance of a memory node is in direct proportion to its memory latency (read + write) and inversely proportional to its memory bandwidth (read + write). The abstract distance, memory latency, and memory bandwidth of default DRAM nodes are used as base.
Best Regards,
Huang, Ying
Quoted 70 lines
Quoted 70 lines
drivers/acpi/numa/hmat.c +15
-1+ +return NOTIFY_STOP ; +} + +static __meminitdata struct notifier_block hmat_adist_nb = +{ + .notifier_call = hmat_calculate_adistance, + .priority =100 , +}; +static __init void hmat_free_structures (void ) {struct memory_target *target, *tnext;@@ -801,6 +919,7 @@ static __init int hmat_init(void)struct acpi_table_header *tbl;enum acpi_hmat_type i;acpi_status status; +int usage;if (srat_disabled () || hmat_disable)return 0 ;@@ -841,8 +960,11 @@ static __init int hmat_init(void)hmat_register_targets ();/* Keep the table and structures if the notifier may use them */ -if (!hotplug_memory_notifier (hmat_callback,HMAT_CALLBACK_PRI )) + usage = !hotplug_memory_notifier (hmat_callback,HMAT_CALLBACK_PRI ); + usage += !register_mt_adistance_algorithm (&hmat_adist_nb); +if (usage)return 0 ; + out_put:hmat_free_structures ();acpi_put_table (tbl);include/linux/memory-tiers.h +2
-0@@ -33,6 +33,7 @@ struct memory_dev_type {#ifdef CONFIG_NUMA extern bool numa_demotion_enabled; +extern struct memory_dev_type *default_dram_type;struct memory_dev_type *alloc_memory_type (int adistance);void destroy_memory_type (struct memory_dev_type *memtype);void init_node_memory_type (int node,struct memory_dev_type *default_type);@@ -64,6 +65,7 @@ static inline bool node_is_toptier(int node)#else #define numa_demotion_enabled false +#define default_dram_type NULL/* * CONFIG_NUMA implementation returns non NULL error. */ mm/memory-tiers.c +1
-1@@ -37,7 +37,7 @@ struct node_memory_type_map {static DEFINE_MUTEX (memory_tier_lock);static LIST_HEAD (memory_tiers);static struct node_memory_type_map node_memory_types[MAX_NUMNODES ]; -static struct memory_dev_type *default_dram_type; +struct memory_dev_type *default_dram_type;static struct bus_type memory_tier_subsys = { .name ="memory_tiering" ,Signature · 1 line
2.39.2
RFC 4/4 dax, kmem: calculate abstract distance with general interface
In reply to Huang YingPreviously, a fixed abstract distance MEMTIER_DEFAULT_DAX_ADISTANCE is used for slow memory type in kmem driver. This limits the usage of kmem driver, for example, it cannot be used for HBM (high bandwidth memory).
So, we use the general abstract distance calculation mechanism in kmem drivers to get more accurate abstract distance on systems with proper support. The original MEMTIER_DEFAULT_DAX_ADISTANCE is used as fallback only.
Now, multiple memory types may be managed by kmem. These memory types are put into the "kmem_memory_types" list and protected by kmem_memory_type_lock.
--- drivers/dax/kmem.c | 54 +++++++++++++++++++++++++++--------- include/linux/memory-tiers.h | 2 ++ mm/memory-tiers.c | 2 +- 3 files changed, 44 insertions(+), 14 deletions(-)
drivers/dax/kmem.c +41 -13
@@ -49,14 +49,40 @@ struct dax_kmem_data {struct resource *res[]; }; -static struct memory_dev_type *dax_slowmem_type; +static DEFINE_MUTEX (kmem_memory_type_lock); +static LIST_HEAD (kmem_memory_types); + +static struct memory_dev_type *kmem_find_alloc_memorty_type (int adist) +{ +bool found = false; +struct memory_dev_type *mtype; + +mutex_lock (&kmem_memory_type_lock); +list_for_each_entry (mtype, &kmem_memory_types, list) { +if (mtype->adistance == adist) { + found = true; +break ; + } + } +if (!found) { + mtype =alloc_memory_type (adist); +if (!IS_ERR (mtype)) +list_add (&mtype->list, &kmem_memory_types); + } +mutex_unlock (&kmem_memory_type_lock); + +return mtype; +} +static int dev_dax_kmem_probe (struct dev_dax *dev_dax) {struct device *dev = &dev_dax->dev;unsigned long total_len =0 ;struct dax_kmem_data *data; +struct memory_dev_type *mtype;int i, rc, mapped =0 ;int numa_node; +int adist =MEMTIER_DEFAULT_DAX_ADISTANCE ;/* * Ensure good NUMA information for the persistent memory.
@@ -71,6 +97,11 @@ static int dev_dax_kmem_probe(struct dev_dax *dev_dax)return -EINVAL ; } +mt_calc_adistance (numa_node, &adist); + mtype =kmem_find_alloc_memorty_type (adist); +if (IS_ERR (mtype)) +return PTR_ERR (mtype); +for (i =0 ; i < dev_dax->nr_range; i++) {struct range range;
@@ -88,7 +119,7 @@ static int dev_dax_kmem_probe(struct dev_dax *dev_dax)return -EINVAL ; } -init_node_memory_type (numa_node, dax_slowmem_type); +init_node_memory_type (numa_node, mtype); rc = -ENOMEM ; data =kzalloc (struct_size (data, res, dev_dax->nr_range),GFP_KERNEL );
@@ -167,7 +198,7 @@ static int dev_dax_kmem_probe(struct dev_dax *dev_dax) err_res_name:kfree (data); err_dax_kmem_data: -clear_node_memory_type (numa_node, dax_slowmem_type); +clear_node_memory_type (numa_node, mtype);return rc; }
@@ -219,7 +250,7 @@ static void dev_dax_kmem_remove(struct dev_dax *dev_dax)* for that. This implies this reference will be around * till next reboot. */ - clear_node_memory_type(node, dax_slowmem_type); + clear_node_memory_type(node, NULL); } }#else
@@ -251,12 +282,6 @@ static int __init dax_kmem_init(void)if (!kmem_name)return -ENOMEM ; - dax_slowmem_type =alloc_memory_type (MEMTIER_DEFAULT_DAX_ADISTANCE ); -if (IS_ERR (dax_slowmem_type)) { - rc =PTR_ERR (dax_slowmem_type); - goto err_dax_slowmem_type; - } - rc =dax_driver_register (&device_dax_kmem_driver);if (rc) goto error_dax_driver;
@@ -264,18 +289,21 @@ static int __init dax_kmem_init(void)return rc; error_dax_driver: -destroy_memory_type (dax_slowmem_type); -err_dax_slowmem_type:kfree_const (kmem_name);return rc; } static void __exit dax_kmem_exit(void) { +struct memory_dev_type *mtype, *mtn; +dax_driver_unregister (&device_dax_kmem_driver);if (!any_hotremove_failed)kfree_const (kmem_name); -destroy_memory_type (dax_slowmem_type); +list_for_each_entry_safe (mtype, mtn, &kmem_memory_types, list) { +list_del (&mtype->list); +destroy_memory_type (mtype); + } }MODULE_AUTHOR ("Intel Corporation" );
include/linux/memory-tiers.h +2 -0
@@ -24,6 +24,8 @@ struct memory_tier;struct memory_dev_type {/* list of memory types that are part of same tier as this type */ struct list_head tier_sibiling; +/* list of memory types that are managed by one driver */ +struct list_head list;/* abstract distance for this specific memory type */ int adistance;/* Nodes of same abstract distance */
mm/memory-tiers.c +1 -1
@@ -582,7 +582,7 @@ EXPORT_SYMBOL_GPL(init_node_memory_type);void clear_node_memory_type (int node,struct memory_dev_type *memtype) {mutex_lock (&memory_tier_lock); -if (node_memory_types[node].memtype == memtype) +if (node_memory_types[node].memtype == memtype || !memtype) node_memory_types[node].map_count--;/* * If we umapped all the attached devices to this node,
Signature · 1 line
2.39.2