Enhance vfio PCI hot reset for vfio cdev device
Subsystems (5)
v8 cover Enhance vfio PCI hot reset for vfio cdev device
VFIO_DEVICE_PCI_HOT_RESET requires user to pass an array of group fds to prove that it owns all devices affected by resetting the calling device. While for cdev devices, user can use an iommufd-based ownership checking model and invoke VFIO_DEVICE_PCI_HOT_RESET with a zero-length fd array.
This series extends VFIO_DEVICE_GET_PCI_HOT_RESET_INFO to check ownership and return the check result and the devid of affected devices to user. In the end, extends the VFIO_DEVICE_PCI_HOT_RESET to accept zero-length fd array for hot-reset with cdev devices.
The new hot reset method and updated _INFO ioctl are tested with the below qemu:
https://github.com/yiliu1765/qemu/tree/iommufd_rfcv4.mig.reset.v4_var3
(requires to test with the cdev kernel)
Change log:
v8:
- Add r-b from Jason to patch 03, 04, 05, 07, 09 of v7
- Add a patch to copy the per-device hot-reset structure to user during the device loop instead of storing them in a buffer and copy all the contents in one copy, this avoids an extra loop to count device and also avoids allocating a temporay buffer for it. (Jason)
- Rename vfio_iommufd_device_hot_reset_devid() to be vfio_iommufd_get_dev_id() and refine its return value for the case no valid ID can be returned. Hence make it a general helper to get ID for a device. (Alex, Jason)
- Remove iommufd_ctx_has_group() CONIFG_IOMMUFD disabled stub as this API is called in iommufd specific code which is compiled when CONFIG_IOMMU is enabled. (Alex)
- Reaffirming Yanting's t-b (Tested NIC passthrough on Intel platform. mainly regression tests)
v7: https://lore.kernel.org/kvm/[email protected]/
- Drop noiommu support (patch 01 of v6 is dropped)
- Remove helpers to get devid and ictx for iommufd_access
- Document the dev_set representative requirement in the VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for the cdev opened device (Alex)
- zero-length fd array approach is only for cdev opened device (Alex)
v6: https://lore.kernel.org/kvm/[email protected]/
- Remove noiommu_access, reuse iommufd_access instead (Alex)
- vfio_iommufd_physical_ictx -> vfio_iommufd_device_ictx
- vfio_iommufd_physical_devid -> vfio_iommufd_device_hot_reset_devid
- Refine logic in patch 9 and 10 of v5, no uapi change. (Alex)
- Remove lockdep asset in vfio_pci_is_device_in_set (Cédric)
- Add t-b from Terrence (Tested GVT-g / GVT-d VFIO legacy mode / compat mode / cdev mode, including negative tests. No regression be introduced.)
v5: https://lore.kernel.org/kvm/[email protected]/
- Drop patch 01 of v4 (Alex)
- Create noiommu_access for noiommu devices (Jason)
- Reserve all negative iommufd IDs, hence VFIO can encode negative values (Jason)
- Make vfio_iommufd_physical_devid() return -EINVAL if it's not called with a physical device or a noiommu device.
- Add vfio_find_device_in_devset() in vfio_main.c (Alex)
- Add iommufd_ctx_has_group() to replace vfio_devset_iommufd_has_group().
Reason: vfio_devset_iommufd_has_group() only loops the devices within the given devset to check the iommufd an iommu_group, but an iommu_group can span into multiple devsets. So if failed to find the group in a devset doesn't mean the group is not owned by the iommufd. So here either needs to search all the devsets or add an iommufd API to check it. It appears an iommufd API makes more sense.
- Adopt suggestions from Alex on patch 08 and 09 of v4, refine the hot-reset uapi description and minor tweaks
- Use bitfields for bool members (Alex)
v4: https://lore.kernel.org/kvm/[email protected]/
- Rename the patch series subject
- Patch 01 is moved from the cdev series
- Patch 02, 06 are new per review comments in v3
- Patch 03/04/05/07/08/09 are from v3 with updates
v3: https://lore.kernel.org/kvm/[email protected]/
- Remove the new _INFO ioctl of v2, extend the existing _INFO ioctl to report devid (Alex)
- Add r-b from Jason
- Add t-b from Terrence Xu and Yanting Jiang (mainly regression test)
v2: https://lore.kernel.org/kvm/[email protected]/
- Split the patch 03 of v1 to be 03, 04 and 05 of v2 (Jaon)
- Add r-b from Kevin and Jason
- Add patch 10 to introduce a new _INFO ioctl for the usage of device fd passing usage in cdev path (Jason, Alex)
v1: https://lore.kernel.org/kvm/[email protected]/
Regards,
Yi Liu
Yi Liu (10):
vfio/pci: Update comment around group_fd get in
vfio_pci_ioctl_pci_hot_reset()
vfio/pci: Move the existing hot reset logic to be a helper
iommufd: Reserve all negative IDs in the iommufd xarray
iommufd: Add iommufd_ctx_has_group()
iommufd: Add helper to retrieve iommufd_ctx and devid
vfio: Mark cdev usage in vfio_device
vfio: Add helper to search vfio_device in a dev_set vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device
cdev
vfio/pci: Copy hot-reset device info to userspace in the devices loop vfio/pci: Allow passing zero-length fd array in
VFIO_DEVICE_PCI_HOT_RESET
drivers/iommu/iommufd/device.c | 42 ++++++ drivers/iommu/iommufd/main.c | 2 +- drivers/vfio/iommufd.c | 44 ++++++ drivers/vfio/pci/vfio_pci_core.c | 250 +++++++++++++++++++------------ drivers/vfio/vfio_main.c | 15 ++ include/linux/iommufd.h | 5 + include/linux/vfio.h | 22 +++ include/uapi/linux/vfio.h | 71 ++++++++- 8 files changed, 352 insertions(+), 99 deletions(-)
Signature · 1 line
2.34.1
PATCH v8 1/10 vfio/pci: Update comment around group_fd get in vfio_pci_ioctl_pci_hot_reset()
This suits more on what the code does.
--- drivers/vfio/pci/vfio_pci_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/vfio/pci/vfio_pci_core.c +2 -3
@@ -1311,9 +1311,8 @@ static int vfio_pci_ioctl_pci_hot_reset(struct vfio_pci_core_device *vdev, }/* -* For each group_fd, get the group through the vfio external user -* interface and store the group and iommu ID. This ensures the group -* is held across the reset. +* Get the group file for each fd to ensure the group is held across +* the reset */ for (file_idx =0 ; file_idx < hdr.count; file_idx++) {struct file *file =fget (group_fds[file_idx]);
Signature · 1 line
2.34.1
PATCH v8 2/10 vfio/pci: Move the existing hot reset logic to be a helper
In reply to Yi LiuThis prepares to add another method for hot reset. The major hot reset logic are moved to vfio_pci_ioctl_pci_hot_reset_groups().
No functional change is intended.
--- drivers/vfio/pci/vfio_pci_core.c | 55 +++++++++++++++++++------------- 1 file changed, 32 insertions(+), 23 deletions(-)
drivers/vfio/pci/vfio_pci_core.c +32 -23
@@ -1258,29 +1258,16 @@ static int vfio_pci_ioctl_get_pci_hot_reset_info(return ret; } -static int vfio_pci_ioctl_pci_hot_reset (struct vfio_pci_core_device *vdev, -struct vfio_pci_hot_reset __user *arg) +static int +vfio_pci_ioctl_pci_hot_reset_groups (struct vfio_pci_core_device *vdev, +int array_count,bool slot, +struct vfio_pci_hot_reset __user *arg) { - unsigned long minsz = offsetofend(struct vfio_pci_hot_reset, count); -struct vfio_pci_hot_reset hdr;int32_t *group_fds;struct file **files;struct vfio_pci_group_info info; -bool slot = false;int file_idx, count =0 , ret =0 ; -if (copy_from_user (&hdr, arg, minsz)) -return -EFAULT ; - -if (hdr.argsz < minsz || hdr.flags) -return -EINVAL ; - -/* Can we do a slot or bus reset or neither? */ -if (!pci_probe_reset_slot (vdev->pdev->slot)) - slot = true; -else if (pci_probe_reset_bus (vdev->pdev->bus)) -return -ENODEV ; -/* * We can't let userspace give us an arbitrarily large buffer to copy, * so verify how many we think there could be. Note groups can have
@@ -1292,11 +1279,11 @@ static int vfio_pci_ioctl_pci_hot_reset(struct vfio_pci_core_device *vdev,return ret;/* Somewhere between 1 and count is OK */ -if (!hdr.count || hdr.count > count) +if (!array_count || array_count > count)return -EINVAL ; - group_fds =kcalloc (hdr.count,sizeof (*group_fds),GFP_KERNEL ); - files =kcalloc (hdr.count,sizeof (*files),GFP_KERNEL ); + group_fds =kcalloc (array_count,sizeof (*group_fds),GFP_KERNEL ); + files =kcalloc (array_count,sizeof (*files),GFP_KERNEL );if (!group_fds || !files) {kfree (group_fds);kfree (files);
@@ -1304,7 +1291,7 @@ static int vfio_pci_ioctl_pci_hot_reset(struct vfio_pci_core_device *vdev, }if (copy_from_user (group_fds, arg->group_fds, - hdr.count *sizeof (*group_fds))) { + array_count *sizeof (*group_fds))) {kfree (group_fds);kfree (files);return -EFAULT ;
@@ -1314,7 +1301,7 @@ static int vfio_pci_ioctl_pci_hot_reset(struct vfio_pci_core_device *vdev,* Get the group file for each fd to ensure the group is held across * the reset */ -for (file_idx =0 ; file_idx < hdr.count; file_idx++) { +for (file_idx =0 ; file_idx < array_count; file_idx++) {struct file *file =fget (group_fds[file_idx]);if (!file) {
@@ -1338,7 +1325,7 @@ static int vfio_pci_ioctl_pci_hot_reset(struct vfio_pci_core_device *vdev,if (ret) goto hot_reset_release; - info.count = hdr.count; + info.count = array_count; info.files = files; ret =vfio_pci_dev_set_hot_reset (vdev->vdev.dev_set, &info);
@@ -1351,6 +1338,28 @@ static int vfio_pci_ioctl_pci_hot_reset(struct vfio_pci_core_device *vdev,return ret; } +static int vfio_pci_ioctl_pci_hot_reset (struct vfio_pci_core_device *vdev, +struct vfio_pci_hot_reset __user *arg) +{ + unsigned long minsz = offsetofend(struct vfio_pci_hot_reset, count); +struct vfio_pci_hot_reset hdr; +bool slot = false; + +if (copy_from_user (&hdr, arg, minsz)) +return -EFAULT ; + +if (hdr.argsz < minsz || hdr.flags) +return -EINVAL ; + +/* Can we do a slot or bus reset or neither? */ +if (!pci_probe_reset_slot (vdev->pdev->slot)) + slot = true; +else if (pci_probe_reset_bus (vdev->pdev->bus)) +return -ENODEV ; + +return vfio_pci_ioctl_pci_hot_reset_groups (vdev, hdr.count, slot, arg); +} +static int vfio_pci_ioctl_ioeventfd (struct vfio_pci_core_device *vdev,struct vfio_device_ioeventfd __user *arg) {
Signature · 1 line
2.34.1
PATCH v8 3/10 iommufd: Reserve all negative IDs in the iommufd xarray
In reply to Yi LiuWith this reservation, IOMMUFD users can encode the negative IDs for specific purposes. e.g. VFIO needs two reserved values to tell userspace the ID returned is not valid but has other meaning.
--- drivers/iommu/iommufd/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/iommufd/main.c +1 -1
@@ -50,7 +50,7 @@ struct iommufd_object *_iommufd_object_alloc(struct iommufd_ctx *ictx,* before calling iommufd_object_finalize(). */ rc =xa_alloc (&ictx->objects, &obj->id,XA_ZERO_ENTRY , - xa_limit_32b,GFP_KERNEL_ACCOUNT ); + xa_limit_31b,GFP_KERNEL_ACCOUNT );if (rc) goto out_free;return obj;
Signature · 1 line
2.34.1
PATCH v8 4/10 iommufd: Add iommufd_ctx_has_group()
In reply to Yi LiuThis adds the helper to check if any device within the given iommu_group has been bound with the iommufd_ctx. This is helpful for the checking on device ownership for the devices which have not been bound but cannot be bound to any other iommufd_ctx as the iommu_group has been bound.
--- drivers/iommu/iommufd/device.c | 30 ++++++++++++++++++++++++++++++ include/linux/iommufd.h | 2 ++ 2 files changed, 32 insertions(+)
drivers/iommu/iommufd/device.c +30 -0
@@ -98,6 +98,36 @@ struct iommufd_device *iommufd_device_bind(struct iommufd_ctx *ictx, }EXPORT_SYMBOL_NS_GPL (iommufd_device_bind,IOMMUFD ); +/** +* iommufd_ctx_has_group - True if any device within the group is bound +* to the ictx +* @ictx: iommufd file descriptor +* @group: Pointer to a physical iommu_group struct +* +* True if any device within the group has been bound to this ictx, ex. via +* iommufd_device_bind(), therefore implying ictx ownership of the group. +*/ +bool iommufd_ctx_has_group (struct iommufd_ctx *ictx,struct iommu_group *group) +{ +struct iommufd_object *obj; +unsigned long index; + +if (!ictx || !group) +return false; + +xa_lock (&ictx->objects); +xa_for_each (&ictx->objects, index, obj) { +if (obj->type ==IOMMUFD_OBJ_DEVICE && + container_of(obj, struct iommufd_device, obj)->group == group) { +xa_unlock (&ictx->objects); +return true; + } + } +xa_unlock (&ictx->objects); +return false; +} +EXPORT_SYMBOL_NS_GPL (iommufd_ctx_has_group,IOMMUFD ); +/** * iommufd_device_unbind - Undo iommufd_device_bind() * @idev: Device returned by iommufd_device_bind()
include/linux/iommufd.h +2 -0
@@ -16,6 +16,7 @@ struct page;struct iommufd_ctx ;struct iommufd_access ;struct file ; +struct iommu_group ;struct iommufd_device *iommufd_device_bind (struct iommufd_ctx *ictx,struct device *dev,u32 *id);
@@ -50,6 +51,7 @@ void iommufd_ctx_get(struct iommufd_ctx *ictx);#if IS_ENABLED (CONFIG_IOMMUFD )struct iommufd_ctx *iommufd_ctx_from_file (struct file *file);void iommufd_ctx_put (struct iommufd_ctx *ictx); +bool iommufd_ctx_has_group (struct iommufd_ctx *ictx,struct iommu_group *group); int iommufd_access_pin_pages(struct iommufd_access *access, unsigned long iova, unsigned long length, struct page **out_pages,
Signature · 1 line
2.34.1
PATCH v8 5/10 iommufd: Add helper to retrieve iommufd_ctx and devid
In reply to Yi LiuThis is needed by the vfio-pci driver to report affected devices in the hot-reset for a given device.
--- drivers/iommu/iommufd/device.c | 12 ++++++++++++ include/linux/iommufd.h | 3 +++ 2 files changed, 15 insertions(+)
drivers/iommu/iommufd/device.c +12 -0
@@ -146,6 +146,18 @@ void iommufd_device_unbind(struct iommufd_device *idev) }EXPORT_SYMBOL_NS_GPL (iommufd_device_unbind,IOMMUFD ); +struct iommufd_ctx *iommufd_device_to_ictx (struct iommufd_device *idev) +{ +return idev->ictx; +} +EXPORT_SYMBOL_NS_GPL (iommufd_device_to_ictx,IOMMUFD ); + +u32 iommufd_device_to_id (struct iommufd_device *idev) +{ +return idev->obj.id; +} +EXPORT_SYMBOL_NS_GPL (iommufd_device_to_id,IOMMUFD ); +static int iommufd_device_setup_msi (struct iommufd_device *idev,struct iommufd_hw_pagetable *hwpt,phys_addr_t sw_msi_start)
include/linux/iommufd.h +3 -0
@@ -25,6 +25,9 @@ void iommufd_device_unbind(struct iommufd_device *idev);int iommufd_device_attach (struct iommufd_device *idev,u32 *pt_id);void iommufd_device_detach (struct iommufd_device *idev); +struct iommufd_ctx *iommufd_device_to_ictx (struct iommufd_device *idev); +u32 iommufd_device_to_id (struct iommufd_device *idev); +struct iommufd_access_ops {u8 needs_pin_pages :1 ;void (*unmap)(void *data,unsigned long iova,unsigned long length);
Signature · 1 line
2.34.1
PATCH v8 6/10 vfio: Mark cdev usage in vfio_device
In reply to Yi LiuThis can be used to differentiate whether to report group_id or devid in the revised VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl. At this moment, no cdev path yet, so the vfio_device_cdev_opened() helper always returns false.
--- include/linux/vfio.h | 5 +++++ 1 file changed, 5 insertions(+)
include/linux/vfio.h +5 -0
@@ -139,6 +139,11 @@ int vfio_iommufd_emulated_attach_ioas(struct vfio_device *vdev, u32 *pt_id); ((int (*)(struct vfio_device *vdev, u32 *pt_id)) NULL)#endif +static inline bool vfio_device_cdev_opened (struct vfio_device *device) +{ +return false; +} +/** * struct vfio_migration_ops - VFIO bus device driver migration callbacks *
Signature · 1 line
2.34.1
PATCH v8 7/10 vfio: Add helper to search vfio_device in a dev_set
In reply to Yi LiuThere are drivers that need to search vfio_device within a given dev_set. e.g. vfio-pci. So add a helper.
vfio_pci_is_device_in_set() now returns -EBUSY in commit a882c16a2b7e ("vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set") where it was trying to preserve the return of vfio_pci_try_zap_and_vma_lock_cb(). However, it makes more sense to return -ENODEV.
--- drivers/vfio/pci/vfio_pci_core.c | 6 +----- drivers/vfio/vfio_main.c | 15 +++++++++++++++ include/linux/vfio.h | 3 +++ 3 files changed, 19 insertions(+), 5 deletions(-)
drivers/vfio/pci/vfio_pci_core.c +1 -5
@@ -2339,12 +2339,8 @@ static bool vfio_dev_in_groups(struct vfio_pci_core_device *vdev,static int vfio_pci_is_device_in_set (struct pci_dev *pdev,void *data) {struct vfio_device_set *dev_set = data; -struct vfio_device *cur; -list_for_each_entry (cur, &dev_set->device_list, dev_set_list) -if (cur->dev == &pdev->dev) -return 0 ; -return -EBUSY ; +return vfio_find_device_in_devset (dev_set, &pdev->dev) ?0 : -ENODEV ; }/*
drivers/vfio/vfio_main.c +15 -0
@@ -141,6 +141,21 @@ unsigned int vfio_device_set_open_count(struct vfio_device_set *dev_set) }EXPORT_SYMBOL_GPL (vfio_device_set_open_count); +struct vfio_device * +vfio_find_device_in_devset (struct vfio_device_set *dev_set, +struct device *dev) +{ +struct vfio_device *cur; + +lockdep_assert_held (&dev_set->lock); + +list_for_each_entry (cur, &dev_set->device_list, dev_set_list) +if (cur->dev == dev) +return cur; +return NULL ; +} +EXPORT_SYMBOL_GPL (vfio_find_device_in_devset); +/* * Device objects - create, release, get, put, search */
include/linux/vfio.h +3 -0
@@ -244,6 +244,9 @@ void vfio_unregister_group_dev(struct vfio_device *device);int vfio_assign_device_set (struct vfio_device *device,void *set_id);unsigned int vfio_device_set_open_count (struct vfio_device_set *dev_set); +struct vfio_device * +vfio_find_device_in_devset (struct vfio_device_set *dev_set, +struct device *dev); int vfio_mig_get_next_state(struct vfio_device *device, enum vfio_device_mig_state cur_fsm,
Signature · 1 line
2.34.1
PATCH v8 8/10 vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev
In reply to Yi LiuThis allows VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl use the iommufd_ctx of the cdev device to check the ownership of the other affected devices.
When VFIO_DEVICE_GET_PCI_HOT_RESET_INFO is called on an IOMMUFD managed device, the new flag VFIO_PCI_HOT_RESET_FLAG_DEV_ID is reported to indicate the values returned are IOMMUFD devids rather than group IDs as used when accessing vfio devices through the conventional vfio group interface. Additionally the flag VFIO_PCI_HOT_RESET_FLAG_DEV_ID_OWNED will be reported in this mode if all of the devices affected by the hot-reset are owned by either virtue of being directly bound to the same iommufd context as the calling device, or implicitly owned via a shared IOMMU group.
--- drivers/vfio/iommufd.c | 44 ++++++++++++++++++++++++++ drivers/vfio/pci/vfio_pci_core.c | 54 +++++++++++++++++++++++++++----- include/linux/vfio.h | 14 +++++++++ include/uapi/linux/vfio.h | 50 ++++++++++++++++++++++++++++- 4 files changed, 154 insertions(+), 8 deletions(-)
drivers/vfio/iommufd.c +44 -0
@@ -66,6 +66,50 @@ void vfio_iommufd_unbind(struct vfio_device *vdev) vdev->ops->unbind_iommufd (vdev); } +struct iommufd_ctx *vfio_iommufd_device_ictx (struct vfio_device *vdev) +{ +if (vdev->iommufd_device) +return iommufd_device_to_ictx (vdev->iommufd_device); +return NULL ; +} +EXPORT_SYMBOL_GPL (vfio_iommufd_device_ictx); + +static int vfio_iommufd_device_id (struct vfio_device *vdev) +{ +if (vdev->iommufd_device) +return iommufd_device_to_id (vdev->iommufd_device); +return -EINVAL ; +} + +/* +* Return devid for a device. +* valid ID for the device that is owned by the ictx +* -ENOENT = device is owned but there is no ID +* -ENODEV or other error = device is not owned +*/ +int vfio_iommufd_get_dev_id (struct vfio_device *vdev,struct iommufd_ctx *ictx) +{ +struct iommu_group *group; +int devid; + +if (vfio_iommufd_device_ictx (vdev) == ictx) +return vfio_iommufd_device_id (vdev); + + group =iommu_group_get (vdev->dev); +if (!group) +return -ENODEV ; + +if (iommufd_ctx_has_group (ictx, group)) + devid = -ENOENT ; +else + devid = -ENODEV ; + +iommu_group_put (group); + +return devid; +} +EXPORT_SYMBOL_GPL (vfio_iommufd_get_dev_id); +/* * The physical standard ops mean that the iommufd_device is bound to the * physical device vdev->dev that was provided to vfio_init_group_dev(). Drivers
drivers/vfio/pci/vfio_pci_core.c +47 -7
96 lines not on this page · raw message
include/linux/vfio.h +14 -0
@@ -114,6 +114,8 @@ struct vfio_device_ops { };#if IS_ENABLED (CONFIG_IOMMUFD ) +struct iommufd_ctx *vfio_iommufd_device_ictx (struct vfio_device *vdev); +int vfio_iommufd_get_dev_id (struct vfio_device *vdev,struct iommufd_ctx *ictx);int vfio_iommufd_physical_bind (struct vfio_device *vdev,struct iommufd_ctx *ictx,u32 *out_device_id);void vfio_iommufd_physical_unbind (struct vfio_device *vdev);
@@ -123,6 +125,18 @@ int vfio_iommufd_emulated_bind(struct vfio_device *vdev,void vfio_iommufd_emulated_unbind (struct vfio_device *vdev);int vfio_iommufd_emulated_attach_ioas (struct vfio_device *vdev,u32 *pt_id);#else +static inline struct iommufd_ctx * +vfio_iommufd_device_ictx (struct vfio_device *vdev) +{ +return NULL ; +} + +static inline int +vfio_iommufd_get_dev_id (struct vfio_device *vdev,struct iommufd_ctx *ictx) +{ +return VFIO_PCI_DEVID_NOT_OWNED ; +} +#define vfio_iommufd_physical_bind \ ((int (*)(struct vfio_device *vdev, struct iommufd_ctx *ictx, \ u32 *out_device_id)) NULL)
include/uapi/linux/vfio.h +49 -1
66 lines not on this page · raw message
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v8 08/10] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev
Quoted 15 lines · Yi Liu
This allows
VFIO_DEVICE_GET_PCI_HOT_RESET_INFOioctl use theiommufd_ctxof the cdev device to check the ownership of the other affected devices.When
VFIO_DEVICE_GET_PCI_HOT_RESET_INFOis called on an IOMMUFD managed device, the new flagVFIO_PCI_HOT_RESET_FLAG_DEV_IDis reported to indicate the values returned are IOMMUFD devids rather than group IDs as used when accessing vfio devices through the conventional vfio group interface. Additionally the flagVFIO_PCI_HOT_RESET_FLAG_DEV_ID_OWNEDwill be reported in this mode if all of the devices affected by the hot-reset are owned by either virtue of being directly bound to the same iommufd context as the calling device, or implicitly owned via a shared IOMMU group.Suggested-by Jason Gunthorpe <[email protected]>Suggested-by Alex Williamson <[email protected]>Signed-off-by Yi Liu <[email protected]>
Quoted 6 lines
--- drivers/vfio/iommufd.c | 44 ++++++++++++++++++++++++++ drivers/vfio/pci/vfio_pci_core.c | 54 +++++++++++++++++++++++++++----- include/linux/vfio.h | 14 +++++++++ include/uapi/linux/vfio.h | 50 ++++++++++++++++++++++++++++- 4 files changed, 154 insertions(+), 8 deletions(-)
I would have put patch 9 before this one, but it is OK this way too
Jason
PATCH v8 9/10 vfio/pci: Copy hot-reset device info to userspace in the devices loop
In reply to Yi LiuThis copies the vfio_pci_dependent_device to userspace during looping each affected device for reporting vfio_pci_hot_reset_info. This avoids counting the affected devices and allocating a potential large buffer to store the vfio_pci_dependent_device of all the affected devices before copying them to userspace.
--- drivers/vfio/pci/vfio_pci_core.c | 93 ++++++++++++-------------------- 1 file changed, 33 insertions(+), 60 deletions(-)
drivers/vfio/pci/vfio_pci_core.c +33 -60
@@ -777,19 +777,25 @@ static int vfio_pci_count_devs(struct pci_dev *pdev, void *data) }struct vfio_pci_fill_info { -int max; -int cur; -struct vfio_pci_dependent_device *devices; +struct vfio_pci_dependent_device __user *devices; +struct vfio_pci_dependent_device __user *devices_end;struct vfio_device *vdev; +u32 count;u32 flags; };static int vfio_pci_fill_devs (struct pci_dev *pdev,void *data) { +struct vfio_pci_dependent_device info = { + .segment =pci_domain_nr (pdev->bus), + .bus = pdev->bus->number, + .devfn = pdev->devfn, + };struct vfio_pci_fill_info *fill = data; -if (fill->cur == fill->max) -return -EAGAIN ;/* Something changed, try again */ + fill->count++; +if (fill->devices >= fill->devices_end) +return 0 ;if (fill->flags &VFIO_PCI_HOT_RESET_FLAG_DEV_ID ) {struct iommufd_ctx *iommufd =vfio_iommufd_device_ictx (fill->vdev);
@@ -802,19 +808,19 @@ static int vfio_pci_fill_devs(struct pci_dev *pdev, void *data)*/ vdev =vfio_find_device_in_devset (dev_set, &pdev->dev);if (!vdev) { - fill->devices[fill->cur].devid =VFIO_PCI_DEVID_NOT_OWNED ; + info.devid =VFIO_PCI_DEVID_NOT_OWNED ; }else {int id =vfio_iommufd_get_dev_id (vdev, iommufd);if (id >0 ) - fill->devices[fill->cur].devid = id; + info.devid = id;else if (id == -ENOENT ) - fill->devices[fill->cur].devid =VFIO_PCI_DEVID_OWNED ; + info.devid =VFIO_PCI_DEVID_OWNED ;else - fill->devices[fill->cur].devid =VFIO_PCI_DEVID_NOT_OWNED ; + info.devid =VFIO_PCI_DEVID_NOT_OWNED ; }/* If devid is VFIO_PCI_DEVID_NOT_OWNED, clear owned flag. */ -if (fill->devices[fill->cur].devid ==VFIO_PCI_DEVID_NOT_OWNED ) +if (info.devid ==VFIO_PCI_DEVID_NOT_OWNED ) fill->flags &= ~VFIO_PCI_HOT_RESET_FLAG_DEV_ID_OWNED ; }else {struct iommu_group *iommu_group;
@@ -823,13 +829,13 @@ static int vfio_pci_fill_devs(struct pci_dev *pdev, void *data)if (!iommu_group)return -EPERM ;/* Cannot reset non-isolated devices */ - fill->devices[fill->cur].group_id =iommu_group_id (iommu_group); + info.group_id =iommu_group_id (iommu_group);iommu_group_put (iommu_group); } - fill->devices[fill->cur].segment =pci_domain_nr (pdev->bus); - fill->devices[fill->cur].bus = pdev->bus->number; - fill->devices[fill->cur].devfn = pdev->devfn; - fill->cur++; + +if (copy_to_user (fill->devices, &info,sizeof (info))) +return -EFAULT ; + fill->devices++;return 0 ; }
@@ -1221,8 +1227,7 @@ static int vfio_pci_ioctl_get_pci_hot_reset_info(unsigned long minsz = offsetofend(struct vfio_pci_hot_reset_info, count);struct vfio_pci_hot_reset_info hdr; -struct vfio_pci_fill_info fill = {0 }; -struct vfio_pci_dependent_device *devices =NULL ; +struct vfio_pci_fill_info fill = {};bool slot = false;int ret =0 ;
@@ -1240,29 +1245,9 @@ static int vfio_pci_ioctl_get_pci_hot_reset_info(else if (pci_probe_reset_bus (vdev->pdev->bus))return -ENODEV ; -/* How many devices are affected? */ - ret =vfio_pci_for_each_slot_or_bus (vdev->pdev, vfio_pci_count_devs, - &fill.max, slot); -if (ret) -return ret; - -WARN_ON (!fill.max);/* Should always be at least one */ - -/* -* If there's enough space, fill it now, otherwise return -ENOSPC and -* the number of devices affected. -*/ -if (hdr.argsz <sizeof (hdr) + (fill.max *sizeof (*devices))) { - ret = -ENOSPC ; - hdr.count = fill.max; - goto reset_info_exit; - } - - devices =kcalloc (fill.max,sizeof (*devices),GFP_KERNEL ); -if (!devices) -return -ENOMEM ; - - fill.devices = devices; + fill.devices = arg->devices; + fill.devices_end = arg->devices + + (hdr.argsz -sizeof (hdr)) /sizeof (arg->devices[0 ]); fill.vdev = &vdev->vdev;if (vfio_device_cdev_opened (&vdev->vdev))
@@ -1273,29 +1258,17 @@ static int vfio_pci_ioctl_get_pci_hot_reset_info( ret =vfio_pci_for_each_slot_or_bus (vdev->pdev, vfio_pci_fill_devs, &fill, slot);mutex_unlock (&vdev->vdev.dev_set->lock); +if (ret) +return ret; -/* -* If a device was removed between counting and filling, we may come up -* short of fill.max. If a device was added, we'll have a return of -* -EAGAIN above. -*/ -if (!ret) { - hdr.count = fill.cur; - hdr.flags = fill.flags; - } - -reset_info_exit: + hdr.count = fill.count; + hdr.flags = fill.flags;if (copy_to_user (arg, &hdr, minsz)) - ret = -EFAULT ; - -if (!ret) { -if (copy_to_user (&arg->devices, devices, - hdr.count *sizeof (*devices))) - ret = -EFAULT ; - } +return -EFAULT ; -kfree (devices); -return ret; +if (fill.count != fill.devices - arg->devices) +return -ENOSPC ; +return 0 ; } static int
Signature · 1 line
2.34.1
PATCH v8 10/10 vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET
In reply to Yi LiuThis is the way user to invoke hot-reset for the devices opened by cdev interface. User should check the flag VFIO_PCI_HOT_RESET_FLAG_DEV_ID_OWNED in the output of VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl before doing hot-reset for cdev devices.
--- drivers/vfio/pci/vfio_pci_core.c | 61 ++++++++++++++++++++++++++------ include/uapi/linux/vfio.h | 21 +++++++++++ 2 files changed, 71 insertions(+), 11 deletions(-)
drivers/vfio/pci/vfio_pci_core.c +50 -11
@@ -181,7 +181,8 @@ static void vfio_pci_probe_mmaps(struct vfio_pci_core_device *vdev)struct vfio_pci_group_info ;static void vfio_pci_dev_set_try_reset (struct vfio_device_set *dev_set);static int vfio_pci_dev_set_hot_reset (struct vfio_device_set *dev_set, -struct vfio_pci_group_info *groups); +struct vfio_pci_group_info *groups, +struct iommufd_ctx *iommufd_ctx);/* * INTx masking requires the ability to disable INTx signaling via PCI_COMMAND
@@ -1291,8 +1292,7 @@ vfio_pci_ioctl_pci_hot_reset_groups(struct vfio_pci_core_device *vdev,if (ret)return ret; -/* Somewhere between 1 and count is OK */ -if (!array_count || array_count > count) +if (array_count > count)return -EINVAL ; group_fds =kcalloc (array_count,sizeof (*group_fds),GFP_KERNEL );
@@ -1341,7 +1341,7 @@ vfio_pci_ioctl_pci_hot_reset_groups(struct vfio_pci_core_device *vdev, info.count = array_count; info.files = files; - ret =vfio_pci_dev_set_hot_reset (vdev->vdev.dev_set, &info); + ret =vfio_pci_dev_set_hot_reset (vdev->vdev.dev_set, &info,NULL ); hot_reset_release:for (file_idx--; file_idx >=0 ; file_idx--)
@@ -1364,13 +1364,21 @@ static int vfio_pci_ioctl_pci_hot_reset(struct vfio_pci_core_device *vdev,if (hdr.argsz < minsz || hdr.flags)return -EINVAL ; +/* zero-length array is only for cdev opened devices */ +if (!!hdr.count ==vfio_device_cdev_opened (&vdev->vdev)) +return -EINVAL ; +/* Can we do a slot or bus reset or neither? */ if (!pci_probe_reset_slot (vdev->pdev->slot)) slot = true;else if (pci_probe_reset_bus (vdev->pdev->bus))return -ENODEV ; -return vfio_pci_ioctl_pci_hot_reset_groups (vdev, hdr.count, slot, arg); +if (hdr.count) +return vfio_pci_ioctl_pci_hot_reset_groups (vdev, hdr.count, slot, arg); + +return vfio_pci_dev_set_hot_reset (vdev->vdev.dev_set,NULL , +vfio_iommufd_device_ictx (&vdev->vdev)); } static int vfio_pci_ioctl_ioeventfd(struct vfio_pci_core_device *vdev,
@@ -2338,13 +2346,16 @@ const struct pci_error_handlers vfio_pci_core_err_handlers = { };EXPORT_SYMBOL_GPL (vfio_pci_core_err_handlers); -static bool vfio_dev_in_groups (struct vfio_pci_core_device *vdev, +static bool vfio_dev_in_groups (struct vfio_device *vdev,struct vfio_pci_group_info *groups) {unsigned int i; +if (!groups) +return false; +for (i =0 ; i < groups->count; i++) -if (vfio_file_has_dev (groups->files[i], &vdev->vdev)) +if (vfio_file_has_dev (groups->files[i], vdev))return true;return false; }
@@ -2420,7 +2431,8 @@ static int vfio_pci_dev_set_pm_runtime_get(struct vfio_device_set *dev_set)* get each memory_lock. */ static int vfio_pci_dev_set_hot_reset (struct vfio_device_set *dev_set, -struct vfio_pci_group_info *groups) +struct vfio_pci_group_info *groups, +struct iommufd_ctx *iommufd_ctx) {struct vfio_pci_core_device *cur_mem;struct vfio_pci_core_device *cur_vma;
@@ -2450,11 +2462,38 @@ static int vfio_pci_dev_set_hot_reset(struct vfio_device_set *dev_set, goto err_unlock;list_for_each_entry (cur_vma, &dev_set->device_list, vdev.dev_set_list) { +bool owned; +/* -* Test whether all the affected devices are contained by the -* set of groups provided by the user. +* Test whether all the affected devices can be reset by the +* user. +* +* If called from a group opened device and the user provides +* a set of groups, all the devices in the dev_set should be +* contained by the set of groups provided by the user. +* +* If called from a cdev opened device and the user provides +* a zero-length array, all the devices in the dev_set must +* be bound to the same iommufd_ctx as the input iommufd_ctx. +* If there is any device that has not been bound to any +* iommufd_ctx yet, check if its iommu_group has any device +* bound to the input iommufd_ctx. Such devices can be +* considered owned by the input iommufd_ctx as the device +* cannot be owned by another iommufd_ctx when its iommu_group +* is owned. +* +* Otherwise, reset is not allowed. */ -if (!vfio_dev_in_groups (cur_vma, groups)) { +if (iommufd_ctx) { +int devid =vfio_iommufd_get_dev_id (&cur_vma->vdev, + iommufd_ctx); + + owned = (devid >0 || devid == -ENOENT ); + }else { + owned =vfio_dev_in_groups (&cur_vma->vdev, groups); + } + +if (!owned) { ret = -EINVAL ; goto err_undo; }
include/uapi/linux/vfio.h +21 -0
@@ -693,6 +693,9 @@ enum {* affected devices are represented in the dev_set and also owned by * the user. This flag is available only when * flag VFIO_PCI_HOT_RESET_FLAG_DEV_ID is set, otherwise reserved. +* When set, user could invoke VFIO_DEVICE_PCI_HOT_RESET with a zero +* length fd array on the calling device as the ownership is validated +* by iommufd_ctx. * * Return: 0 on success, -errno on failure: * -enospc = insufficient buffer, -enodev = unsupported for device.
@@ -724,6 +727,24 @@ struct vfio_pci_hot_reset_info {* VFIO_DEVICE_PCI_HOT_RESET - _IOW(VFIO_TYPE, VFIO_BASE + 13, * struct vfio_pci_hot_reset) * +* A PCI hot reset results in either a bus or slot reset which may affect +* other devices sharing the bus/slot. The calling user must have +* ownership of the full set of affected devices as determined by the +* VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl. +* +* When called on a device file descriptor acquired through the vfio +* group interface, the user is required to provide proof of ownership +* of those affected devices via the group_fds array in struct +* vfio_pci_hot_reset. +* +* When called on a direct cdev opened vfio device, the flags field of +* struct vfio_pci_hot_reset_info reports the ownership status of the +* affected devices and this ioctl must be called with an empty group_fds +* array. See above INFO ioctl definition for ownership requirements. +* +* Mixed usage of legacy groups and cdevs across the set of affected +* devices is not supported. +* * Return: 0 on success, -errno on failure. */ struct vfio_pci_hot_reset {
Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enhance vfio PCI hot reset for vfio cdev device (rev8)
In reply to Yi Liu== Series Details ==
== Series Details ==
Series: Enhance vfio PCI hot reset for vfio cdev device (rev8)
URL : https://patchwork.freedesktop.org/series/116991/
State : warning
== Summary ==
Error: dim checkpatch failedbbf7d5109b70 vfio/pci: Update comment around group_fd get in vfio_pci_ioctl_pci_hot_reset() 20a69119fe6e vfio/pci: Move the existing hot reset logic to be a helper
-:6: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #6:
This prepares to add another method for hot reset. The major hot reset logic
total: 0 errors, 1 warnings, 0 checks, 99 lines checked5827269728db iommufd: Reserve all negative IDs in the iommufd xarray7f95aa488081 iommufd: Add iommufd_ctx_has_group()fe3e3a790452 iommufd: Add helper to retrieve iommufd_ctx and devid97e3dbafa2d7 vfio: Mark cdev usage in vfio_device
-:8: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #8:
cdev path yet, so the vfio_device_cdev_opened() helper always returns false.
total: 0 errors, 1 warnings, 0 checks, 11 lines checked
046903816932 vfio: Add helper to search vfio_device in a dev_set 8d8bcf84cee9 vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev 5f281038039a vfio/pci: Copy hot-reset device info to userspace in the devices loop f4eff917ccab vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for Enhance vfio PCI hot reset for vfio cdev device (rev8)
In reply to Yi Liu== Series Details ==
== Series Details ==
Series: Enhance vfio PCI hot reset for vfio cdev device (rev8)
URL : https://patchwork.freedesktop.org/series/116991/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13277 -> Patchwork_116991v8
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/index.html
Participating hosts (41 -> 41)
------------------------------
Additional (2): bat-rpls-2 bat-atsm-1
Missing (2): fi-snb-2520m fi-pnv-d510
Known issues
------------
Here are the changes found in Patchwork_116991v8 that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- fi-elk-e7500: [FAIL][1] ([i915#8293]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/fi-elk-e7500/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/fi-elk-e7500/boot.html
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-rpls-2: NOTRUN -> [SKIP][3] ([i915#7456])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@[email protected]
* igt@fbdev@read:
- bat-rpls-2: NOTRUN -> [SKIP][4] ([i915#2582]) +4 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@[email protected]
* igt@gem_exec_suspend@basic-s0@smem:
- bat-jsl-1: [PASS][5] -> [ABORT][6] ([i915#5122])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/bat-jsl-1/igt@gem_exec_suspend@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-jsl-1/igt@gem_exec_suspend@[email protected]
* igt@gem_lmem_swapping@verify-random:
- bat-rpls-2: NOTRUN -> [SKIP][7] ([i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@[email protected]
* igt@gem_mmap@basic:
- bat-atsm-1: NOTRUN -> [SKIP][8] ([i915#4083])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-atsm-1/igt@[email protected]
* igt@gem_render_tiled_blits@basic:
- bat-atsm-1: NOTRUN -> [SKIP][9] ([i915#4079]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-atsm-1/igt@[email protected]
* igt@gem_tiled_fence_blits@basic:
- bat-atsm-1: NOTRUN -> [SKIP][10] ([i915#4077]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-atsm-1/igt@[email protected]
* igt@gem_tiled_pread_basic:
- bat-rpls-2: NOTRUN -> [SKIP][11] ([i915#3282])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-rpls-2: NOTRUN -> [SKIP][12] ([i915#7561])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@[email protected]
* igt@i915_pm_rps@basic-api:
- bat-rpls-2: NOTRUN -> [SKIP][13] ([i915#6621])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@[email protected]
- bat-atsm-1: NOTRUN -> [SKIP][14] ([i915#6621])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-atsm-1/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [PASS][15] -> [DMESG-FAIL][16] ([i915#5334])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_mocs:
- bat-mtlp-8: [PASS][17] -> [DMESG-FAIL][18] ([i915#7059])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
- bat-mtlp-6: [PASS][19] -> [DMESG-FAIL][20] ([i915#7059])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: NOTRUN -> [DMESG-FAIL][21] ([i915#4258] / [i915#7913])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@slpc:
- bat-rpls-2: NOTRUN -> [DMESG-WARN][22] ([i915#6367])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@i915_selftest@[email protected]
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-rpls-2: NOTRUN -> [ABORT][23] ([i915#6687] / [i915#8668])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@[email protected]
* igt@i915_suspend@basic-s3-without-i915:
- bat-atsm-1: NOTRUN -> [SKIP][24] ([i915#6645])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-atsm-1/igt@[email protected]
* igt@kms_addfb_basic@size-max:
- bat-atsm-1: NOTRUN -> [SKIP][25] ([i915#6077]) +36 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-atsm-1/igt@[email protected]
* igt@kms_busy@basic:
- bat-rpls-2: NOTRUN -> [SKIP][26] ([i915#1845]) +14 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@[email protected]
* igt@kms_chamelium_edid@hdmi-edid-read:
- bat-rpls-2: NOTRUN -> [SKIP][27] ([i915#7828]) +7 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- bat-atsm-1: NOTRUN -> [SKIP][28] ([i915#6078]) +19 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-atsm-1/igt@[email protected]
* igt@kms_flip@basic-flip-vs-dpms:
- bat-rpls-2: NOTRUN -> [SKIP][29] ([i915#3637]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@[email protected]
* igt@kms_flip@basic-flip-vs-wf_vblank:
- bat-atsm-1: NOTRUN -> [SKIP][30] ([i915#6166]) +3 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-atsm-1/igt@kms_flip@basic-flip-vs-wf_vblank.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-atsm-1: NOTRUN -> [SKIP][31] ([i915#6093]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-atsm-1/igt@[email protected]
- bat-rpls-2: NOTRUN -> [SKIP][32] ([fdo#109285])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- bat-rpls-2: NOTRUN -> [SKIP][33] ([i915#1849])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1:
- bat-dg2-8: [PASS][34] -> [FAIL][35] ([i915#7932]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
* igt@kms_pipe_crc_basic@read-crc-frame-sequence:
- bat-atsm-1: NOTRUN -> [SKIP][36] ([i915#1836]) +6 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-atsm-1/igt@[email protected]
* igt@kms_prop_blob@basic:
- bat-atsm-1: NOTRUN -> [SKIP][37] ([i915#7357])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-atsm-1/igt@[email protected]
* igt@kms_psr@cursor_plane_move:
- fi-elk-e7500: NOTRUN -> [SKIP][38] ([fdo#109271]) +29 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/fi-elk-e7500/igt@kms_psr@cursor_plane_move.html
* igt@kms_psr@sprite_plane_onoff:
- bat-rpls-2: NOTRUN -> [SKIP][39] ([i915#1072]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@kms_psr@sprite_plane_onoff.html
- bat-atsm-1: NOTRUN -> [SKIP][40] ([i915#1072]) +3 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-atsm-1/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rpls-2: NOTRUN -> [SKIP][41] ([i915#3555] / [i915#4579])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@[email protected]
- bat-atsm-1: NOTRUN -> [SKIP][42] ([i915#6094])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-atsm-1/igt@[email protected]
- fi-elk-e7500: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#4579])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/fi-elk-e7500/igt@[email protected]
* igt@prime_vgem@basic-fence-flip:
- bat-atsm-1: NOTRUN -> [SKIP][44] ([fdo#109295] / [i915#6078])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-atsm-1/igt@[email protected]
- bat-rpls-2: NOTRUN -> [SKIP][45] ([fdo#109295] / [i915#1845] / [i915#3708])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@[email protected]
* igt@prime_vgem@basic-gtt:
- bat-atsm-1: NOTRUN -> [SKIP][46] ([fdo#109295] / [i915#4077]) +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-atsm-1/igt@[email protected]
* igt@prime_vgem@basic-write:
- bat-rpls-2: NOTRUN -> [SKIP][47] ([fdo#109295] / [i915#3708]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rpls-2/igt@[email protected]
- bat-atsm-1: NOTRUN -> [SKIP][48] ([fdo#109295]) +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-atsm-1/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [DMESG-FAIL][49] ([i915#5334] / [i915#7872]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_flip@basic-flip-vs-dpms@d-dp1:
- bat-adlp-9: [FAIL][51] ([i915#7655]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/bat-adlp-9/igt@kms_flip@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-adlp-9/igt@kms_flip@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:
- bat-dg2-8: [FAIL][53] ([i915#7932]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
#### Warnings ####
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rplp-1: [SKIP][55] ([i915#3555] / [i915#4579]) -> [ABORT][56] ([i915#4579] / [i915#8260])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/bat-rplp-1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/bat-rplp-1/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077
[i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
[i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093
[i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094
[i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7655]: https://gitlab.freedesktop.org/drm/intel/issues/7655
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260
[i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
Build changes
-------------
* Linux: CI_DRM_13277 -> Patchwork_116991v8
CI-20190529: 20190529
CI_DRM_13277: 0746134e3453e38027b217dba18f922fba7966cd @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7332: 2a25a6109e8af4b0a69a717cc8710dcafed4bb4c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_116991v8: 0746134e3453e38027b217dba18f922fba7966cd @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
9098d85be150 vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET f0b8c6dae863 vfio/pci: Copy hot-reset device info to userspace in the devices loop 2824241ee372 vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev d9699a44fcea vfio: Add helper to search vfio_device in a dev_set 9c16fe2f683e vfio: Mark cdev usage in vfio_deviced2a1ba3fa613 iommufd: Add helper to retrieve iommufd_ctx and devid e3f7aa6e9ee8 iommufd: Add iommufd_ctx_has_group()6700edcbc52e iommufd: Reserve all negative IDs in the iommufd xarray 5782ffcdacf4 vfio/pci: Move the existing hot reset logic to be a helper 9fb2b5a89abe vfio/pci: Update comment around group_fd get in vfio_pci_ioctl_pci_hot_reset()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for Enhance vfio PCI hot reset for vfio cdev device (rev8)
In reply to Yi Liu== Series Details ==
== Series Details ==
Series: Enhance vfio PCI hot reset for vfio cdev device (rev8)
URL : https://patchwork.freedesktop.org/series/116991/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13277_full -> Patchwork_116991v8_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_116991v8_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_116991v8_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_116991v8_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_vblank@pipe-c-accuracy-idle:
- shard-glk: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-glk8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-glk6/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_116991v8_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- shard-rkl: [PASS][3] -> [FAIL][4] ([i915#7742])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-rkl-6/igt@drm_fdinfo@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-rkl-7/igt@drm_fdinfo@[email protected]
* igt@gem_barrier_race@remote-request@rcs0:
- shard-glk: [PASS][5] -> [ABORT][6] ([i915#7461] / [i915#8211])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-glk5/igt@gem_barrier_race@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-glk5/igt@gem_barrier_race@[email protected]
* igt@gem_eio@hibernate:
- shard-tglu: [PASS][7] -> [ABORT][8] ([i915#7975] / [i915#8213] / [i915#8398])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-tglu-7/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-tglu-10/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglu: [PASS][9] -> [FAIL][10] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-tglu-3/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-tglu-2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-rkl: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-rkl-1/igt@gem_exec_fair@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-rkl-4/igt@gem_exec_fair@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-tglu: [PASS][13] -> [FAIL][14] ([i915#3989] / [i915#454])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-tglu-4/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-tglu-3/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- shard-tglu: [PASS][15] -> [SKIP][16] ([i915#4281])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-tglu-9/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-tglu-6/igt@[email protected]
* igt@i915_pm_rpm@dpms-lpsp:
- shard-rkl: [PASS][17] -> [SKIP][18] ([i915#1397]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-rkl-7/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-rkl-1/igt@[email protected]
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-2-y-rc_ccs:
- shard-rkl: NOTRUN -> [SKIP][19] ([i915#8502]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-rkl-1/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-2-y-rc_ccs.html
* igt@kms_ccs@pipe-d-bad-aux-stride-4_tiled_mtl_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][20] ([fdo#109271]) +27 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-glk8/igt@kms_ccs@pipe-d-bad-aux-stride-4_tiled_mtl_mc_ccs.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#2346])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-glk9/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-glk4/igt@[email protected]
* igt@kms_cursor_legacy@forked-move@pipe-b:
- shard-rkl: [PASS][23] -> [INCOMPLETE][24] ([i915#8011])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-rkl-1/igt@kms_cursor_legacy@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-rkl-7/igt@kms_cursor_legacy@[email protected]
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#4579]) +11 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-snb1/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][26] ([i915#4579] / [i915#5176]) +3 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-rkl-1/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-c-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#4579]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-glk8/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-c-hdmi-a-1.html
* igt@kms_plane_scaling@plane-upscale-with-rotation-20x20@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][28] ([i915#5176]) +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-rkl-7/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][29] ([i915#5235])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-rkl-7/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][30] ([i915#4579] / [i915#5235])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-rkl-7/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-downscale-factor-0-75-unity-scaling@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][31] ([fdo#109271]) +14 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-snb4/igt@kms_plane_scaling@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-glk: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#658])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-glk8/igt@[email protected]
#### Possible fixes ####
* igt@gem_barrier_race@remote-request@rcs0:
- {shard-dg1}: [ABORT][33] ([i915#7461] / [i915#8234]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-dg1-17/igt@gem_barrier_race@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-dg1-12/igt@gem_barrier_race@[email protected]
* igt@gem_eio@unwedge-stress:
- {shard-dg1}: [FAIL][35] ([i915#5784]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-dg1-19/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-dg1-17/igt@[email protected]
* igt@gem_exec_endless@dispatch@vcs1:
- shard-tglu: [TIMEOUT][37] ([i915#3778]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-tglu-10/igt@gem_exec_endless@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-tglu-2/igt@gem_exec_endless@[email protected]
* igt@gem_exec_fair@basic-none@bcs0:
- shard-rkl: [FAIL][39] ([i915#2842]) -> [PASS][40] +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-rkl-1/igt@gem_exec_fair@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-rkl-4/igt@gem_exec_fair@[email protected]
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-rkl: [SKIP][41] ([i915#1937] / [i915#4579]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-rkl-6/igt@i915_pm_lpsp@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-rkl-7/igt@i915_pm_lpsp@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- {shard-dg1}: [FAIL][43] ([i915#3591]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-dg1-19/igt@i915_pm_rc6_residency@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-dg1-15/igt@i915_pm_rc6_residency@[email protected]
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-rkl: [SKIP][45] ([i915#1397]) -> [PASS][46] +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-rkl-7/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-rkl-1/igt@[email protected]
* igt@i915_pm_rpm@modeset-lpsp:
- {shard-dg1}: [SKIP][47] ([i915#1397]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-dg1-16/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-dg1-19/igt@[email protected]
* igt@i915_suspend@basic-s3-without-i915:
- shard-rkl: [FAIL][49] ([fdo#103375]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-rkl-3/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-rkl-2/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-tglu: [FAIL][51] ([i915#3743]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-tglu-6/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-tglu-8/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- {shard-dg1}: [FAIL][53] ([i915#3743] / [i915#7959]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-dg1-19/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-dg1-15/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [FAIL][55] ([i915#2346]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
- shard-glk: [FAIL][57] ([i915#2346]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1:
- shard-apl: [FAIL][59] ([i915#79]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-apl6/igt@kms_flip@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-apl3/igt@kms_flip@[email protected]
#### Warnings ####
* igt@kms_fbcon_fbt@psr-suspend:
- shard-rkl: [SKIP][61] ([fdo#110189] / [i915#3955]) -> [SKIP][62] ([i915#3955])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13277/shard-rkl-1/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/shard-rkl-6/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7959]: https://gitlab.freedesktop.org/drm/intel/issues/7959
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8398]: https://gitlab.freedesktop.org/drm/intel/issues/8398
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
Build changes
-------------
* Linux: CI_DRM_13277 -> Patchwork_116991v8
CI-20190529: 20190529
CI_DRM_13277: 0746134e3453e38027b217dba18f922fba7966cd @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7332: 2a25a6109e8af4b0a69a717cc8710dcafed4bb4c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_116991v8: 0746134e3453e38027b217dba18f922fba7966cd @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116991v8/index.html