tpm: remove redundant variable len
Subsystems (3)
PATCH 1/1 tpm: remove redundant variable len
Variable len is being accumulated but the value is never read. It is redundant and can be removed. Cleans up clang scan build warning:
drivers/char/tpm/eventlog/tpm1.c:276:2: warning: Value stored to 'len' is never read [deadcode.DeadStores]
--- drivers/char/tpm/eventlog/tpm1.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/char/tpm/eventlog/tpm1.c +1 -2
@@ -251,7 +251,6 @@ static int tpm1_binary_bios_measurements_show(struct seq_file *m, void *v)static int tpm1_ascii_bios_measurements_show (struct seq_file *m,void *v) { -int len =0 ;char *eventname;struct tcpa_event *event = v; unsigned char *event_entry =
@@ -273,7 +272,7 @@ static int tpm1_ascii_bios_measurements_show(struct seq_file *m, void *v)/* 3rd: event type identifier */ seq_printf (m," %02x" ,do_endian_conversion (event->event_type)); - len +=get_event_name (eventname, event, event_entry); +get_event_name (eventname, event, event_entry);/* 4th: eventname <= max + \'0' delimiter */ seq_printf (m," %s\n" , eventname);
Signature · 1 line
2.39.2
Quoted 6 lines · Colin Ian King
Variable len is being accumulated but the value is never read. It is redundant and can be removed. Cleans up clang scan build warning:
drivers/char/tpm/eventlog/tpm1.c:276:2: warning: Value stored to 'len' is never read [deadcode.DeadStores]Signed-off-by Colin Ian King <[email protected]>
Quoted 28 lines
--- drivers/char/tpm/eventlog/tpm1.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/char/tpm/eventlog/tpm1.c +1
-2@@ -251,7 +251,6 @@ static int tpm1_binary_bios_measurements_show(struct seq_file *m, void *v)static int tpm1_ascii_bios_measurements_show (struct seq_file *m,void *v) { -int len =0 ;char *eventname;struct tcpa_event *event = v; unsigned char *event_entry =@@ -273,7 +272,7 @@ static int tpm1_ascii_bios_measurements_show(struct seq_file *m, void *v)/* 3rd: event type identifier */ seq_printf (m," %02x" ,do_endian_conversion (event->event_type)); - len +=get_event_name (eventname, event, event_entry); +get_event_name (eventname, event, event_entry);/* 4th: eventname <= max + \'0' delimiter */ seq_printf (m," %s\n" , eventname);Signature · 1 line
2.39.2
Quoted 33 lines · Colin Ian King
Variable len is being accumulated but the value is never read. It is redundant and can be removed. Cleans up clang scan build warning:
drivers/char/tpm/eventlog/tpm1.c:276:2: warning: Value stored to 'len' is never read [deadcode.DeadStores]Signed-off-by Colin Ian King <[email protected]>--- drivers/char/tpm/eventlog/tpm1.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/char/tpm/eventlog/tpm1.c +1
-2@@ -251,7 +251,6 @@ static int tpm1_binary_bios_measurements_show(struct seq_file *m, void *v)static int tpm1_ascii_bios_measurements_show (struct seq_file *m,void *v) { -int len =0 ;char *eventname;struct tcpa_event *event = v; unsigned char *event_entry =@@ -273,7 +272,7 @@ static int tpm1_ascii_bios_measurements_show(struct seq_file *m, void *v)/* 3rd: event type identifier */ seq_printf (m," %02x" ,do_endian_conversion (event->event_type)); - len +=get_event_name (eventname, event, event_entry); +get_event_name (eventname, event, event_entry);/* 4th: eventname <= max + \'0' delimiter */ seq_printf (m," %s\n" , eventname);Signature · 1 line
2.39.2
BR, Jarkko