drm/i915/mtl: Skip using vbt hdmi_level_shifter selection on MTL
Subsystems (3)
PATCH 1/1 drm/i915/mtl: Skip using vbt hdmi_level_shifter selection on MTL
The hdmi_level_shifter part of General Bytes definition in VBT, which was used for choosing different levels on earlier platforms is now a hidden optin and shows the default value of 0. The level shifter is now to be deduced from hdmi_default_entry in intel_ddi_buf_trans for each phy.
Skip providing the default hw provided value to force driver to choose hdmi default entry.
Bspec: 20124
--- drivers/gpu/drm/i915/display/intel_bios.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_bios.c +2 -1
@@ -2615,7 +2615,8 @@ intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data *devdata)/* This is an index in the HDMI/DVI DDI buffer translation table, or -1 */ int intel_bios_hdmi_level_shift (const struct intel_bios_encoder_data *devdata) { -if (!devdata || devdata->i915->display.vbt.version <158 ) +if (!devdata || devdata->i915->display.vbt.version <158 || +DISPLAY_VER (devdata->i915) >=14 )return -1 ;return devdata->child.hdmi_level_shifter_value;
Signature · 1 line
2.34.1
Quoted 23 lines · Radhakrishna Sripada
The
hdmi_level_shifterpart of General Bytes definition in VBT, which was used for choosing different levels on earlier platforms is now a hidden optin and shows the default value of 0. The level shifter is now to be deduced fromhdmi_default_entryinintel_ddi_buf_transfor each phy.Skip providing the default hw provided value to force driver to choose hdmi default entry.
Bspec: 20124
Cc Khaled Almahallawy <[email protected]>Cc Lee Shawn C <[email protected]>Cc Clint Taylor <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>--- drivers/gpu/drm/i915/display/intel_bios.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_bios.c +0
-0
drivers/gpu/drm/i915/display/intel_bios.c intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data · line 2622
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_bios.c +2
-1@@ -2615,7 +2615,8 @@ intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data *devdata)/* This is an index in the HDMI/DVI DDI buffer translation table, or -1 */ int intel_bios_hdmi_level_shift (const struct intel_bios_encoder_data *devdata) { -if (!devdata || devdata->i915->display.vbt.version <158 ) +if (!devdata || devdata->i915->display.vbt.version <158 || +DISPLAY_VER (devdata->i915) >=14 )return -1 ;
-Clint
Quoted 1 line
return
devdata->child.hdmi_level_shifter_value;
Merged. Thank you for the review.
--Radhakrishna(RK) Sripada
Quoted 50 lines
-----Original Message-----
From: Taylor, Clinton A <[email protected]>
Sent: Tuesday, June 20, 2023 2:10 PM
To: Sripada, Radhakrishna <[email protected]>; intel- [email protected]
Cc: Lee, Shawn C <[email protected]>; Almahallawy, Khaled <[email protected]>
Subject: Re: [PATCH] drm/i915/mtl: Skip using vbthdmi_level_shifterselection on MTLdrivers/gpu/drm/i915/display/intel_bios.c intel_bios_encoder_is_lspcon(const struct
Quoted 23 lines · Radhakrishna Sripada
The
hdmi_level_shifterpart of General Bytes definition in VBT, which was used for choosing different levels on earlier platforms is now a hidden optin and shows the default value of 0. The level shifter is now to be deduced fromhdmi_default_entryinintel_ddi_buf_transfor each phy.Skip providing the default hw provided value to force driver to choose hdmi default entry.
Bspec: 20124
Cc Khaled Almahallawy <[email protected]>Cc Lee Shawn C <[email protected]>Cc Clint Taylor <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>--- drivers/gpu/drm/i915/display/intel_bios.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_bios.c +0
-0@@ -2615,7 +2615,8 @@ intel_bios_encoder_is_lspcon(const struct
intel_bios_encoder_datadrivers/gpu/drm/i915/display/intel_bios.c intel_bios_encoder_is_lspcon(const struct · line 2617
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_bios.c +0
-0*devdata)/* This is an index in the HDMI/DVI DDI buffer translation table, or -1 */ int intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data*devdata)
drivers/gpu/drm/i915/display/intel_bios.c intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data *devdata) · line 2621
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_bios.c +2
-1{ -if (!devdata || devdata->i915->display.vbt.version <158 ) +if (!devdata || devdata->i915->display.vbt.version <158 || +DISPLAY_VER (devdata->i915) >=14 )return -1 ;Reviewed-by Clint Taylor <[email protected]>-Clint
Quoted 1 line
return
devdata->child.hdmi_level_shifter_value;
Jani Nikula
maintainerQuoted 1 line · Radhakrishna
Merged. Thank you for the review.
Where are the CI results?
Please never merge patches without CI results.
BR,
Jani.
Quoted 53 lines
--Radhakrishna(RK) Sripada
Quoted 50 lines
-----Original Message-----
From: Taylor, Clinton A <[email protected]>
Sent: Tuesday, June 20, 2023 2:10 PM
To: Sripada, Radhakrishna <[email protected]>; intel- [email protected]
Cc: Lee, Shawn C <[email protected]>; Almahallawy, Khaled <[email protected]>
Subject: Re: [PATCH] drm/i915/mtl: Skip using vbthdmi_level_shifterselection on MTLdrivers/gpu/drm/i915/display/intel_bios.c intel_bios_encoder_is_lspcon(const struct
Quoted 23 lines · Radhakrishna Sripada
The
hdmi_level_shifterpart of General Bytes definition in VBT, which was used for choosing different levels on earlier platforms is now a hidden optin and shows the default value of 0. The level shifter is now to be deduced fromhdmi_default_entryinintel_ddi_buf_transfor each phy.Skip providing the default hw provided value to force driver to choose hdmi default entry.
Bspec: 20124
Cc Khaled Almahallawy <[email protected]>Cc Lee Shawn C <[email protected]>Cc Clint Taylor <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>--- drivers/gpu/drm/i915/display/intel_bios.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_bios.c +0
-0@@ -2615,7 +2615,8 @@ intel_bios_encoder_is_lspcon(const struct
intel_bios_encoder_datadrivers/gpu/drm/i915/display/intel_bios.c intel_bios_encoder_is_lspcon(const struct · line 2617
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_bios.c +0
-0*devdata)/* This is an index in the HDMI/DVI DDI buffer translation table, or -1 */ int intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data*devdata)
drivers/gpu/drm/i915/display/intel_bios.c intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data *devdata) · line 2621
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_bios.c +2
-1{ -if (!devdata || devdata->i915->display.vbt.version <158 ) +if (!devdata || devdata->i915->display.vbt.version <158 || +DISPLAY_VER (devdata->i915) >=14 )return -1 ;Reviewed-by Clint Taylor <[email protected]>-Clint
Quoted 1 line
return
devdata->child.hdmi_level_shifter_value;
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Quoted 10 lines
-----Original Message-----
From: Jani Nikula <[email protected]>
Sent: Wednesday, June 21, 2023 12:32 AM
To: Sripada, Radhakrishna <[email protected]>; Taylor, Clinton A <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Skip using vbthdmi_level_shifterselection on MTL
Quoted 7 lines
Quoted 1 line · Radhakrishna
Merged. Thank you for the review.
Where are the CI results?
Please never merge patches without CI results.
Apologies Jani. Overlooked the green as CI results as the patch was sent 3 days ago. Let me trigger a fresh CI run.
Will keep this in mind for future.
--Radhakrishna(RK) Sripada
Quoted 61 lines
BR,
Jani.Quoted 11 lines
--Radhakrishna(RK) Sripada
Quoted 8 lines
-----Original Message-----
From: Taylor, Clinton A <[email protected]>
Sent: Tuesday, June 20, 2023 2:10 PM
To: Sripada, Radhakrishna <[email protected]>; intel- [email protected]
Cc: Lee, Shawn C <[email protected]>; Almahallawy, Khaled <[email protected]>
Subject: Re: [PATCH] drm/i915/mtl: Skip using vbthdmi_level_shifterselection
Quoted 39 lines
Quoted 39 lines
on MTL
drivers/gpu/drm/i915/display/intel_bios.c intel_bios_encoder_is_lspcon(const struct
Quoted 23 lines · Radhakrishna Sripada
The
hdmi_level_shifterpart of General Bytes definition in VBT, which was used for choosing different levels on earlier platforms is now a hidden optin and shows the default value of 0. The level shifter is now to be deduced fromhdmi_default_entryinintel_ddi_buf_transfor each phy.Skip providing the default hw provided value to force driver to choose hdmi default entry.
Bspec: 20124
Cc Khaled Almahallawy <[email protected]>Cc Lee Shawn C <[email protected]>Cc Clint Taylor <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>--- drivers/gpu/drm/i915/display/intel_bios.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_bios.c +0
-0@@ -2615,7 +2615,8 @@ intel_bios_encoder_is_lspcon(const struct
intel_bios_encoder_datadrivers/gpu/drm/i915/display/intel_bios.c intel_bios_encoder_is_lspcon(const struct · line 2617
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_bios.c +0
-0*devdata)/* This is an index in the HDMI/DVI DDI buffer translation table, or -1 */ int intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data*devdata)
drivers/gpu/drm/i915/display/intel_bios.c intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data *devdata) · line 2621
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_bios.c +2
-1{ -if (!devdata || devdata->i915->display.vbt.version <158 ) +if (!devdata || devdata->i915->display.vbt.version <158 || +DISPLAY_VER (devdata->i915) >=14 )return -1 ;Reviewed-by Clint Taylor <[email protected]>Quoted 3 lines
Quoted 3 lines
-Clint
Quoted 1 line
return
devdata->child.hdmi_level_shifter_value;--
Jani Nikula, Intel Open Source Graphics Center
Jani Nikula
maintainerQuoted 8 lines · Radhakrishna
Quoted 8 lines
-----Original Message-----
From: Jani Nikula <[email protected]>
Sent: Wednesday, June 21, 2023 12:32 AM
To: Sripada, Radhakrishna <[email protected]>; Taylor, Clinton A <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Skip using vbthdmi_level_shifterselection on MTL
Quoted 8 lines
Quoted 7 lines
Quoted 1 line · Radhakrishna
Merged. Thank you for the review.
Where are the CI results?
Please never merge patches without CI results.
Apologies Jani. Overlooked the green as CI results as the patch was sent 3 days ago. Let me trigger a fresh CI run.
The fresh run will fail because it can no longer apply the patch, as it's in the baseline already.
Quoted 1 line
Will keep this in mind for future.
Thanks,
Jani.
Quoted 64 lines
--Radhakrishna(RK) Sripada
Quoted 61 lines
BR,
Jani.Quoted 11 lines
--Radhakrishna(RK) Sripada
Quoted 8 lines
-----Original Message-----
From: Taylor, Clinton A <[email protected]>
Sent: Tuesday, June 20, 2023 2:10 PM
To: Sripada, Radhakrishna <[email protected]>; intel- [email protected]
Cc: Lee, Shawn C <[email protected]>; Almahallawy, Khaled <[email protected]>
Subject: Re: [PATCH] drm/i915/mtl: Skip using vbthdmi_level_shifterselection
Quoted 39 lines
Quoted 39 lines
on MTL
drivers/gpu/drm/i915/display/intel_bios.c intel_bios_encoder_is_lspcon(const struct
Quoted 23 lines · Radhakrishna Sripada
The
hdmi_level_shifterpart of General Bytes definition in VBT, which was used for choosing different levels on earlier platforms is now a hidden optin and shows the default value of 0. The level shifter is now to be deduced fromhdmi_default_entryinintel_ddi_buf_transfor each phy.Skip providing the default hw provided value to force driver to choose hdmi default entry.
Bspec: 20124
Cc Khaled Almahallawy <[email protected]>Cc Lee Shawn C <[email protected]>Cc Clint Taylor <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>--- drivers/gpu/drm/i915/display/intel_bios.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_bios.c +0
-0@@ -2615,7 +2615,8 @@ intel_bios_encoder_is_lspcon(const struct
intel_bios_encoder_datadrivers/gpu/drm/i915/display/intel_bios.c intel_bios_encoder_is_lspcon(const struct · line 2617
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_bios.c +0
-0*devdata)/* This is an index in the HDMI/DVI DDI buffer translation table, or -1 */ int intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data*devdata)
drivers/gpu/drm/i915/display/intel_bios.c intel_bios_encoder_is_lspcon(const struct intel_bios_encoder_data *devdata) · line 2621
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_bios.c +2
-1{ -if (!devdata || devdata->i915->display.vbt.version <158 ) +if (!devdata || devdata->i915->display.vbt.version <158 || +DISPLAY_VER (devdata->i915) >=14 )return -1 ;Reviewed-by Clint Taylor <[email protected]>Quoted 3 lines
Quoted 3 lines
-Clint
Quoted 1 line
return
devdata->child.hdmi_level_shifter_value;--
Jani Nikula, Intel Open Source Graphics Center
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center