Skip to contentSkip to conversation

drm/i915/gt: Remove incorrect hard coded cache coherrency setting

PATCH In review Zhanjun Dong 2 participants 2 messages Jun 16, 2023 – Jun 22, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/gt: Remove incorrect hard coded cache coherrency setting

The previouse i915_gem_object_create_internal already set it with proper value before function return. This hard coded setting is incorrect for platforms like MTL, thus need to be removed.

---
 drivers/gpu/drm/i915/gt/intel_timeline.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/gt/intel_timeline.c +0 -2
index b9640212d659..693d18e14b00 100644
@@ -26,8 +26,6 @@ static struct i915_vma *hwsp_alloc(struct intel_gt *gt)
 	if (IS_ERR(obj))
 		return ERR_CAST(obj);
 
-	i915_gem_object_set_cache_coherency(obj, I915_CACHE_LLC);
-
 	vma = i915_vma_instance(obj, &gt->ggtt->vm, NULL);
 	if (IS_ERR(vma))
 		i915_gem_object_put(obj);
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw

Hi Zhanjun,

please restart the CI, https://patchwork.freedesktop.org/series/119485/

It seems to be stuck.

Quoted 5 lines · Zhanjun Dong

The previouse i915_gem_object_create_internal already set it with proper value before function return. This hard coded setting is incorrect for platforms like MTL, thus need to be removed.

Quoted 17 lines
---
  drivers/gpu/drm/i915/gt/intel_timeline.c | 2 --
  1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/gt/intel_timeline.c +0 -2
index b9640212d659..693d18e14b00 100644
@@ -26,8 +26,6 @@ static struct i915_vma *hwsp_alloc(struct intel_gt *gt)
  	if (IS_ERR(obj))
  		return ERR_CAST(obj);
 
-	i915_gem_object_set_cache_coherency(obj, I915_CACHE_LLC);
-
  	vma = i915_vma_instance(obj, &gt->ggtt->vm, NULL);
  	if (IS_ERR(vma))
  		i915_gem_object_put(obj);