drm/i915/gt: Remove incorrect hard coded cache coherrency setting
Subsystems (2)
PATCH 1/1 drm/i915/gt: Remove incorrect hard coded cache coherrency setting
The previouse i915_gem_object_create_internal already set it with proper value before function return. This hard coded setting is incorrect for platforms like MTL, thus need to be removed.
Signed-off-by Zhanjun Dong <[email protected]>
--- drivers/gpu/drm/i915/gt/intel_timeline.c | 2 -- 1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/gt/intel_timeline.c +0 -2
@@ -26,8 +26,6 @@ static struct i915_vma *hwsp_alloc(struct intel_gt *gt)if (IS_ERR (obj))return ERR_CAST (obj); -i915_gem_object_set_cache_coherency (obj,I915_CACHE_LLC ); - vma =i915_vma_instance (obj, >->ggtt->vm,NULL );if (IS_ERR (vma))i915_gem_object_put (obj);
Signature · 1 line
2.34.1
Hi Zhanjun,
please restart the CI, https://patchwork.freedesktop.org/series/119485/
It seems to be stuck.
Quoted 5 lines · Zhanjun Dong
The previouse
i915_gem_object_create_internalalready set it with proper value before function return. This hard coded setting is incorrect for platforms like MTL, thus need to be removed.Signed-off-by Zhanjun Dong <[email protected]>
Reviewed-by Nirmoy Das <[email protected]>
Quoted 17 lines
--- drivers/gpu/drm/i915/gt/intel_timeline.c | 2 -- 1 file changed, 2 deletions(-)drivers/gpu/drm/i915/gt/intel_timeline.c +0
-2@@ -26,8 +26,6 @@ static struct i915_vma *hwsp_alloc(struct intel_gt *gt)if (IS_ERR (obj))return ERR_CAST (obj); -i915_gem_object_set_cache_coherency (obj,I915_CACHE_LLC ); - vma =i915_vma_instance (obj, >->ggtt->vm,NULL );if (IS_ERR (vma))i915_gem_object_put (obj);