Skip to contentSkip to conversation

iommu/arm-smmu-qcom: Add ACPI entry for HP SC7180 laptop

PATCH In review Mark Harmstone 3 participants 5 messages Jun 17, 2023 – Jun 20, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iommu/arm-smmu-qcom: Add ACPI entry for HP SC7180 laptop

Add an ACPI platform entry for the "HP 4G LTE Laptop 14-eg0xxx", HP's ACPI-based SC7180 laptop.

The relevant lines in the IORT table:

[000h 0000   4]                    Signature : "IORT"    [IO Remapping Table]
[004h 0004   4]                 Table Length : 00000E20
[008h 0008   1]                     Revision : 00
[009h 0009   1]                     Checksum : 73
[00Ah 0010   6]                       Oem ID : "HPQOEM"
[010h 0016   8]                 Oem Table ID : "SLIC-MPC"
[018h 0024   4]                 Oem Revision : 00008913
[01Ch 0028   4]              Asl Compiler ID : "HP  "
[020h 0032   4]        Asl Compiler Revision : 00000001
---
 drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c +1 -0
index c71afda79d64..37760a38c5da 100644
@@ -541,6 +541,7 @@ static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = {
 static struct acpi_platform_list qcom_acpi_platlist[] = {
 	{ "LENOVO", "CB-01   ", 0x8180, ACPI_SIG_IORT, equal, "QCOM SMMU" },
 	{ "QCOM  ", "QCOMEDK2", 0x8180, ACPI_SIG_IORT, equal, "QCOM SMMU" },
+	{ "HPQOEM", "SLIC-MPC", 0x8913, ACPI_SIG_IORT, equal, "QCOM SMMU" },
 	{ }
 };
 #endif
Signature · 7 lines
2.39.3


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines · Mark Harmstone

Add an ACPI platform entry for the "HP 4G LTE Laptop 14-eg0xxx", HP's ACPI-based SC7180 laptop.

The relevant lines in the IORT table:

[000h 0000   4]                    Signature : "IORT"    [IO Remapping Table]
[004h 0004   4]                 Table Length : 00000E20
[008h 0008   1]                     Revision : 00
[009h 0009   1]                     Checksum : 73
[00Ah 0010   6]                       Oem ID : "HPQOEM"
[010h 0016   8]                 Oem Table ID : "SLIC-MPC"
[018h 0024   4]                 Oem Revision : 00008913
[01Ch 0028   4]              Asl Compiler ID : "HP  "
[020h 0032   4]        Asl Compiler Revision : 00000001
Quoted 2 lines

---

Just FYI, ACPI support for Snapdragons isn't very good, as the ACPI tables are very lackluster.. You may want to try using FDT.

Konrad

Quoted 8 lines
 drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c +0 -0
index c71afda79d64..37760a38c5da 100644

drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = { · line 547

Quoted 7 lines
drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c +1 -0
@@ -541,6 +541,7 @@ static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = {
 static struct acpi_platform_list qcom_acpi_platlist[] = {
 	{ "LENOVO", "CB-01   ", 0x8180, ACPI_SIG_IORT, equal, "QCOM SMMU" },
 	{ "QCOM  ", "QCOMEDK2", 0x8180, ACPI_SIG_IORT, equal, "QCOM SMMU" },
+	{ "HPQOEM", "SLIC-MPC", 0x8913, ACPI_SIG_IORT, equal, "QCOM SMMU" },
 	{ }
 };
 #endif

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
Quoted 2 lines · Konrad Dybcio

Just FYI, ACPI support for Snapdragons isn't very good, as the ACPI tables are very lackluster.. You may want to try using FDT.

Thanks Konrad. Yes, I'm realizing that! This is a UEFI machine that comes with Windows 11 - I'm not even sure there is a correct DTS file out there.

I have patches for the MMC and USB to follow this one. Still working on the I2C and WiFi.

Mark

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#3 lore raw
Quoted 7 lines · Mark Harmstone
Quoted 2 lines · Konrad Dybcio

Just FYI, ACPI support for Snapdragons isn't very good, as the ACPI tables are very lackluster.. You may want to try using FDT.

Thanks Konrad. Yes, I'm realizing that! This is a UEFI machine that comes with Windows 11 - I'm not even sure there is a correct DTS file out there.

Well, our job is to make one! :D

Your reply has sparked some ideas in my head to possibly make it even easier..

Quoted 3 lines

I have patches for the MMC and USB to follow this one. Still working on the I2C and WiFi.

Glad to hear things work at all without all! Your power usage will probably be through the roof though, due to lack of bus scaling and overall DVFS syncing :/

Konrad

Quoted 2 lines

Mark

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#4 lore raw
In reply to Mark Harmstone
Quoted 11 lines · Mark Harmstone
Quoted 2 lines · Konrad Dybcio

Just FYI, ACPI support for Snapdragons isn't very good, as the ACPI tables are very lackluster.. You may want to try using FDT.

Thanks Konrad. Yes, I'm realizing that! This is a UEFI machine that comes with Windows 11 - I'm not even sure there is a correct DTS file out there.

I have patches for the MMC and USB to follow this one. Still working on the I2C and WiFi.

Based on past and present efforts I would suggest that you write a DTS instead of trying to teach Linux to work with the tables you have in front of you.

The upstream SC7180 support is quite good, with DeviceTree.

Regards,
Bjorn

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel