base-passwd: fix patchreview warning
PATCH 1/1 base-passwd: fix patchreview warning
From: Alexandre Belloni <[email protected]>
Fix:
Malformed Upstream-Status 'Upstream status' (meta/recipes-core/base-passwd/base-passwd/0007-Add-wheel-group.patch) Unknown Upstream-Status value 'says' (meta/recipes-core/base-passwd/base-passwd/0007-Add-wheel-group.patch)
--- .../base-passwd/base-passwd/0007-Add-wheel-group.patch | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/base-passwd/base-passwd/0007-Add-wheel-group.patch +1 -1
@@ -2,7 +2,7 @@ We need to have a wheel group which has some system privileges to consult the systemd journal or manage printers with cups. -Upstream status says the group does not exist by default. +Upstream says the group does not exist by default. Upstream-Status: Inappropriate [enable feature]
Signature · 1 line
2.40.1
Should the regex that finds these lines be fixed rather? It’s entirely valid to say ‘upstream status’ somewhere, it should be matching ‘Upstream-Status:’ at the start of the line exactly.
Alex
Quoted 45 lines · Alexandre Belloni via lists.openembedded.org
From: Alexandre Belloni <[email protected]>
Fix:
Malformed Upstream-Status 'Upstream status' (
meta/recipes-core/base-passwd/base-passwd/0007-Add-wheel-group.patch) Unknown Upstream-Status value 'says' (meta/recipes-core/base-passwd/base-passwd/0007-Add-wheel-group.patch)Signed-off-by Alexandre Belloni <[email protected]>--- .../base-passwd/base-passwd/0007-Add-wheel-group.patch | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git
a/meta/recipes-core/base-passwd/base-passwd/0007-Add-wheel-group.patchb/meta/recipes-core/base-passwd/base-passwd/0007-Add-wheel-group.patchindex00eaec38a294..d77122789d5e100644meta/recipes-core/base-passwd/base-passwd/0007-Add-wheel-group.patch +0
-0@@ -2,7 +2,7 @@ We need to have a wheel group which has some system privileges to consultthe
systemd journal or manage printers with cups.meta/recipes-core/base-passwd/base-passwd/0007-Add-wheel-group.patch +1
-2-Upstream status says the group does not exist by default. +Upstream says the group does not exist by default. Upstream-Status: Inappropriate [enable feature] --2.40.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#183064):
https://lists.openembedded.org/g/openembedded-core/message/183064
Mute This Topic: https://lists.openembedded.org/mt/99611534/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Quoted 3 lines · Alexander Kanavin
Should the regex that finds these lines be fixed rather? It’s entirely valid to say ‘upstream status’ somewhere, it should be matching ‘Upstream-Status:’ at the start of the line exactly.
The check is deliberately doing fuzzy matching to spot "broken" lines. Whether we need that any more now we have other checks for correct lines is probably a better question...
Cheers,
Richard
Quoted 9 lines · Richard Purdie
Quoted 3 lines · Alexander Kanavin
Should the regex that finds these lines be fixed rather? It’s entirely valid to say ‘upstream status’ somewhere, it should be matching ‘Upstream-Status:’ at the start of the line exactly.
The check is deliberately doing fuzzy matching to spot "broken" lines. Whether we need that any more now we have other checks for correct lines is probably a better question...
Yeah, this was my assumption that doing fuzzy matching was expected.
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com