Skip to contentSkip to conversation

dt-bindings: arm: aspeed: add Inventec starscream-bmc

PATCH Superseded PJ Chen 2 participants 7 messages Jun 19, 2023 – Jun 26, 2023

Subsystems (3)

v5 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

PJ Chen

author
#0 lore raw

PATCH v5 1/2 dt-bindings: arm: aspeed: add Inventec starscream-bmc

From: Chen PJ <[email protected]>

Document the new compatibles used on Inventec starscream-bmc

---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
index 1b585e554791..fb4ce5df2fa0 100644
@@ -82,6 +82,7 @@ properties:
               - ibm,everest-bmc
               - ibm,rainier-bmc
               - ibm,tacoma-bmc
+              - inventec,starscream-bmc
               - inventec,transformer-bmc
               - jabil,rbp-bmc
               - nuvia,dc-scm-bmc
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH v5 2/2 ARM: dts: aspeed: Adding Inventec Starscream BMC

From: Chen PJ <[email protected]>

Initial introduction of Inventec Starscream x86 family equipped with AST2600 BMC SoC.

---
V4 -> V5:
- Remove devices not defined in dt-binding yet.
V3 -> V4:
- Reply with devicetree binding

    https://lore.kernel.org/all/28f0ce0a82464083ae24f9ef2f598425 at inventec.com/
 V2 -> V3:
  - Rename the node name to generic.
 V1 -> V2:
  - Correct License description
  - Remove not supported device
  - Using openbmc-flash-layout.dtsi
  - Correct device format
---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/aspeed-bmc-inventec-starscream.dts    | 465 ++++++++++++++++++
 2 files changed, 466 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts
arch/arm/boot/dts/Makefile +1 -0
index eb681903d50b..6a897ff40ff0 100644
@@ -1629,6 +1629,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-quanta-q71l.dtb \
 	aspeed-bmc-quanta-s6q.dtb \
 	aspeed-bmc-supermicro-x11spi.dtb \
+	aspeed-bmc-inventec-starscream.dtb \
 	aspeed-bmc-inventec-transformers.dtb \
 	aspeed-bmc-tyan-s7106.dtb \
 	aspeed-bmc-tyan-s8036.dtb \
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +465 -0

465 lines not on this page · raw message

Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH v5 2/2] ARM: dts: aspeed: Adding Inventec Starscream BMC

Quoted 7 lines · PJ Chen

From: Chen PJ <[email protected]>

Initial introduction of Inventec Starscream x86 family equipped with AST2600 BMC SoC.

...

Quoted 4 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +4 -0
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;

arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts line 41

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +10 -0
+
+		video_engine_memory: video {
+			size = <0x04000000>;
+			alignment = <0x01000000>;
+			compatible = "shared-dma-pool";
+			reusable;
+		};
+	};
+
+

Drop stray blank lines. Only one blank line, not two. Comment applies to multiple places.

Quoted 12 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +12 -0
+	iio-hwmon {
+		compatible = "iio-hwmon";
+		io-channels =
+		<&adc_u74 0>, // P0_VDD11
+		<&adc_u74 1>, // P1_VDD11
+		<&adc_u74 2>, // P0_3V3_S5
+		<&adc_u74 3>, // P1_3V3_S5
+		<&adc_u74 4>, // P3V3
+		<&adc_u74 5>, // VBAT
+		<&adc_u74 6>, // P3V3_STBY
+		<&adc_u74 7>, // P5V_STBY
+		<&adc_u74 8>, // P5V

arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts line 63

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +10 -0
+		<&adc_u74 9>, // P12V
+		<&adc_u74 10>, // P1_VDD18_S5
+		<&adc_u74 11> // P0_VDD18_S5
+		;
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		uid {

No improvements. Still not fixed and not tested.

Best regards,
Krzysztof

#3 lore raw

PATCH v6 2/2 ARM: dts: aspeed: Adding Inventec Starscream BMC

Initial introduction of Inventec Starscream x86 family equipped with AST2600 BMC SoC.

---
V5 -> V6:
- Remove setting not match dt-binging check.
V4 -> V5:
- Remove devices not defined in dt-binding yet.
V3 -> V4:
- Reply with devicetree binding

    https://lore.kernel.org/all/28f0ce0a82464083ae24f9ef2f598425 at inventec.com/
 V2 -> V3:
  - Rename the node name to generic.
 V1 -> V2:
  - Correct License description
  - Remove not supported device
  - Using openbmc-flash-layout.dtsi
  - Correct device format
---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/aspeed-bmc-inventec-starscream.dts    | 392 ++++++++++++++++++
 2 files changed, 393 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts
arch/arm/boot/dts/Makefile +1 -0
index eb681903d50b..6a897ff40ff0 100644
@@ -1629,6 +1629,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-quanta-q71l.dtb \
 	aspeed-bmc-quanta-s6q.dtb \
 	aspeed-bmc-supermicro-x11spi.dtb \
+	aspeed-bmc-inventec-starscream.dtb \
 	aspeed-bmc-inventec-transformers.dtb \
 	aspeed-bmc-tyan-s7106.dtb \
 	aspeed-bmc-tyan-s8036.dtb \
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +392 -0

392 lines not on this page · raw message

Signature · 1 line
2.25.1
#4 lore raw
In reply to PJ Chen
Quoted 5 lines · PJ Chen

From: Chen PJ <[email protected]>

Document the new compatibles used on Inventec starscream-bmc

https://lore.kernel.org/all/3106c4a1-ce5b-a9c4-5cf4-6adead7fce80 at linaro.org/

https://lore.kernel.org/all/2e06e7db-64f9-51f8-adf1-b240f30a2608 at linaro.org/

What's unclear here? You did not care to respond to that (the second part of that message).

Best regards,
Krzysztof

#5 lore raw

Hi Krzysztof,

Sorry for brothering you and thanks for your patience.

I use "git imap send" and can only send two patch separately.
After your instruction, we setup the smtp server and now send two patch together.

But it seems still not enough.
Did you mean we need to combine two patch that modify the document and dts in "one" patch?

Best Regards
PJ Chen

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Monday, June 19, 2023 2:56 PM
To: Chen.PJ ??? TAO <[email protected]>; Arnd Bergmann <[email protected]>; Olof Johansson <[email protected]>; soc at kernel.org; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>; linux-arm-kernel at lists.infradead.org; devicetree at vger.kernel.org; linux-kernel at vger.kernel.org; linux-aspeed at lists.ozlabs.org
Cc: Ye.Vic ??? TAO <[email protected]>; Huang.Alang ??? TAO <[email protected]>
Subject: Re: [PATCH v5 1/2] dt-bindings: arm: aspeed: add Inventec starscream-bmc

Quoted 5 lines · PJ Chen

From: Chen PJ <[email protected]>

Document the new compatibles used on Inventec starscream-bmc

https://lore.kernel.org/all/3106c4a1-ce5b-a9c4-5cf4-6adead7fce80 at linaro.org/

https://lore.kernel.org/all/2e06e7db-64f9-51f8-adf1-b240f30a2608 at linaro.org/

What's unclear here? You did not care to respond to that (the second part of that message).

Best regards,
Krzysztof

#6 lore raw
Quoted 9 lines · Chen.PJ ??? TAO

Hi Krzysztof,

Sorry for brothering you and thanks for your patience.

I use "git imap send" and can only send two patch separately.
After your instruction, we setup the smtp server and now send two patch together.

But it seems still not enough.
Did you mean we need to combine two patch that modify the document and dts in "one" patch?

No, I meant the second part of my message. The long one, explaining in details what you should do.

Best regards,
Krzysztof