Skip to contentSkip to conversation

automation: Disable QEMU build with Clang older than 10.0

PATCH In review Anthony PERARD 3 participants 3 messages Jun 19, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 automation: Disable QEMU build with Clang older than 10.0

Since QEMU commit 74a1b256d775 ("configure: Bump minimum Clang version to 10.0"), or QEMU v8.0, Clang 10.0 is now the minimum to build QEMU.

QEMU 8.0 fails to build on Ubuntu Bionic.

---

Notes:
I've tested that change here, with QEMU v8.0.2:
https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/902576734

 automation/scripts/build | 2 ++
 1 file changed, 2 insertions(+)
automation/scripts/build +2 -0
index 38c48ae6d8..b4edcf010e 100755
@@ -78,7 +78,9 @@ else
     fi
 
     # Qemu requires Python 3.5 or later, and ninja
+    # and Clang 10 or later
     if ! type python3 || python3 -c "import sys; res = sys.version_info < (3, 5); exit(not(res))" \
+            || [[ "$cc_is_clang" == y && "$cc_ver" -lt 0x0a0000 ]] \
             || ! type ninja; then
         cfgargs+=("--with-system-qemu=/bin/false")
     fi
Signature · 1 line
Anthony PERARD
Acked-by on v1 1/1
#2 lore raw
In reply to Anthony PERARD
Quoted 6 lines · Anthony PERARD

Since QEMU commit 74a1b256d775 ("configure: Bump minimum Clang version to 10.0"), or QEMU v8.0, Clang 10.0 is now the minimum to build QEMU.

QEMU 8.0 fails to build on Ubuntu Bionic.

Quoted 26 lines

---

Notes:
I've tested that change here, with QEMU v8.0.2:
https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/902576734

 automation/scripts/build | 2 ++
 1 file changed, 2 insertions(+)
automation/scripts/build +2 -0
index 38c48ae6d8..b4edcf010e 100755
@@ -78,7 +78,9 @@ else
     fi
 
     # Qemu requires Python 3.5 or later, and ninja
+    # and Clang 10 or later
     if ! type python3 || python3 -c "import sys; res = sys.version_info < (3, 5); exit(not(res))" \
+            || [[ "$cc_is_clang" == y && "$cc_ver" -lt 0x0a0000 ]] \
             || ! type ninja; then
         cfgargs+=("--with-system-qemu=/bin/false")
     fi
Signature · 1 line
Anthony PERARD