Skip to contentSkip to conversation

mmc: core: disable TRIM on Kingston EMMC04G-M627

PATCH In review Robert Marko 2 participants 2 messages Jun 19, 2023 – Jun 20, 2023 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: core: disable TRIM on Kingston EMMC04G-M627

It seems that Kingston EMMC04G-M627 despite advertising TRIM support does not work when the core is trying to use REQ_OP_WRITE_ZEROES.

We are seeing I/O errors in OpenWrt under 6.1 on Zyxel NBG7815 that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES.

Trying to use fstrim seems to also throw errors like:

[93010.835112] I/O error, dev loop0, sector 16902 op 0x3:(DISCARD) flags 0x800 phys_seg 1 prio class 2

Disabling TRIM makes the error go away, so lets add a quirk for this eMMC to disable TRIM.

---
 drivers/mmc/core/quirks.h | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/mmc/core/quirks.h +7 -0
index 77caa0c903f8..8decb788a3db 100644
@@ -107,6 +107,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = {
 	MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc,
 		  MMC_QUIRK_TRIM_BROKEN),
 
+	/*
+	 * Kingston EMMC04G-M627 advertises TRIM but it does not seems to
+	 * support being used to offload WRITE_ZEROES.
+	 */
+	MMC_FIXUP("M62704", CID_MANFID_KINGSTON, 0x0100, add_quirk_mmc,
+		  MMC_QUIRK_TRIM_BROKEN),
+
 	/*
 	 * Some SD cards reports discard support while they don't
 	 */
Signature · 1 line
2.41.0
#1 lore raw
Quoted 7 lines · Robert Marko

It seems that Kingston EMMC04G-M627 despite advertising TRIM support does not work when the core is trying to use REQ_OP_WRITE_ZEROES.

We are seeing I/O errors in OpenWrt under 6.1 on Zyxel NBG7815 that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES.

Quoted 7 lines

Trying to use fstrim seems to also throw errors like:

[93010.835112] I/O error, dev loop0, sector 16902 op 0x3:(DISCARD) flags 0x800 phys_seg 1 prio class 2

Disabling TRIM makes the error go away, so lets add a quirk for this eMMC to disable TRIM.

Applied for next and by adding a stable tag, thanks!

Kind regards
Uffe

Quoted 25 lines
---
 drivers/mmc/core/quirks.h | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/mmc/core/quirks.h +7 -1
index 77caa0c903f8..8decb788a3db 100644
@@ -107,6 +107,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = {
        MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc,
                  MMC_QUIRK_TRIM_BROKEN),
 
+       /*
+        * Kingston EMMC04G-M627 advertises TRIM but it does not seems to
+        * support being used to offload WRITE_ZEROES.
+        */
+       MMC_FIXUP("M62704", CID_MANFID_KINGSTON, 0x0100, add_quirk_mmc,
+                 MMC_QUIRK_TRIM_BROKEN),
+
        /*
         * Some SD cards reports discard support while they don't
         */
--

2.41.0