mm-ptdump-should-use-ptep_get_lockless.patch removed from -mm tree
The quilt patch titled
Subject: mm: ptdump should use ptep_get_lockless()
has been removed from the -mm tree. Its filename was
mm-ptdump-should-use-ptep_get_lockless.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Ryan Roberts <[email protected]>
Subject: mm: ptdump should use ptep_get_lockless()
Date: Mon, 12 Jun 2023 16:15:43 +0100
Patch series "Encapsulate PTE contents from non-arch code", v3.
A series to improve the encapsulation of pte entries by disallowing non-arch code from directly dereferencing pte_t pointers.
This means that by default, the accesses change from a C dereference to a READ_ONCE(). This is technically the correct thing to do since where pgtables are modified by HW (for access/dirty) they are volatile and therefore we should always ensure READ_ONCE() semantics.
But more importantly, by always using the helper, it can be overridden by the architecture to fully encapsulate the contents of the pte. Arch code is deliberately not converted, as the arch code knows best. It is intended that arch code (arm64) will override the default with its own implementation that can (e.g.) hide certain bits from the core code, or determine young/dirty status by mixing in state from another source.
This patch (of 3):
The page table dumper uses walk_page_range_novma() to walk the page tables, which does not lock the PTL before calling the pte_entry() callback. Therefore, the page table dumper's callback must use ptep_get_lockless() rather than ptep_get() to ensure that the pte it reads is not torn or otherwise corrupt when racing with writers.
---
mm/ptdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/ptdump.c renamed from mm/ptdump.c~mm-ptdump-should-use-ptep_get_lockless +1 -1
@@ -119,7 +119,7 @@ static int ptdump_pte_entry(pte_t *pte, unsigned long next, struct mm_walk *walk) { struct ptdump_state *st = walk->private; -pte_t val =ptep_get (pte); +pte_t val =ptep_get_lockless (pte);if (st->effective_prot) st->effective_prot (st,4 ,pte_val (val));
_
Patches currently in -mm which might be from [email protected] are