Skip to contentSkip to conversation

HID: logitech-hidpp: Rename HID++ "internal" error constant

PATCH Applied Bastien Nocera 2 participants 2 messages Jun 20, 2023 – Aug 14, 2023

Subsystems (3)
lore
Share & tools
lore

Bastien Nocera

author reviewer
#0 lore raw

PATCH 1/1 HID: logitech-hidpp: Rename HID++ "internal" error constant

As per the upstream "hidpp" helpers commit:
"
There has been some confusion about error value 5 but feature specs that refer to it generally use NOT_ALLOWED.
"

---
 drivers/hid/hid-logitech-hidpp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid-logitech-hidpp.c +1 -1
index 5e1a412fd28f..2dd86c23412b 100644
@@ -228,7 +228,7 @@ struct hidpp_device {
 #define HIDPP20_ERROR_INVALID_ARGS		0x02
 #define HIDPP20_ERROR_OUT_OF_RANGE		0x03
 #define HIDPP20_ERROR_HW_ERROR			0x04
-#define HIDPP20_ERROR_LOGITECH_INTERNAL		0x05
+#define HIDPP20_ERROR_NOT_ALLOWED		0x05
 #define HIDPP20_ERROR_INVALID_FEATURE_INDEX	0x06
 #define HIDPP20_ERROR_INVALID_FUNCTION_ID	0x07
 #define HIDPP20_ERROR_BUSY			0x08
Signature · 1 line
2.40.1
maintainer Applied
#1 lore raw
Quoted 5 lines · Bastien Nocera

As per the upstream "hidpp" helpers commit:
"
There has been some confusion about error value 5 but feature specs that refer to it generally use NOT_ALLOWED.
"

Applied, thanks.

Signature · 2 lines
Jiri Kosina
SUSE Labs