HID: logitech-hidpp: Rename HID++ "internal" error constant
Subsystems (3)
Bastien Nocera
reviewerPATCH 1/1 HID: logitech-hidpp: Rename HID++ "internal" error constant
As per the upstream "hidpp" helpers commit:
"
There has been some confusion about error value 5 but feature specs that refer to it generally use NOT_ALLOWED.
"
Signed-off-by Bastien Nocera <[email protected]>
--- drivers/hid/hid-logitech-hidpp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid-logitech-hidpp.c +1 -1
@@ -228,7 +228,7 @@ struct hidpp_device {#define HIDPP20_ERROR_INVALID_ARGS 0x02#define HIDPP20_ERROR_OUT_OF_RANGE 0x03#define HIDPP20_ERROR_HW_ERROR 0x04 -#define HIDPP20_ERROR_LOGITECH_INTERNAL 0x05 +#define HIDPP20_ERROR_NOT_ALLOWED 0x05#define HIDPP20_ERROR_INVALID_FEATURE_INDEX 0x06#define HIDPP20_ERROR_INVALID_FUNCTION_ID 0x07#define HIDPP20_ERROR_BUSY 0x08
Signature · 1 line
2.40.1
Quoted 5 lines · Bastien Nocera
As per the upstream "hidpp" helpers commit:
"
There has been some confusion about error value 5 but feature specs that refer to it generally useNOT_ALLOWED.
"
Applied, thanks.
Signature · 2 lines
Jiri Kosina SUSE Labs