Skip to contentSkip to conversation

drm/msm: Fix typo in comment

PATCH In review [email protected] 5 participants 6 messages Jun 19, 2023 – Sep 21, 2023 7 messages not in the archive

Subsystems (6)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

PATCH 1/1 drm/msm: Fix typo in comment

Fix typo in comment of msm_gem.c.

---
 drivers/gpu/drm/msm/msm_gem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/msm/msm_gem.c +0 -0
index 20cfd86d2b32..ef81074416af 100644
@@ -503,8 +503,8 @@ void msm_gem_unpin_locked(struct drm_gem_object *obj)
 
 /* Special unpin path for use in fence-signaling path, avoiding the 

need
* to hold the obj lock by only depending on things that a protected by
- * the LRU lock. In particular we know that that we already have backing
- * and and that the object's dma_resv has the fence for the current
+ * the LRU lock. In particular we know that we already have backing
+ * and that the object's dma_resv has the fence for the current
* submit/job which will prevent us racing against page eviction. */
void msm_gem_unpin_active(struct drm_gem_object *obj)

#3 lore raw
Quoted 6 lines · On 18/06/2023 17:54, [email protected] wrote:

Fix typo in comment of msm_gem.c.

---
  drivers/gpu/drm/msm/msm_gem.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

This patch doesn't apply. Please use git send-email to send patches.

Signature · 2 lines
With best wishes
Dmitry

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw

PATCH 1/1 dma-buf: heaps: Delete repeated word

Delete one of the rebundant word in comment.

---
 drivers/dma-buf/heaps/cma_heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma-buf/heaps/cma_heap.c +1 -1
index a7f048048864..80bc95955188 100644
@@ -319,7 +319,7 @@ static struct dma_buf *cma_heap_allocate(struct dma_heap *heap,
             kunmap_atomic(vaddr);
             /*
              * Avoid wasting time zeroing memory if the process
-             * has been killed by by SIGKILL
+             * has been killed by SIGKILL
              */
             if (fatal_signal_pending(current))
                 goto free_cma;
#6 lore raw

Re: [PATCH] dma-buf: heaps: Delete repeated word

Quoted 22 lines · On Sun, Jun 18, 2023 at 10:50:43PM +0800, [email protected] wrote:

Delete one of the rebundant word in comment.

---
 drivers/dma-buf/heaps/cma_heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma-buf/heaps/cma_heap.c +1 -1
index a7f048048864..80bc95955188 100644
@@ -319,7 +319,7 @@ static struct dma_buf *cma_heap_allocate(struct dma_heap
 *heap,
             kunmap_atomic(vaddr);
             /*
              * Avoid wasting time zeroing memory if the process
-             * has been killed by by SIGKILL
+             * has been killed by SIGKILL
              */
             if (fatal_signal_pending(current))
Quoted 1 line
                 goto free_cma;

Your patch can't be applied because you sent it with Roundcube, which mangles whitespace. Please resend with git-send-email(1) instead. And don't send patches as HTML email, either, because many mailing lists bar HTML mails.

Bye!

Signature · 1 line
An old man doll... just what I always wanted! - Clara

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#9 lore raw

Re: [PATCH] Delete unneeded word in comment

On Sun, 18 Jun 2023 22:47:48 +0800
[email protected] wrote:

Subject needs a topic. Please read:

https://docs.kernel.org/process/submitting-patches.html

Quoted 12 lines

Delete the unneeded word 'with' in comment.

---
  kernel/jump_label.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
kernel/jump_label.c +0 -0
index d9c822bbffb8..08c42ae723ef 100644

kernel/jump_label.c void __init jump_label_init(void) · line 496

Quoted 5 lines
kernel/jump_label.c +1 -1
@@ -493,7 +493,7 @@ void __init jump_label_init(void)
 
      /*
       * Since we are initializing the static_key.enabled field with
-     * with the 'raw' int values (to avoid pulling in atomic.h) in
+     * the 'raw' int values (to avoid pulling in atomic.h) in

Broken whitespace.

-- Steve

Quoted 3 lines
kernel/jump_label.c +0 -0
       * jump_label.h, let's make sure that is safe. There are only two
       * cases to check since we initialize to 0 or 1.
       */

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#12 lore raw

Re: [PATCH] module: Fix comment typo

Quoted 5 lines · On Sun, Jun 18, 2023 at 10:58:43PM +0800, [email protected] wrote:

Delete duplicated word in comment.

---

Applied and pushed, next time please consider sending a slew of typo fixes, just one word is a bit too much trouble for just one patch.

Luis