Skip to contentSkip to conversation

drm/panel: simple: Add connector_type for innolux_at043tn24

PATCH Applied Fabio Estevam 3 participants 3 messages Jun 20, 2023 – Jun 22, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/panel: simple: Add connector_type for innolux_at043tn24

From: Fabio Estevam <[email protected]>

The innolux at043tn24 display is a parallel LCD. Pass the 'connector_type' information to avoid the following warning:

panel-simple panel: Specify missing connector_type

Fixes 41bcceb4de9c ("drm/panel: simple: Add support for Innolux AT043TN24")

---
Changes since v1:
- Pass Fixes tag (Neil).

 drivers/gpu/drm/panel/panel-simple.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/panel/panel-simple.c +1 -0
index a247a0e7c799..7c80528d571e 100644
@@ -2178,6 +2178,7 @@ static const struct panel_desc innolux_at043tn24 = {
 		.height = 54,
 	},
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.connector_type = DRM_MODE_CONNECTOR_DPI,
 	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
 };
 
Signature · 1 line
2.34.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The innolux at043tn24 display is a parallel LCD. Pass the 'connector_type' information to avoid the following warning:

panel-simple panel: Specify missing connector_type

Fixes 41bcceb4de9c ("drm/panel: simple: Add support for Innolux AT043TN24")

Looks good.

I expect someone else to pick it up.

Sam

Quoted 21 lines

---
Changes since v1:
- Pass Fixes tag (Neil).

 drivers/gpu/drm/panel/panel-simple.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/panel/panel-simple.c +1 -0
index a247a0e7c799..7c80528d571e 100644
@@ -2178,6 +2178,7 @@ static const struct panel_desc innolux_at043tn24 = {
 		.height = 54,
 	},
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.connector_type = DRM_MODE_CONNECTOR_DPI,
 	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
 };
 
Signature · 1 line
2.34.1
maintainer Applied
#2 lore raw
In reply to Fabio Estevam

Hi,

Quoted 6 lines · Fabio Estevam

The innolux at043tn24 display is a parallel LCD. Pass the 'connector_type' information to avoid the following warning:

panel-simple panel: Specify missing connector_type

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes)

[1/1] drm/panel: simple: Add connector_type for innolux_at043tn24

      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=2c56a751845ddfd3078ebe79981aaaa182629163
Signature · 1 line
Neil