hw/pci: add comment explaining the reason for checking function 0 in hotplug
PATCH 1/1 hw/pci: add comment explaining the reason for checking function 0 in hotplug
This change is cosmetic. A comment is added explaining why we need to check for the availability of function 0 when we hotplug a device.
Signed-off-by Ani Sinha <[email protected]>
--- hw/pci/pci.c | 5 +++++ 1 file changed, 5 insertions(+)
hw/pci/pci.c +5 -0
@@ -1179,6 +1179,11 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev,PCI_SLOT (devfn),PCI_FUNC (devfn), name, bus->devices[devfn]->name, bus->devices[devfn]->qdev.id);return NULL ; +/* +* Populating function 0 triggers a scan from the guest that +* exposes other non-zero functions. Hence we need to ensure that +* function 0 wasn't added yet. +*/ }else if (dev->hotplugged && !pci_is_vf (pci_dev) &&pci_get_function_0 (pci_dev)) {
Signature · 1 line
2.39.1
Quoted 14 lines · Ani Sinha
This change is cosmetic. A comment is added explaining why we need to check for the availability of function 0 when we hotplug a device.
Signed-off-by Ani Sinha <[email protected]>--- hw/pci/pci.c | 5 +++++ 1 file changed, 5 insertions(+)hw/pci/pci.c +0
-0
hw/pci/pci.c static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, · line 1186
Quoted 8 lines
hw/pci/pci.c +5
-0@@ -1179,6 +1179,11 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev,PCI_SLOT (devfn),PCI_FUNC (devfn), name, bus->devices[devfn]->name, bus->devices[devfn]->qdev.id);return NULL ; +/* +* Populating function 0 triggers a scan from the guest that +* exposes other non-zero functions. Hence we need to ensure that +* function 0 wasn't added yet. +*/
bad place for the comment
hw/pci/pci.c static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, · line 1187
Quoted 1 line
hw/pci/pci.c +0
-0}
stick the comment here
Quoted 1 line
else
or here
Quoted 5 lines
if (
dev->hotplugged&&!pci_is_vf(pci_dev) && pci_get_function_0(pci_dev)) {Signature · 1 line
2.39.1