Skip to contentSkip to conversation

net/igc: disable EEE by default on I225/226

PATCH Applied Matthew Smith 2 participants 2 messages Jun 20, 2023 – Jun 21, 2023 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/igc: disable EEE by default on I225/226

I226-V devices can hang when EEE is enabled. Explicitly disable EEE during initialization of the device, as the Linux and FreeBSD kernel drivers do.

---
 drivers/net/igc/base/igc_i225.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/igc/base/igc_i225.c +4 -0
index 180d3cf687..17a1573064 100644
@@ -122,6 +122,9 @@ static s32 igc_init_mac_params_i225(struct igc_hw *hw)
 
 	mac->ops.write_vfta = igc_write_vfta_generic;
 
+	/* Disable EEE by default */
+	dev_spec->eee_disable = true;
+
 	return IGC_SUCCESS;
 }
 
@@ -1243,6 +1246,7 @@ s32 igc_init_hw_i225(struct igc_hw *hw)
 
 	hw->phy.ops.get_cfg_done = igc_get_cfg_done_i225;
 	ret_val = igc_init_hw_base(hw);
+	igc_set_eee_i225(hw, false, false, false);
 	return ret_val;
 }
 
Signature · 1 line
2.30.1 (Apple Git-130)
Acked-by on v1 1/1 Applied
#1 lore raw
Quoted 9 lines

-----Original Message-----
From: Matthew Smith <[email protected]>
Sent: Tuesday, June 20, 2023 10:56 PM
To: Guo, Junfeng <[email protected]>; Su, Simei <[email protected]>
Cc: [email protected]; Smith, Matthew <[email protected]>
Subject: [PATCH] net/igc: disable EEE by default on I225/226

Quoted 4 lines

I226-V devices can hang when EEE is enabled. Explicitly disable EEE during initialization of the device, as the Linux and FreeBSD kernel drivers do.

Applied to dpdk-next-net-intel.

Thanks
Qi