Skip to contentSkip to conversation

package/firmware-imx: ensure the linux firmware is installed first

PATCH Applied Charles Hardin 4 participants 4 messages Jun 20, 2023 – Aug 25, 2023 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/firmware-imx: ensure the linux firmware is installed first

There was imx SDMA firmware in the base linux-firmware package at one time, but the firmware-imx is updated with the latest versions from NXP releases.

This just ensures a dependency is set so that the imx package will always come later in case an overlap occurs again.

---
 package/freescale-imx/firmware-imx/firmware-imx.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/freescale-imx/firmware-imx/firmware-imx.mk +4 -0
index 99fe71a91c..4cceb67019 100644
@@ -14,6 +14,10 @@ FIRMWARE_IMX_REDISTRIBUTE = NO
 
 FIRMWARE_IMX_INSTALL_IMAGES = YES
 
+ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE),y)
+FIRMWARE_IMX_DEPENDENCIES += linux-firmware
+endif
+
 define FIRMWARE_IMX_EXTRACT_CMDS
 	$(call NXP_EXTRACT_HELPER,$(FIRMWARE_IMX_DL_DIR)/$(FIRMWARE_IMX_SOURCE))
 endef
Signature · 6 lines
2.39.2 (Apple Git-143)

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Reviewed-by on v1 1/1
#1 lore raw

Hi Charles,

Quoted 8 lines · Charles Hardin

There was imx SDMA firmware in the base linux-firmware package at one time, but the firmware-imx is updated with the latest versions from NXP releases.

This just ensures a dependency is set so that the imx package will always come later in case an overlap occurs again.

The above line seems to be here by mistake, please remove.

Quoted 1 line

With that line removed:

Regards,
Gary
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
In reply to Charles Hardin
Quoted 4 lines · On Tue, 20 Jun 2023 10:09:22 -0700 Charles Hardin <[email protected]> wrote:

There was imx SDMA firmware in the base linux-firmware package at one time, but the firmware-imx is updated with the latest versions from NXP releases.

Quoted 8 lines

This just ensures a dependency is set so that the imx package will always come later in case an overlap occurs again.

---
 package/freescale-imx/firmware-imx/firmware-imx.mk | 4 ++++
 1 file changed, 4 insertions(+)

Applied to master, thanks.

That being said, the BR2_PER_PACKAGE_DIRECTORIES=y mechanism requires that packages don't overwrite files installed by other packages, so at some point, this will have to be revisited. But this issue exists for many other packages anyway, and we are far from having addressed all those issues.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw
In reply to Charles Hardin
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Charles" == Charles Hardin <[email protected]> writes:

There was imx SDMA firmware in the base linux-firmware package at one time, but the firmware-imx is updated with the latest versions from NXP releases.

This just ensures a dependency is set so that the imx package will always come later in case an overlap occurs again.

Committed to 2023.02.x and 2023.05.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot