Skip to contentSkip to conversation

kernel-rdepends: Add ti-eth-fw as an RDEPENDS

PATCH Superseded Ryan Eatmon 3 participants 7 messages Jun 20, 2023

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel-rdepends: Add ti-eth-fw as an RDEPENDS

When the ti-eth-fw recipe was split out from the ti-rtos-firmware recipe we forgot to add it as a dependency.

---
 meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 +++
 1 file changed, 3 insertions(+)
meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc +3 -0
index 18984e80..1f0c1ee8 100644
@@ -31,3 +31,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw"
 RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721s2 = " cnm-wave-fw"
 RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j784s4 = " cnm-wave-fw"
 RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am62axx = " cnm-wave-fw"
+
+# Add run-time dependency for TI ETH firmware to the rootfs
+RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:k3 = " ti-eth-fw"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 13 lines · Ryan Eatmon via lists.yoctoproject.org

When the ti-eth-fw recipe was split out from the ti-rtos-firmware recipe we forgot to add it as a dependency.

---
 meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 +++
 1 file changed, 3 insertions(+)
meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc +0 -0
index 18984e80..1f0c1ee8 100644

meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw" · line 36

Quoted 6 lines
meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc +3 -0
@@ -31,3 +31,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw"
 RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721s2 = " cnm-wave-fw"
 RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j784s4 = " cnm-wave-fw"
 RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am62axx = " cnm-wave-fw"
+
+# Add run-time dependency for TI ETH firmware to the rootfs
+RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:k3 = " ti-eth-fw"

Though, ETH FW is only enabled on j721e, j7200 and j784s4:

https://git.yoctoproject.org/meta-ti/commit/?id=91e5a1ca6541012e3d4285479ecf5a9f353307f9

ETH_FW_LIST = ""

ETH_FW_LIST:j721e =   "${ETH_FW}"
ETH_FW_LIST:j7200 =   "${ETH_FW}"
ETH_FW_LIST:j721s2 =  ""
ETH_FW_LIST:j784s4 =  "${ETH_FW}"
ETH_FW_LIST:am65xx =  ""
ETH_FW_LIST:am64xx =  ""
ETH_FW_LIST:am62xx =  ""

ETH_FW_LIST:am62axx = ""

Other platforms generate an empty package w/o the binary in it. So I guess for simpler dependency pulling it for all K3 platforms is an option? On one hand it makes kernel dependencies simpler, but executes build/packaging process for the firmware that ends up being no-op and produce an empty output...

Similar question for DM FW? E.g.:

https://git.yoctoproject.org/meta-ti/commit/?id=b21d29d94694ac49b97a1f4ba428c7d8cd6fb64a

DM_FW_LIST = ""

DM_FW_LIST:j721e =   "${DM_FIRMWARE}"
DM_FW_LIST:j7200 =   "${DM_FIRMWARE}"
DM_FW_LIST:j721s2 =  "${DM_FIRMWARE}"
DM_FW_LIST:j784s4 =  "${DM_FIRMWARE}"
DM_FW_LIST:am65xx =  ""
DM_FW_LIST:am64xx =  ""
DM_FW_LIST:am62xx =  "${DM_FIRMWARE}"

DM_FW_LIST:am62axx = "${DM_FIRMWARE}"

Signature · 1 line
Denys
#2 lore raw
Quoted 33 lines · Denys Dmytriyenko
Quoted 13 lines · Ryan Eatmon via lists.yoctoproject.org

When the ti-eth-fw recipe was split out from the ti-rtos-firmware recipe we forgot to add it as a dependency.

---
  meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 +++
  1 file changed, 3 insertions(+)
meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc +0 -0
index 18984e80..1f0c1ee8 100644

meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw" · line 36

Quoted 6 lines
meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc +3 -0
@@ -31,3 +31,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw"
  RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721s2 = " cnm-wave-fw"
  RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j784s4 = " cnm-wave-fw"
  RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am62axx = " cnm-wave-fw"
+
+# Add run-time dependency for TI ETH firmware to the rootfs
+RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:k3 = " ti-eth-fw"

Though, ETH FW is only enabled on j721e, j7200 and j784s4:

https://git.yoctoproject.org/meta-ti/commit/?id=91e5a1ca6541012e3d4285479ecf5a9f353307f9

ETH_FW_LIST = ""

ETH_FW_LIST:j721e =   "${ETH_FW}"
ETH_FW_LIST:j7200 =   "${ETH_FW}"
ETH_FW_LIST:j721s2 =  ""
ETH_FW_LIST:j784s4 =  "${ETH_FW}"
ETH_FW_LIST:am65xx =  ""
ETH_FW_LIST:am64xx =  ""
ETH_FW_LIST:am62xx =  ""
Quoted 6 lines

ETH_FW_LIST:am62axx = ""

Other platforms generate an empty package w/o the binary in it. So I guess for simpler dependency pulling it for all K3 platforms is an option? On one hand it makes kernel dependencies simpler, but executes build/packaging process for the firmware that ends up being no-op and produce an empty output...

Andrew and I talked about. It seems annoying to have to update two files to add a platform, BUT doing it this way does mean we execute the recipe when the recipe does nothing...

This is sort of a holdover from the ti-rtos-firmware way of doing things.

Let me think about it...

Quoted 14 lines

Similar question for DM FW? E.g.:

https://git.yoctoproject.org/meta-ti/commit/?id=b21d29d94694ac49b97a1f4ba428c7d8cd6fb64a

DM_FW_LIST = ""

DM_FW_LIST:j721e =   "${DM_FIRMWARE}"
DM_FW_LIST:j7200 =   "${DM_FIRMWARE}"
DM_FW_LIST:j721s2 =  "${DM_FIRMWARE}"
DM_FW_LIST:j784s4 =  "${DM_FIRMWARE}"
DM_FW_LIST:am65xx =  ""
DM_FW_LIST:am64xx =  ""
DM_FW_LIST:am62xx =  "${DM_FIRMWARE}"

DM_FW_LIST:am62axx = "${DM_FIRMWARE}"

Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
#3 lore raw
Quoted 43 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 35 lines · Denys Dmytriyenko
Quoted 16 lines · Ryan Eatmon via lists.yoctoproject.org

When the ti-eth-fw recipe was split out from the ti-rtos-firmware recipe we forgot to add it as a dependency.

---
  meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 +++

  1 file changed, 3 insertions(+)
meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc +0 -0
index 18984e80..1f0c1ee8 100644
@@ -31,3 +31,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw"

  RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721s2 = " cnm-wave-fw" RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j784s4 = " cnm-wave-fw" RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am62axx = " cnm-wave-fw"

meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw" · line 36

Quoted 3 lines
meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc +3 -0
+
+# Add run-time dependency for TI ETH firmware to the rootfs
+RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:k3 = " ti-eth-fw"

Though, ETH FW is only enabled on j721e, j7200 and j784s4:

https://git.yoctoproject.org/meta-ti/commit/?id=91e5a1ca6541012e3d4285479ecf5a9f353307f9

ETH_FW_LIST = ""
ETH_FW_LIST:j721e =   "${ETH_FW}"
ETH_FW_LIST:j7200 =   "${ETH_FW}"
ETH_FW_LIST:j721s2 =  ""
ETH_FW_LIST:j784s4 =  "${ETH_FW}"
ETH_FW_LIST:am65xx =  ""
ETH_FW_LIST:am64xx =  ""
ETH_FW_LIST:am62xx =  ""
ETH_FW_LIST:am62axx = ""

Quoted 4 lines

Other platforms generate an empty package w/o the binary in it. So I guess for simpler dependency pulling it for all K3 platforms is an option? On one hand it makes kernel dependencies simpler, but executes build/packaging process for the firmware that ends up being no-op and produce an empty output...

Quoted 6 lines

Andrew and I talked about.  It seems annoying to have to update two files to add a platform, BUT doing it this way does mean we execute the recipe when the recipe does nothing...

This is sort of a holdover from the ti-rtos-firmware way of doing things.

Let me think about it...

Another thing we may want to do is not have this recipe be device specific, it is just a small firmware, no good reason to only deploy one per device. I'd say we ship all unconditionally in this package, then it won't have to be re-built for each device either.

Andrew

Quoted 25 lines
Quoted 4 lines

Similar question for DM FW? E.g.:

https://git.yoctoproject.org/meta-ti/commit/?id=b21d29d94694ac49b97a1f4ba428c7d8cd6fb64a

Quoted 10 lines

DM_FW_LIST = ""
DM_FW_LIST:j721e =   "${DM_FIRMWARE}"
DM_FW_LIST:j7200 =   "${DM_FIRMWARE}"
DM_FW_LIST:j721s2 =  "${DM_FIRMWARE}"
DM_FW_LIST:j784s4 =  "${DM_FIRMWARE}"
DM_FW_LIST:am65xx =  ""
DM_FW_LIST:am64xx =  ""
DM_FW_LIST:am62xx =  "${DM_FIRMWARE}"
DM_FW_LIST:am62axx = "${DM_FIRMWARE}"

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#16746): https://lists.yoctoproject.org/g/meta-ti/message/16746
Mute This Topic: https://lists.yoctoproject.org/mt/99648797/3619733
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/leave/6695306/3619733/2033773410/xyzzy [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#4 lore raw
Quoted 48 lines · Andrew Davis
Quoted 47 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 35 lines · Denys Dmytriyenko
Quoted 16 lines · Ryan Eatmon via lists.yoctoproject.org

When the ti-eth-fw recipe was split out from the ti-rtos-firmware recipe we forgot to add it as a dependency.

---
  meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 +++

  1 file changed, 3 insertions(+)
meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc +0 -0
index 18984e80..1f0c1ee8 100644
@@ -31,3 +31,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw"

  RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721s2 = " cnm-wave-fw" RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j784s4 = " cnm-wave-fw" RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am62axx = " cnm-wave-fw"

meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw" · line 36

Quoted 3 lines
meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc +3 -0
+
+# Add run-time dependency for TI ETH firmware to the rootfs
+RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:k3 = " ti-eth-fw"

Though, ETH FW is only enabled on j721e, j7200 and j784s4:

https://git.yoctoproject.org/meta-ti/commit/?id=91e5a1ca6541012e3d4285479ecf5a9f353307f9

ETH_FW_LIST = ""
ETH_FW_LIST:j721e =   "${ETH_FW}"
ETH_FW_LIST:j7200 =   "${ETH_FW}"
ETH_FW_LIST:j721s2 =  ""
ETH_FW_LIST:j784s4 =  "${ETH_FW}"
ETH_FW_LIST:am65xx =  ""
ETH_FW_LIST:am64xx =  ""
ETH_FW_LIST:am62xx =  ""
ETH_FW_LIST:am62axx = ""

Quoted 4 lines

Other platforms generate an empty package w/o the binary in it. So I guess for simpler dependency pulling it for all K3 platforms is an option? On one hand it makes kernel dependencies simpler, but executes build/packaging process for the firmware that ends up being no-op and produce an empty output...

Andrew and I talked about.  It seems annoying to have to update two files to add a platform, BUT doing it this way does mean we execute the recipe when the recipe does nothing...

This is sort of a holdover from the ti-rtos-firmware way of doing things.

Quoted 7 lines
Quoted 2 lines

Let me think about it...

Another thing we may want to do is not have this recipe be device specific, it is just a small firmware, no good reason to only deploy one per device. I'd say we ship all unconditionally in this package, then it won't have to be re-built for each device either.

Is the binary identical between the platforms?

Quoted 15 lines

Andrew

Quoted 13 lines
Quoted 13 lines

Similar question for DM FW? E.g.:

https://git.yoctoproject.org/meta-ti/commit/?id=b21d29d94694ac49b97a1f4ba428c7d8cd6fb64a

DM_FW_LIST = ""
DM_FW_LIST:j721e =   "${DM_FIRMWARE}"
DM_FW_LIST:j7200 =   "${DM_FIRMWARE}"
DM_FW_LIST:j721s2 =  "${DM_FIRMWARE}"
DM_FW_LIST:j784s4 =  "${DM_FIRMWARE}"
DM_FW_LIST:am65xx =  ""
DM_FW_LIST:am64xx =  ""
DM_FW_LIST:am62xx =  "${DM_FIRMWARE}"
DM_FW_LIST:am62axx = "${DM_FIRMWARE}"

#5 lore raw
Quoted 52 lines · Denys Dmytriyenko
Quoted 51 lines · Andrew Davis
Quoted 49 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 35 lines · Denys Dmytriyenko
Quoted 13 lines · Ryan Eatmon via lists.yoctoproject.org

When the ti-eth-fw recipe was split out from the ti-rtos-firmware recipe we forgot to add it as a dependency.

---
   meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 +++
   1 file changed, 3 insertions(+)
meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc +0 -0
index 18984e80..1f0c1ee8 100644

meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw" · line 36

Quoted 6 lines
meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc +3 -0
@@ -31,3 +31,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw"
   RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721s2 = " cnm-wave-fw"
   RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j784s4 = " cnm-wave-fw"
   RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am62axx = " cnm-wave-fw"
+
+# Add run-time dependency for TI ETH firmware to the rootfs
+RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:k3 = " ti-eth-fw"

Though, ETH FW is only enabled on j721e, j7200 and j784s4:

https://git.yoctoproject.org/meta-ti/commit/?id=91e5a1ca6541012e3d4285479ecf5a9f353307f9

ETH_FW_LIST = ""
ETH_FW_LIST:j721e =   "${ETH_FW}"
ETH_FW_LIST:j7200 =   "${ETH_FW}"
ETH_FW_LIST:j721s2 =  ""
ETH_FW_LIST:j784s4 =  "${ETH_FW}"
ETH_FW_LIST:am65xx =  ""
ETH_FW_LIST:am64xx =  ""
ETH_FW_LIST:am62xx =  ""
ETH_FW_LIST:am62axx = ""

Quoted 4 lines

Other platforms generate an empty package w/o the binary in it. So I guess for simpler dependency pulling it for all K3 platforms is an option? On one hand it makes kernel dependencies simpler, but executes build/packaging process for the firmware that ends up being no-op and produce an empty output...

Andrew and I talked about.  It seems annoying to have to update two files to add a platform, BUT doing it this way does mean we execute the recipe when the recipe does nothing...

This is sort of a holdover from the ti-rtos-firmware way of doing things.

Let me think about it...

Quoted 7 lines
Quoted 4 lines

Another thing we may want to do is not have this recipe be device specific, it is just a small firmware, no good reason to only deploy one per device. I'd say we ship all unconditionally in this package, then it won't have to be re-built for each device either.

Is the binary identical between the platforms?

No, but the binaries are named differently for each platform, so they do not conflict. Same as most other firmware packages, ship all the related firmware in the same package, and let the kernel pick the firmware it actually needs based on name for the platform currently running.

Andrew

Quoted 16 lines
Quoted 16 lines

Andrew

Quoted 13 lines
Quoted 13 lines

Similar question for DM FW? E.g.:

https://git.yoctoproject.org/meta-ti/commit/?id=b21d29d94694ac49b97a1f4ba428c7d8cd6fb64a

DM_FW_LIST = ""
DM_FW_LIST:j721e =   "${DM_FIRMWARE}"
DM_FW_LIST:j7200 =   "${DM_FIRMWARE}"
DM_FW_LIST:j721s2 =  "${DM_FIRMWARE}"
DM_FW_LIST:j784s4 =  "${DM_FIRMWARE}"
DM_FW_LIST:am65xx =  ""
DM_FW_LIST:am64xx =  ""
DM_FW_LIST:am62xx =  "${DM_FIRMWARE}"
DM_FW_LIST:am62axx = "${DM_FIRMWARE}"

#6 lore raw
Quoted 58 lines · Andrew Davis
Quoted 57 lines · Denys Dmytriyenko
Quoted 55 lines · Andrew Davis
Quoted 43 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 35 lines · Denys Dmytriyenko
Quoted 16 lines · Ryan Eatmon via lists.yoctoproject.org

When the ti-eth-fw recipe was split out from the ti-rtos-firmware recipe we forgot to add it as a dependency.

---
  meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 +++

  1 file changed, 3 insertions(+)
meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc +0 -0
index 18984e80..1f0c1ee8 100644
@@ -31,3 +31,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw"

  RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721s2 = " cnm-wave-fw" RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j784s4 = " cnm-wave-fw" RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am62axx = " cnm-wave-fw"

meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw" · line 36

Quoted 3 lines
meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc +3 -0
+
+# Add run-time dependency for TI ETH firmware to the rootfs
+RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:k3 = " ti-eth-fw"

Though, ETH FW is only enabled on j721e, j7200 and j784s4:

https://git.yoctoproject.org/meta-ti/commit/?id=91e5a1ca6541012e3d4285479ecf5a9f353307f9

ETH_FW_LIST = ""
ETH_FW_LIST:j721e =   "${ETH_FW}"
ETH_FW_LIST:j7200 =   "${ETH_FW}"
ETH_FW_LIST:j721s2 =  ""
ETH_FW_LIST:j784s4 =  "${ETH_FW}"
ETH_FW_LIST:am65xx =  ""
ETH_FW_LIST:am64xx =  ""
ETH_FW_LIST:am62xx =  ""
ETH_FW_LIST:am62axx = ""

Quoted 4 lines

Other platforms generate an empty package w/o the binary in it. So I guess for simpler dependency pulling it for all K3 platforms is an option? On one hand it makes kernel dependencies simpler, but executes build/packaging process for the firmware that ends up being no-op and produce an empty output...

Quoted 6 lines

Andrew and I talked about.  It seems annoying to have to update two files to add a platform, BUT doing it this way does mean we execute the recipe when the recipe does nothing...

This is sort of a holdover from the ti-rtos-firmware way of doing things.

Let me think about it...

Another thing we may want to do is not have this recipe be device specific, it is just a small firmware, no good reason to only deploy one per device. I'd say we ship all unconditionally in this package, then it won't have to be re-built for each device either.

Quoted 7 lines
Quoted 2 lines

Is the binary identical between the platforms?

No, but the binaries are named differently for each platform, so they do not conflict. Same as most other firmware packages, ship all the related firmware in the same package, and let the kernel pick the firmware it actually needs based on name for the platform currently running.

Ah, I see. Yeah, that could work.

Signature · 1 line
Denys