Skip to contentSkip to conversation

Btrfs fix for 6.4-rc8

GIT PULL Merged David Sterba 4 participants 4 messages Jun 20, 2023 Btrfs file system

lore
Share & tools
lore

David Sterba

author maintainer
#0 lore raw

Hi,

one more regression fix for an assertion failure that uncovered a nasty problem with stripe calculations. This is caused by a u32 overflow when there are enough devices. The fstests require 6 so this hasn't been caught, I was able to hit it with 8.

The fix is minimal and only adds u64 casts, we'll clean that up later. I did various additional tests to be sure. Please pull, thanks.

----------------------------------------------------------------
The following changes since commit b50f2d048ecf1512ff85128ea4153bceb0e60590:

btrfs: scrub: fix a return value overwrite in scrub_stripe() (2023-06-14 18:30:30 +0200)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-6.4-rc7-tag

for you to fetch changes up to a7299a18a179a9713651fce9ad00972a633c14a9:

btrfs: fix u32 overflows when left shifting stripe_nr (2023-06-20 19:10:31 +0200)

----------------------------------------------------------------
Qu Wenruo (1):
btrfs: fix u32 overflows when left shifting stripe_nr

 fs/btrfs/volumes.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
#1 lore raw
Quoted 2 lines · David Sterba

git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-6.4-rc7-tag

I think you forgot to push the tag.

I see 'refs/heads/for-6.4-rc7' in your repo that contains the commit you mention, but no corresponding signed tag.

Linus

#2 lore raw
Quoted 8 lines · Linus Torvalds
Quoted 2 lines · David Sterba

git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-6.4-rc7-tag

I think you forgot to push the tag.

I see 'refs/heads/for-6.4-rc7' in your repo that contains the commit you mention, but no corresponding signed tag.

Ah right, sorry, now pushed.

merge bot Merged
#3 lore raw
In reply to David Sterba
The pull request you sent on Tue, 20 Jun 2023 20:24:01 +0200:

The pull request you sent on Tue, 20 Jun 2023 20:24:01 +0200:

Quoted 1 line

git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-6.4-rc7-tag

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/4b0c7a1ba09386e26cf9e55cd375af8e0f48662e

Thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html