drm/msm/a2xx: Call adreno_gpu_init() earlier
Subsystems (3)
PATCH v3 1/1 drm/msm/a2xx: Call adreno_gpu_init() earlier
From: Fabio Estevam <[email protected]>
The adreno_is_a20x() and adreno_is_a225() functions rely on the GPU revision, but such information is retrieved inside adreno_gpu_init(), which is called afterwards.
Fix this problem by caling adreno_gpu_init() earlier, so that the GPU information revision is available when adreno_is_a20x() and adreno_is_a225() run.
Tested on a imx53-qsb board.
---
Hi,
This error has been exposed by a recent commit in linux-next:
cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set")
, but the error has been present since the very first a2xx commit.
Changes since v2:
- Call adreno_gpu_init() earlier.
drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/msm/adreno/a2xx_gpu.c +4 -4
@@ -540,6 +540,10 @@ struct msm_gpu *a2xx_gpu_init(struct drm_device *dev) gpu->perfcntrs = perfcntrs; gpu->num_perfcntrs =ARRAY_SIZE (perfcntrs); + ret =adreno_gpu_init (dev, pdev, adreno_gpu, &funcs,1 ); +if (ret) + goto fail; +if (adreno_is_a20x (adreno_gpu)) adreno_gpu->registers = a200_registers;else if (adreno_is_a225 (adreno_gpu))
@@ -547,10 +551,6 @@ struct msm_gpu *a2xx_gpu_init(struct drm_device *dev)else adreno_gpu->registers = a220_registers; - ret =adreno_gpu_init (dev, pdev, adreno_gpu, &funcs,1 ); -if (ret) - goto fail; -if (!gpu->aspace) {dev_err (dev->dev,"No memory protection without MMU\n" );if (!allow_vram_carveout) {
Signature · 1 line
2.34.1
Quoted 17 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
The
adreno_is_a20x()andadreno_is_a225()functions rely on the GPU revision, but such information is retrieved insideadreno_gpu_init(), which is called afterwards.Fix this problem by caling
adreno_gpu_init()earlier, so that the GPU information revision is available whenadreno_is_a20x()andadreno_is_a225()run.Tested on a imx53-qsb board.
Fixes 21af872cd8c6 ("drm/msm/adreno: add a2xx")Signed-off-by Fabio Estevam <[email protected]>---
Hi,
Quoted 8 lines
This error has been exposed by a recent commit in linux-next:
cc943f43ece7("drm/msm/adreno: warn if chip revn is verified before being set"), but the error has been present since the very first a2xx commit.
Changes since v2:
- Calladreno_gpu_init()earlier.
Quoted 3 lines
drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Signature · 2 lines
With best wishes Dmitry
Hi Rob,
A gentle ping.
Quoted 40 lines · Dmitry Baryshkov
Quoted 17 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
The
adreno_is_a20x()andadreno_is_a225()functions rely on the GPU revision, but such information is retrieved insideadreno_gpu_init(), which is called afterwards.Fix this problem by caling
adreno_gpu_init()earlier, so that the GPU information revision is available whenadreno_is_a20x()andadreno_is_a225()run.Tested on a imx53-qsb board.
Fixes 21af872cd8c6 ("drm/msm/adreno: add a2xx")Signed-off-by Fabio Estevam <[email protected]>---
Hi,Quoted 8 lines
This error has been exposed by a recent commit in linux-next:
cc943f43ece7("drm/msm/adreno: warn if chip revn is verified before being set"), but the error has been present since the very first a2xx commit.
Changes since v2:
- Calladreno_gpu_init()earlier.Reviewed-by Dmitry Baryshkov <[email protected]>Quoted 3 lines
drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)--
With best wishes
Dmitry
Hi Rob,
Any comments, please?
Quoted 47 lines · Fabio Estevam
Hi Rob,
A gentle ping.
Quoted 40 lines · Dmitry Baryshkov
Quoted 17 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
The
adreno_is_a20x()andadreno_is_a225()functions rely on the GPU revision, but such information is retrieved insideadreno_gpu_init(), which is called afterwards.Fix this problem by caling
adreno_gpu_init()earlier, so that the GPU information revision is available whenadreno_is_a20x()andadreno_is_a225()run.Tested on a imx53-qsb board.
Fixes 21af872cd8c6 ("drm/msm/adreno: add a2xx")Signed-off-by Fabio Estevam <[email protected]>---
Hi,Quoted 8 lines
This error has been exposed by a recent commit in linux-next:
cc943f43ece7("drm/msm/adreno: warn if chip revn is verified before being set"), but the error has been present since the very first a2xx commit.
Changes since v2:
- Calladreno_gpu_init()earlier.Reviewed-by Dmitry Baryshkov <[email protected]>Quoted 3 lines
drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)--
With best wishes
Dmitry
It is in https://gitlab.freedesktop.org/drm/msm/-/merge_requests/75 so should be in msm-next for v6.6
BR,
-R
Quoted 53 lines · Fabio Estevam
Hi Rob,
Any comments, please?
Quoted 47 lines · Fabio Estevam
Hi Rob,
A gentle ping.
Quoted 40 lines · Dmitry Baryshkov
Quoted 17 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
The
adreno_is_a20x()andadreno_is_a225()functions rely on the GPU revision, but such information is retrieved insideadreno_gpu_init(), which is called afterwards.Fix this problem by caling
adreno_gpu_init()earlier, so that the GPU information revision is available whenadreno_is_a20x()andadreno_is_a225()run.Tested on a imx53-qsb board.
Fixes 21af872cd8c6 ("drm/msm/adreno: add a2xx")Signed-off-by Fabio Estevam <[email protected]>---
Hi,Quoted 8 lines
This error has been exposed by a recent commit in linux-next:
cc943f43ece7("drm/msm/adreno: warn if chip revn is verified before being set"), but the error has been present since the very first a2xx commit.
Changes since v2:
- Calladreno_gpu_init()earlier.Reviewed-by Dmitry Baryshkov <[email protected]>Quoted 3 lines
drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)--
With best wishes
Dmitry