drivers/staging/rtl8192e Fix camelcased function name

PATCH In review Tree Davies 3 participants 3 messages Jun 19, 2023 – Jun 20, 2023 Staging

Share & tools

Tree Davies

author

2023-06-19 23:40 UTC #0 lore raw

PATCH 1/1 drivers/staging/rtl8192e Fix camelcased function name

From b66f420d2129bb45e0dc79128e517524607cf3b3 Mon Sep 17 00:00:00 2001
From: Tree Davies <[email protected]>
Date: Mon, 19 Jun 2023 14:06:33 -0700
Subject: [PATCH] drivers/staging/rtl8192e Fix camelcased function name

This fixes style issue for function name HTUpdateDefaultSetting -> ht_update_default_setting

Signed-off-by Tree Davies <[email protected]>

---
 drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
 drivers/staging/rtl8192e/rtllib.h         | 2 +-
 drivers/staging/rtl8192e/rtllib_module.c  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

drivers/staging/rtl8192e/rtl819x_HTProc.c +1 -1

index fe30a291e64c..117b675a210d 100644
@@ -67,7 +67,7 @@ static u8 CISCO_BROADCOM[3] = {0x00, 0x17, 0x94};
 
 static u8 LINKSYS_MARVELL_4400N[3] = {0x00, 0x14, 0xa4};
 
-void HTUpdateDefaultSetting(struct rtllib_device *ieee)
+void ht_update_default_setting(struct rtllib_device *ieee)
 {
 	struct rt_hi_throughput *ht_info = ieee->ht_info;

drivers/staging/rtl8192e/rtllib.h +1 -1

index 6e665e866f1f..48b3c832affa 100644
@@ -2037,7 +2037,7 @@ int rtllib_wx_get_rts(struct rtllib_device *ieee, struct iw_request_info *info,
 void HTSetConnectBwMode(struct rtllib_device *ieee,
 			enum ht_channel_width bandwidth,
 			enum ht_extchnl_offset Offset);
-void HTUpdateDefaultSetting(struct rtllib_device *ieee);
+void ht_update_default_setting(struct rtllib_device *ieee);
 void HTConstructCapabilityElement(struct rtllib_device *ieee,
 				  u8 *posHTCap, u8 *len,
 				  u8 isEncrypt, bool bAssoc);

drivers/staging/rtl8192e/rtllib_module.c +1 -1

index d6a4d6b4ec57..841300e3a8bc 100644
@@ -129,7 +129,7 @@ struct net_device *alloc_rtllib(int sizeof_priv)
 	if (!ieee->ht_info)
 		goto free_softmac;
 
-	HTUpdateDefaultSetting(ieee);
+	ht_update_default_setting(ieee);
 	HTInitializeHTInfo(ieee);
 	TSInitialize(ieee);
 	for (i = 0; i < IEEE_IBSS_MAC_HASH_SIZE; i++)

Signature · 1 line

2.39.2

Dan Carpenter

2023-06-20 05:36 UTC #1 lore raw

You can't send a patch as an attachment. The subject isn't right. Do git log --oneline drivers/staging/rtl8192e/ to see what to use.

Read my blog about how to send a second version of a patch.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter

Greg KH

maintainer

2023-06-20 05:43 UTC #2 lore raw

In reply to Tree Davies

Quoted 57 lines · Tree Davies

Quoted 1 line

From b66f420d2129bb45e0dc79128e517524607cf3b3 Mon Sep 17 00:00:00 2001

From: Tree Davies <[email protected]>
Date: Mon, 19 Jun 2023 14:06:33 -0700
Subject: [PATCH] drivers/staging/rtl8192e Fix camelcased function name

This fixes style issue for function name HTUpdateDefaultSetting -> ht_update_default_setting

Signed-off-by Tree Davies <[email protected]>

---
 drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
 drivers/staging/rtl8192e/rtllib.h         | 2 +-
 drivers/staging/rtl8192e/rtllib_module.c  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

drivers/staging/rtl8192e/rtl819x_HTProc.c +1 -1

index fe30a291e64c..117b675a210d 100644
@@ -67,7 +67,7 @@ static u8 CISCO_BROADCOM[3] = {0x00, 0x17, 0x94};
 
 static u8 LINKSYS_MARVELL_4400N[3] = {0x00, 0x14, 0xa4};
 
-void HTUpdateDefaultSetting(struct rtllib_device *ieee)
+void ht_update_default_setting(struct rtllib_device *ieee)
 {
 	struct rt_hi_throughput *ht_info = ieee->ht_info;

drivers/staging/rtl8192e/rtllib.h +1 -1

index 6e665e866f1f..48b3c832affa 100644
@@ -2037,7 +2037,7 @@ int rtllib_wx_get_rts(struct rtllib_device *ieee, struct iw_request_info *info,
 void HTSetConnectBwMode(struct rtllib_device *ieee,
 			enum ht_channel_width bandwidth,
 			enum ht_extchnl_offset Offset);
-void HTUpdateDefaultSetting(struct rtllib_device *ieee);
+void ht_update_default_setting(struct rtllib_device *ieee);
 void HTConstructCapabilityElement(struct rtllib_device *ieee,
 				  u8 *posHTCap, u8 *len,
 				  u8 isEncrypt, bool bAssoc);

drivers/staging/rtl8192e/rtllib_module.c +1 -1

index d6a4d6b4ec57..841300e3a8bc 100644
@@ -129,7 +129,7 @@ struct net_device *alloc_rtllib(int sizeof_priv)
 	if (!ieee->ht_info)
 		goto free_softmac;
 
-	HTUpdateDefaultSetting(ieee);
+	ht_update_default_setting(ieee);
 	HTInitializeHTInfo(ieee);
 	TSInitialize(ieee);
 	for (i = 0; i < IEEE_IBSS_MAC_HASH_SIZE; i++)

Signature · 1 line

2.39.2

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- Your patch was attached, please place it inline so that it can be applied directly from the email message itself.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot