Skip to contentSkip to conversation

arm: dts: am335x-evm-u-boot: Remove usb0 mode configuration

PATCH Superseded Julien Panis 1 participant 1 message Jun 29, 2023 Arm (32-bit)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 arm: dts: am335x-evm-u-boot: Remove usb0 mode configuration

This USB port configuration is moved to 'am335x-evm.dts'.

---
Initially, this series was submitted to fix usb0 dr_mode for am335x-icev2 and am335x-evmsk. It must be set to 'peripheral' in order to avoid 'no USB device found' error, in usb_ether_init() function.

It was finally decided to move usb0 mode configuration in kernel device trees. That's why a series was submitted for linux:
https://lore.kernel.org/all/[email protected]/

As a consequence, usb0 dr_mode configuration must now be
removed from 'am335x-evm-u-boot.dtsi', since this fragment
needs to go in linux too.
---
Changes in v3:
- Remove usb0 dr_mode configuration from 'am335x-evm-u-boot.dtsi'.
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Drop the modification made in arch/arm/mach-omap2/am33xx/board.c
- Configure usb0 dr_mode as peripheral in 'am335x-icev2-u-boot.dtsi'
and 'am335x-evmsk-u-boot.dtsi' device trees.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 arch/arm/dts/am335x-evm-u-boot.dtsi | 4 ----
 1 file changed, 4 deletions(-)
arch/arm/dts/am335x-evm-u-boot.dtsi +0 -4
index 82a483ae3e28..42eeca8c0499 100644
@@ -23,10 +23,6 @@
 	status = "disabled";
 };
 
-&usb0 {
-	dr_mode = "peripheral";
-};
-
 &i2c0 {
 	bootph-all;
 };

---
base-commit: 19b77d3d23966a0d6dbb3c86187765f11100fb6f
change-id: 20230621-fix_usb_ether_init-4bf4f1135113

Best regards,

Signature · 1 line
Julien Panis <[email protected]>