Skip to contentSkip to conversation

netavark, xen: *.patch: add Upstream-Status to all patches

PATCH In review Martin Jansa 2 participants 4 messages Jun 21, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netavark, xen: *.patch: add Upstream-Status to all patches

There is new patch-status QA check in oe-core:
https://git.openembedded.org/openembedded-core/commit/?id=76a685bfcf927593eac67157762a53259089ea8a

This is temporary work around just to hide _many_ warnings from optional patch-status (if you add it to WARN_QA).

This just added
Upstream-Status: Pending
everywhere without actually investigating what's the proper status.

This is just to hide current QA warnings and to catch new .patch files being added without Upstream-Status, but the number of Pending patches is now:

Patches in Pending state: 15 (11%)

---
 recipes-containers/netavark/files/tests.patch                   | 2 ++
 .../xen/files/0001-python-pygrub-pass-DISTUTILS-xen-4.18.patch  | 2 ++
 2 files changed, 4 insertions(+)
recipes-containers/netavark/files/tests.patch +2 -0
index 254e4e9..c4b3618 100644
@@ -1,3 +1,5 @@
+Upstream-Status: Pending
+
 diff --git a/test/helpers.bash b/test/helpers.bash
 index 89866ec..017b2b5 100644
 --- a/test/helpers.bash
recipes-extended/xen/files/0001-python-pygrub-pass-DISTUTILS-xen-4.18.patch +2 -0
index 3c7a97d..7ac1a39 100644
@@ -1,3 +1,5 @@
+Upstream-Status: Pending
+
 diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile
 index 4963bc89c6..c1c05eb421 100644
 --- a/tools/pygrub/Makefile
Signature · 1 line
2.41.0
#1 lore raw
Quoted 7 lines · Martin Jansa

There is new patch-status QA check in oe-core:
https://git.openembedded.org/openembedded-core/commit/?id=76a685bfcf927593eac67157762a53259089ea8a

This is temporary work around just to hide _many_ warnings from optional patch-status (if you add it to WARN_QA).

Quoted 6 lines

This just added
Upstream-Status: Pending
everywhere without actually investigating what's the proper status.

This is just to hide current QA warnings and to catch new .patch files being added without Upstream-Status, but the number of Pending patches is now:

Pending is fine.

I have no intention of doing anything more with the warning fixup (since my opinion on forcing ths on non-core layers and documenting it within the patches themselves is well documented :)

Bruce

Quoted 41 lines

Patches in Pending state: 15 (11%)

---
 recipes-containers/netavark/files/tests.patch                   | 2 ++
 .../xen/files/0001-python-pygrub-pass-DISTUTILS-xen-4.18.patch  | 2 ++
 2 files changed, 4 insertions(+)
recipes-containers/netavark/files/tests.patch +2 -0
index 254e4e9..c4b3618 100644
@@ -1,3 +1,5 @@
+Upstream-Status: Pending
+
 diff --git a/test/helpers.bash b/test/helpers.bash
 index 89866ec..017b2b5 100644
 --- a/test/helpers.bash
recipes-extended/xen/files/0001-python-pygrub-pass-DISTUTILS-xen-4.18.patch +2 -1
index 3c7a97d..7ac1a39 100644
@@ -1,3 +1,5 @@
+Upstream-Status: Pending
+
 diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile
 index 4963bc89c6..c1c05eb421 100644
 --- a/tools/pygrub/Makefile
--

2.41.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#8099): https://lists.yoctoproject.org/g/meta-virtualization/message/8099
Mute This Topic: https://lists.yoctoproject.org/mt/99673711/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
author Acked-by
#2 lore raw
Quoted 15 lines · Bruce Ashfield
Quoted 3 lines · Martin Jansa

There is new patch-status QA check in oe-core:

https://git.openembedded.org/openembedded-core/commit/?id=76a685bfcf927593eac67157762a53259089ea8a

Quoted 9 lines

This is temporary work around just to hide _many_ warnings from optional patch-status (if you add it to WARN_QA).

This just added
Upstream-Status: Pending
everywhere without actually investigating what's the proper status.

This is just to hide current QA warnings and to catch new .patch files

Quoted 9 lines

being

Quoted 1 line

added without Upstream-Status, but the number of Pending patches is now:

Pending is fine.

I have no intention of doing anything more with the warning fixup (since my opinion on forcing ths on non-core layers and documenting it within the patches themselves is well documented :)

That's fine with me. I'm even willing to send further Upstream-Status fixes if I spot new ones in my world build (now I've enabled patch-status in ERROR_QA globally instead of just for oe-core recipes, so that I don't need to explicitly list the layers I regularly use in some of my builds)

:)

Quoted 57 lines

Bruce

Review

Quoted 10 lines

Patches in Pending state: 15 (11%)

---
 recipes-containers/netavark/files/tests.patch                   | 2 ++
 .../xen/files/0001-python-pygrub-pass-DISTUTILS-xen-4.18.patch  | 2 ++
 2 files changed, 4 insertions(+)
(quoted diff) +0 -0

b/recipes-containers/netavark/files/tests.patch

Quoted 10 lines

index 254e4e9..c4b3618 100644

recipes-containers/netavark/files/tests.patch +2 -0
@@ -1,3 +1,5 @@
+Upstream-Status: Pending
+
 diff --git a/test/helpers.bash b/test/helpers.bash
 index 89866ec..017b2b5 100644
 --- a/test/helpers.bash

diff --git

a/recipes-extended/xen/files/0001-python-pygrub-pass-DISTUTILS-xen-4.18.patch b/recipes-extended/xen/files/0001-python-pygrub-pass-DISTUTILS-xen-4.18.patch

Quoted 2 lines

index 3c7a97d..7ac1a39 100644
---

a/recipes-extended/xen/files/0001-python-pygrub-pass-DISTUTILS-xen-4.18.patch

Quoted 1 line

+++

b/recipes-extended/xen/files/0001-python-pygrub-pass-DISTUTILS-xen-4.18.patch

Quoted 10 lines
recipes-containers/netavark/files/tests.patch +2 -1
@@ -1,3 +1,5 @@
+Upstream-Status: Pending
+
 diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile
 index 4963bc89c6..c1c05eb421 100644
 --- a/tools/pygrub/Makefile
--

2.41.0

Quoted 3 lines

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#8099):

https://lists.yoctoproject.org/g/meta-virtualization/message/8099

Quoted 3 lines

Mute This Topic: https://lists.yoctoproject.org/mt/99673711/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub

[[email protected]]

Quoted 2 lines

-=-=-=-=-=-=-=-=-=-=-=-

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

#3 lore raw
Quoted 18 lines · Martin Jansa
Quoted 16 lines · Bruce Ashfield
Quoted 13 lines · Martin Jansa

There is new patch-status QA check in oe-core:
https://git.openembedded.org/openembedded-core/commit/?id=76a685bfcf927593eac67157762a53259089ea8a

This is temporary work around just to hide _many_ warnings from optional patch-status (if you add it to WARN_QA).

This just added
Upstream-Status: Pending
everywhere without actually investigating what's the proper status.

This is just to hide current QA warnings and to catch new .patch files being added without Upstream-Status, but the number of Pending patches is now:

Quoted 8 lines
Quoted 5 lines

Pending is fine.

I have no intention of doing anything more with the warning fixup (since my opinion on forcing ths on non-core layers and documenting it within the patches themselves is well documented :)

That's fine with me. I'm even willing to send further Upstream-Status fixes if I spot new ones in my world build (now I've enabled patch-status in ERROR_QA globally instead of just for oe-core recipes, so that I don't need to explicitly list the layers I regularly use in some of my builds)

Please do. I'll definitely merge them. I'm just confirming that your effort level is appropriate with the broad use of 'pending'.

I'll turn the warning on here as well, that way I'll catch malformed status on the way in.

Bruce

Quoted 55 lines

:)

Quoted 50 lines

Bruce

Quoted 33 lines

Patches in Pending state: 15 (11%)

---
 recipes-containers/netavark/files/tests.patch                   | 2 ++
 .../xen/files/0001-python-pygrub-pass-DISTUTILS-xen-4.18.patch  | 2 ++
 2 files changed, 4 insertions(+)
recipes-containers/netavark/files/tests.patch +2 -0
index 254e4e9..c4b3618 100644
@@ -1,3 +1,5 @@
+Upstream-Status: Pending
+
 diff --git a/test/helpers.bash b/test/helpers.bash
 index 89866ec..017b2b5 100644
 --- a/test/helpers.bash
recipes-extended/xen/files/0001-python-pygrub-pass-DISTUTILS-xen-4.18.patch +2 -1
index 3c7a97d..7ac1a39 100644
@@ -1,3 +1,5 @@
+Upstream-Status: Pending
+
 diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile
 index 4963bc89c6..c1c05eb421 100644
 --- a/tools/pygrub/Makefile
--

2.41.0

Quoted 8 lines

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#8099): https://lists.yoctoproject.org/g/meta-virtualization/message/8099
Mute This Topic: https://lists.yoctoproject.org/mt/99673711/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II