Skip to contentSkip to conversation

Hook up 8280 SCM icc

PATCH Applied Konrad Dybcio 4 participants 6 messages Jun 22, 2023 – Jul 10, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover Hook up 8280 SCM icc

The icc handle for SCM was missing on 8280. Add it.

---
Konrad Dybcio (2):
dt-bindings: firmware: qcom,scm: Allow interconnect on SC8280XP
arm64: dts: qcom: sc8280xp: Add missing SCM interconnect

 Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi                   | 1 +
 2 files changed, 2 insertions(+)

---
base-commit: c87d46a9e8ebd2f2c3960927b1d21687096d1109
change-id: 20230622-topic-8280scmicc-e6af92e226bb

Best regards,

Signature · 1 line
Konrad Dybcio <[email protected]>
#1 lore raw

PATCH 1/2 dt-bindings: firmware: qcom,scm: Allow interconnect on SC8280XP

Just like all other Qualcomm SoCs, SC8280XP SCM should be fed an interconnect path. Do so.

---
 Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/firmware/qcom,scm.yaml +1 -0
index 09073e1d88ff..42d064be753b 100644
@@ -174,6 +174,7 @@ allOf:
             contains:
               enum:
                 - qcom,scm-qdu1000
+                - qcom,scm-sc8280xp
                 - qcom,scm-sm8450
                 - qcom,scm-sm8550
     then:
Signature · 1 line
2.41.0
Acked-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] dt-bindings: firmware: qcom,scm: Allow interconnect on SC8280XP

Quoted 4 lines · Konrad Dybcio

Just like all other Qualcomm SoCs, SC8280XP SCM should be fed an interconnect path. Do so.

Cheers,
Conor.

Quoted 20 lines
---
 Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/firmware/qcom,scm.yaml +1 -0
index 09073e1d88ff..42d064be753b 100644
@@ -174,6 +174,7 @@ allOf:
             contains:
               enum:
                 - qcom,scm-qdu1000
+                - qcom,scm-sc8280xp
                 - qcom,scm-sm8450
                 - qcom,scm-sm8550
     then:
Signature · 2 lines
-- 
2.41.0
#3 lore raw

PATCH 2/2 arm64: dts: qcom: sc8280xp: Add missing SCM interconnect

In reply to Konrad Dybcio

The SCM interconnect path was missing. Add it.

Fixes 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
---
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/qcom/sc8280xp.dtsi +1 -0
index ac0596dfdbc4..0756b7c141ff 100644
@@ -298,6 +298,7 @@ CLUSTER_SLEEP_0: cluster-sleep-0 {
 	firmware {
 		scm: scm {
 			compatible = "qcom,scm-sc8280xp", "qcom,scm";
+			interconnects = <&aggre2_noc MASTER_CRYPTO 0 &mc_virt SLAVE_EBI1 0>;
 		};
 	};
 
Signature · 1 line
2.41.0
Reviewed-by Tested-by on the v1 series
#4 lore raw
In reply to Konrad Dybcio
Quoted 5 lines · Konrad Dybcio

The icc handle for SCM was missing on 8280. Add it.

Konrad Dybcio (2):
dt-bindings: firmware: qcom,scm: Allow interconnect on SC8280XP
arm64: dts: qcom: sc8280xp: Add missing SCM interconnect

Appears to work and matches the vendor dts, but no sign of any "performance benefit" as mentioned in 65b7ebda5028 ("firmware: qcom_scm:
Add bw voting support to the SCM interface") during fw load at boot.

Johan

maintainer Applied
#5 lore raw

Re: (subset) [PATCH 0/2] Hook up 8280 SCM icc

In reply to Konrad Dybcio
Quoted 3 lines · Konrad Dybcio

The icc handle for SCM was missing on 8280. Add it.

Applied, thanks!

[2/2] arm64: dts: qcom: sc8280xp: Add missing SCM interconnect

      commit: 0a69ccf20b0837db857abfc94d7e3bacf1cb771b

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>