Hook up 8280 SCM icc
cover Hook up 8280 SCM icc
The icc handle for SCM was missing on 8280. Add it.
---
Konrad Dybcio (2):
dt-bindings: firmware: qcom,scm: Allow interconnect on SC8280XP
arm64: dts: qcom: sc8280xp: Add missing SCM interconnect
Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 + arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 + 2 files changed, 2 insertions(+)
---
base-commit: c87d46a9e8ebd2f2c3960927b1d21687096d1109
change-id: 20230622-topic-8280scmicc-e6af92e226bb
Best regards,
Signature · 1 line
Konrad Dybcio <[email protected]>
PATCH 1/2 dt-bindings: firmware: qcom,scm: Allow interconnect on SC8280XP
Just like all other Qualcomm SoCs, SC8280XP SCM should be fed an interconnect path. Do so.
--- Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/firmware/qcom,scm.yaml +1 -0
@@ -174,6 +174,7 @@ allOf: contains: enum: - qcom,scm-qdu1000 + - qcom,scm-sc8280xp - qcom,scm-sm8450 - qcom,scm-sm8550 then:
Signature · 1 line
2.41.0
Re: [PATCH 1/2] dt-bindings: firmware: qcom,scm: Allow interconnect on SC8280XP
Quoted 4 lines · Konrad Dybcio
Just like all other Qualcomm SoCs, SC8280XP SCM should be fed an interconnect path. Do so.
Signed-off-by Konrad Dybcio <[email protected]>
Cheers,
Conor.
Quoted 20 lines
--- Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/firmware/qcom,scm.yaml +1
-0@@ -174,6 +174,7 @@ allOf: contains: enum: - qcom,scm-qdu1000 + - qcom,scm-sc8280xp - qcom,scm-sm8450 - qcom,scm-sm8550 then:Signature · 2 lines
-- 2.41.0
PATCH 2/2 arm64: dts: qcom: sc8280xp: Add missing SCM interconnect
In reply to Konrad DybcioThe SCM interconnect path was missing. Add it.
--- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/qcom/sc8280xp.dtsi +1 -0
@@ -298,6 +298,7 @@ CLUSTER_SLEEP_0: cluster-sleep-0 { firmware { scm: scm { compatible = "qcom,scm-sc8280xp", "qcom,scm"; + interconnects = <&aggre2_noc MASTER_CRYPTO 0 &mc_virt SLAVE_EBI1 0>; }; };
Signature · 1 line
2.41.0
Quoted 5 lines · Konrad Dybcio
The icc handle for SCM was missing on 8280. Add it.
Konrad Dybcio (2):
dt-bindings: firmware: qcom,scm: Allow interconnect on SC8280XP
arm64: dts: qcom: sc8280xp: Add missing SCM interconnect
Appears to work and matches the vendor dts, but no sign of any "performance benefit" as mentioned in 65b7ebda5028 ("firmware: qcom_scm:
Add bw voting support to the SCM interface") during fw load at boot.
Johan
Re: (subset) [PATCH 0/2] Hook up 8280 SCM icc
In reply to Konrad DybcioQuoted 3 lines · Konrad Dybcio
The icc handle for SCM was missing on 8280. Add it.
Applied, thanks!
[2/2] arm64: dts: qcom: sc8280xp: Add missing SCM interconnect
commit: 0a69ccf20b0837db857abfc94d7e3bacf1cb771b
Best regards,
Signature · 1 line
Bjorn Andersson <[email protected]>