Skip to contentSkip to conversation

po/de.po: Fix possible typo which makes gettext-0.22 unhappy

PATCH In review Lars Wendler 3 participants 7 messages Jun 21, 2023 – Jun 22, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 po/de.po: Fix possible typo which makes gettext-0.22 unhappy

See downstream bug report: https://bugs.gentoo.org/908864

---
 po/de.po | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
po/de.po +1 -1
index 944b0e91..a6f8fde1 100644
@@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n"
 #: .././estimate/xfs_estimate.c:191
 #, c-format
 msgid "%s will take about %.1f megabytes\n"
-msgstr "%s wird etwa %.lf Megabytes einnehmen\n"
+msgstr "%s wird etwa %.1f Megabytes einnehmen\n"
 
 #: .././estimate/xfs_estimate.c:198
 #, c-format

--
2.41.0

#1 lore raw

po/de.po msgstr "%llu Spezialdateien\n" · line 3087

Quoted 10 lines · Lars Wendler
po/de.po +1 -1
index 944b0e91..a6f8fde1 100644
@@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n"
  #: .././estimate/xfs_estimate.c:191
  #, c-format
  msgid "%s will take about %.1f megabytes\n"
-msgstr "%s wird etwa %.lf Megabytes einnehmen\n"
+msgstr "%s wird etwa %.1f Megabytes einnehmen\n"

I don't see the difference..?
Both the added and removed line are the same.

-h

#2 lore raw

Am Wed, 21 Jun 2023 13:29:03 +0200
schrieb Holger Hoffstätte <[email protected]>:

Quoted 15 lines · Lars Wendler

po/de.po msgstr "%llu Spezialdateien\n" · line 3087

Quoted 10 lines
po/de.po +1 -1
index 944b0e91..a6f8fde1 100644
@@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n"
  #: .././estimate/xfs_estimate.c:191
  #, c-format
  msgid "%s will take about %.1f megabytes\n"
-msgstr "%s wird etwa %.lf Megabytes einnehmen\n"
+msgstr "%s wird etwa %.1f Megabytes einnehmen\n"

I don't see the difference..?
Both the added and removed line are the same.

Quoted 1 line

-h

I suppose depending on the font, it's quite hard to distinguish the two lines.
The removed line contains "%.lf" with a lowercase letter L. The added line contains "%.1f" where the lowercase letter L was replaced with the digit 1.

Cheers
Lars

#3 lore raw
Quoted 18 lines · Lars Wendler

Am Wed, 21 Jun 2023 13:29:03 +0200
schrieb Holger Hoffstätte <[email protected]>:

Quoted 15 lines · Lars Wendler

po/de.po msgstr "%llu Spezialdateien\n" · line 3087

Quoted 10 lines
po/de.po +1 -1
index 944b0e91..a6f8fde1 100644
@@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n"
   #: .././estimate/xfs_estimate.c:191
   #, c-format
   msgid "%s will take about %.1f megabytes\n"
-msgstr "%s wird etwa %.lf Megabytes einnehmen\n"
+msgstr "%s wird etwa %.1f Megabytes einnehmen\n"

I don't see the difference..?
Both the added and removed line are the same.

Quoted 7 lines
Quoted 1 line

-h

I suppose depending on the font, it's quite hard to distinguish the two lines.
The removed line contains "%.lf" with a lowercase letter L. The added line contains "%.1f" where the lowercase letter L was replaced with the digit 1.

Ahh..of course! Zooming in did the trick, I see the difference now. Thanks!

-h

#4 lore raw
In reply to Lars Wendler
Quoted 18 lines · Lars Wendler

Am Wed, 21 Jun 2023 13:29:03 +0200
schrieb Holger Hoffstätte <[email protected]>:

Quoted 15 lines · Lars Wendler

po/de.po msgstr "%llu Spezialdateien\n" · line 3087

Quoted 10 lines
po/de.po +1 -1
index 944b0e91..a6f8fde1 100644
@@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n"
  #: .././estimate/xfs_estimate.c:191
  #, c-format
  msgid "%s will take about %.1f megabytes\n"
-msgstr "%s wird etwa %.lf Megabytes einnehmen\n"
+msgstr "%s wird etwa %.1f Megabytes einnehmen\n"

I don't see the difference..?
Both the added and removed line are the same.

Quoted 4 lines
Quoted 1 line

-h

I suppose depending on the font, it's quite hard to distinguish the two lines.

I didn't see it, and the commit message doesn't explain anything, either. Pointing to a bugzilla somewhere does not make a valid commit message....

Quoted 3 lines

The removed line contains "%.lf" with a lowercase letter L. The added line contains "%.1f" where the lowercase letter L was replaced with the digit 1.

... whereas this explains what the bug being fixed is, and allows the reviewer to see the subtle change being made. i.e. you just wrote the commit message that should have been in the patch in the first place. :)

Can you please resend the fix with the commit message updated?

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]
#5 lore raw

PATCH 1/1 xfsprogs: po/de.po: Fix possible typo which makes gettext-0.22 unhappy

The removed line contains "%.lf" with a lowercase letter L. The added line contains "%.1f" where the lowercase letter L was replaced with the digit 1.

---
 po/de.po | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
po/de.po +1 -1
index 944b0e91..a6f8fde1 100644
@@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n"
 #: .././estimate/xfs_estimate.c:191
 #, c-format
 msgid "%s will take about %.1f megabytes\n"
-msgstr "%s wird etwa %.lf Megabytes einnehmen\n"
+msgstr "%s wird etwa %.1f Megabytes einnehmen\n"
 
 #: .././estimate/xfs_estimate.c:198
 #, c-format

--
2.41.0

Reviewed-by on v1 1/1
#6 lore raw

Re: [PATCH] xfsprogs: po/de.po: Fix possible typo which makes gettext-0.22 unhappy

Quoted 14 lines · Lars Wendler

The removed line contains "%.lf" with a lowercase letter L. The added line contains "%.1f" where the lowercase letter L was replaced with the digit 1.

---
 po/de.po | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
po/de.po +0 -0
index 944b0e91..a6f8fde1 100644

po/de.po msgstr "%llu Spezialdateien\n" · line 3090

Quoted 8 lines
po/de.po +1 -1
@@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n"
 #: .././estimate/xfs_estimate.c:191
 #, c-format
 msgid "%s will take about %.1f megabytes\n"
-msgstr "%s wird etwa %.lf Megabytes einnehmen\n"
+msgstr "%s wird etwa %.1f Megabytes einnehmen\n"
 
 #: .././estimate/xfs_estimate.c:198
 #, c-format

Thanks Lars, looks good!

Signature · 2 lines
Dave Chinner
[email protected]